Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 21:59:20 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Shengjiu Wang <shengjiu.wang@gmail.com>
Cc:     Shengjiu Wang <shengjiu.wang@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>, joy.zou@nxp.com,
        NXP Linux Team <linux-imx@nxp.com>,
        dmaengine@vger.kernel.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dmaengine: imx-sdma: Add FIFO stride support for
 multi FIFO script
Message-ID: <YsW4YHL9+HkQndva@matsya>
References: <1655782566-21386-1-git-send-email-shengjiu.wang@nxp.com>
 <YsUlESAPklVFxpzy@matsya>
 <CAA+D8AOST1wK0G=65ufrhPrH8AQ0w-r1pMF5DOnqBauQtx7AOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA+D8AOST1wK0G=65ufrhPrH8AQ0w-r1pMF5DOnqBauQtx7AOg@mail.gmail.com>
Precedence: bulk

On 06-07-22, 14:54, Shengjiu Wang wrote:
> On Wed, Jul 6, 2022 at 2:00 PM Vinod Koul <vkoul@kernel.org> wrote:
> 
> > On 21-06-22, 11:36, Shengjiu Wang wrote:
> > > The peripheral may have several FIFOs, but some case just select
> > > some FIFOs from them for data transfer, which means FIFO0 and FIFO2
> > > may be selected. So add FIFO address stride support, 0 means all FIFOs
> > > are continuous, 1 means 1 word stride between FIFOs. All stride between
> > > FIFOs should be same.
> > >
> > > Another option words_per_fifo means how many audio channel data copied
> > > to one FIFO one time, 1 means one channel per FIFO, 2 means 2 channels
> > > per FIFO.
> > >
> > > If 'n_fifos_src =  4' and 'words_per_fifo = 2', it means the first two
> > > words(channels) fetch from FIFO0 and then jump to FIFO1 for next two
> > words,
> > > and so on after the last FIFO3 fetched, roll back to FIFO0.
> >
> > this fails to apply for me, pls rebase on dmaengine/next and revise
> >
> >
> > it based on my another commit, the one that fixes the struct documentation
> should I send them together?

Pls mention that in patch title.. I have applied that, so rebase and
resend please

-- 
~Vinod