Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 13:45:09 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     kwankhede@nvidia.com, corbet@lwn.net, hca@linux.ibm.com,
        gor@linux.ibm.com, agordeev@linux.ibm.com,
        borntraeger@linux.ibm.com, svens@linux.ibm.com,
        zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
        jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
        rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com,
        airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com,
        mjrosato@linux.ibm.com, pasic@linux.ibm.com, vneethv@linux.ibm.com,
        oberpar@linux.ibm.com, freude@linux.ibm.com,
        akrowiak@linux.ibm.com, jjherne@linux.ibm.com,
        alex.williamson@redhat.com, cohuck@redhat.com,
        kevin.tian@intel.com, hch@infradead.org, jchrist@linux.ibm.com,
        kvm@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void
Message-ID: <20220706164509.GH693670@nvidia.com>
References: <20220706062759.24946-1-nicolinc@nvidia.com>
 <20220706062759.24946-2-nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220706062759.24946-2-nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IE42i86wRKtCboBgtfOzGazp1nQJHBk+2lBdOMDX8fEHgP4mBXIar8kdpbHR?=
 =?us-ascii?Q?2G53Lssmr7GSNO6qIWuATlRdkkUOyO2KmlppjqyOkKSZH/jsJMxH9HEdAdng?=
 =?us-ascii?Q?x4JoKeHu+95RC/xzDHkKbengUBaMiag/r5SB1k3BKuQfxeVA0XfESh30gU39?=
 =?us-ascii?Q?cNmbV6vEIIFb/7Wq10IzhtrQnkZJU9xtiCzx8Xg0DLXZYr3V3qMyLRil67bU?=
 =?us-ascii?Q?oNQu/JpAsxgmf739wCQSPJOk7k4ymDrk9TSs9aHCsdzfVaUbpucAn3J77BTU?=
 =?us-ascii?Q?pLVYGdicfZ5nW1yCAqxQRNEDx6ZUzHqgE4UFP6LsaPNKBKipnl6a1504sXpe?=
 =?us-ascii?Q?cofMpx1gdKpqLiYowoCqr2z4juqqJK6T9Cw6BJT8QluZs57bozxxl2gQ3vTL?=
 =?us-ascii?Q?z9VNb0dCa0ZpONM6eaAvM9/saH5AA9UCKZPVhI5i7E7OULZ4YMJiD3HQL+HR?=
 =?us-ascii?Q?uzNNGu17ugbvi/UamrE7hjsFvUEElXB5dOOUyqQLOXLmWILMuxrGeEnSGG1q?=
 =?us-ascii?Q?4ZXcirH0FZyzTv2a9tkDeJF8j4S0Gl4Eat04/7ZAh8qoVeWrSyARsYVb6CLr?=
 =?us-ascii?Q?zgSsGSJjcD32Nfk/2nCC2v5bcRnSYPiZLhMyLYcihRvpcbXe01rHaFwL+Kbx?=
 =?us-ascii?Q?Vrt/9LydDWCLHLjdry4z4i1xMlBpsaWYuylouk7GD4CqAZMUkiGwES8UySKm?=
 =?us-ascii?Q?sQOo102w0+HVmBuFrhvkDdYRzRj78EgHybfpNaFSMJaGUk6nYdTVGDfnsJqx?=
 =?us-ascii?Q?nAv60kbkG2OEQ/mqoxr6GPiFjkcbJCPPAqseCY1C6uSiPqm8WJvzkdX1L7cv?=
 =?us-ascii?Q?FoRs+mWDzfJN2Y76Xh5bHWa6i+OJnleoAAULly/N4J5IQGpUEOOaccANfg3V?=
 =?us-ascii?Q?uuG6hn7ucG5vOCCnvYlwjrOAlJjZDXoldA+98PWZFgM4apR/PMrlQEyo+Ps3?=
 =?us-ascii?Q?48aBzHRtso/SXGwJ3Gv79gm4kaj57akqCQooBk5b8gDsYDMBAhT516IaV7jT?=
 =?us-ascii?Q?k3AYQkQ1sTK+kOJU9RwCKlOI03+QCrVC7HTJkGHCcekEZW7vUuguCSeXBv1p?=
 =?us-ascii?Q?YaJX/sDtPyOty2/V1ti9UnWjx2tNa3BUJs2YOyPtshWBwvYvQti0o+NbtJKp?=
 =?us-ascii?Q?Kmt8Erm2NspuiivWxPvOqir5bv1yiICno+mT4N68tEPVvRtOWHxyG4JMRAPv?=
 =?us-ascii?Q?B5uIq2B89mAwiNv/hcGTTNnF89582uWnLix6AhP0MK8g0u2kmcX2XHbiygIX?=
 =?us-ascii?Q?iUSfRe3iPCIJYS6RdlTHzQPWNqa+CyJsdyFb6vRIbNVRIBXne5prWDd2YxaO?=
 =?us-ascii?Q?ePXZ+cItnwy27XeUdTFMbdqKAXEQFYTGD0P0BM4Rgz1XI22r6k0AeNEfSeCU?=
 =?us-ascii?Q?8aUXVZDCRVYZRz7mwC9R4jUQKpJ4/hS5amiswwtxjFSDjX1q239nzP1UlyNn?=
 =?us-ascii?Q?AQdFPbkSyTMDa9Q47OI7eqX/8r72vcU57ca7ZU9StVKdSKglTWqObRDo2vc8?=
 =?us-ascii?Q?1QUtDb1RdS0nF/DVIpkNjCErcL/Siyco7rqaV3UNPXXWxiEzQ8Rhjf8wyCX2?=
 =?us-ascii?Q?x0I1lxWgAEapbSouiKNCmlqactq9jcSet2fs7GA0?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 438bc0ad-aa18-4fd6-0d3d-08da5f6ee460
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 16:45:11.0918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zDXF7gX5UTpoDQpo/7yfNVC7JkGANmgHWTTNRjSdtoZdxOueCYVE1tbRL7YQDvx7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6550
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 05, 2022 at 11:27:51PM -0700, Nicolin Chen wrote:
> There's only one caller that checks its return value with a WARN_ON_ONCE,
> while all other callers do not check return value at all. So simplify the
> API to return void by embedding similar WARN_ON_ONCEs.
> 
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  .../driver-api/vfio-mediated-device.rst       |  2 +-
>  drivers/gpu/drm/i915/gvt/kvmgt.c              |  5 +---
>  drivers/vfio/vfio.c                           | 24 ++++++++-----------
>  drivers/vfio/vfio.h                           |  2 +-
>  drivers/vfio/vfio_iommu_type1.c               | 16 ++++++-------
>  include/linux/vfio.h                          |  4 ++--
>  6 files changed, 23 insertions(+), 30 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason