Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <16319b56-4b14-6f51-23c6-6b78b87119d7@ti.com>
Date:   Wed, 6 Jul 2022 13:10:56 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 6/6] arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220705170340.26719-1-afd@ti.com>
 <20220705170340.26719-6-afd@ti.com> <20220706180446.cyzujuasovjvsofk@lively>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <20220706180446.cyzujuasovjvsofk@lively>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/6/22 1:04 PM, Nishanth Menon wrote:
> On 12:03-20220705, Andrew Davis wrote:
>> J7200 has an instance of SA2UL in the MCU domain.
>> Add DT node for the same.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>>   .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi      | 20 +++++++++++++++++++
>>   1 file changed, 20 insertions(+)
> 
> Please split this series into what crypto maintainers need to pick up vs
> what I need to pick up for dts. patches for my tree need to have lakml
> in cc as a rule (see MAINTAINERS file).
> 

Okay, I'll break the first two into their own series. Adding LAKML folks
for v2.

>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
>> index 1044ec6c4b0d4..ebad3642c8e30 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
>> @@ -375,4 +375,24 @@ mcu_r5fss0_core1: r5f@41400000 {
>>   			ti,loczrama = <1>;
>>   		};
>>   	};
>> +
>> +	mcu_crypto: crypto@40900000 {
>> +		compatible = "ti,j721e-sa2ul";
>> +		reg = <0x00 0x40900000 0x00 0x1200>;
>> +		power-domains = <&k3_pds 265 TI_SCI_PD_SHARED>;
>> +		#address-cells = <2>;
>> +		#size-cells = <2>;
>> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
>> +		dmas = <&mcu_udmap 0xf501>, <&mcu_udmap 0x7502>,
>> +		       <&mcu_udmap 0x7503>;
>> +		dma-names = "tx", "rx1", "rx2";
>> +		dma-coherent;
>> +
>> +		rng: rng@40910000 {
>> +			compatible = "inside-secure,safexcel-eip76";
>> +			reg = <0x00 0x40910000 0x00 0x7d>;
>> +			interrupts = <GIC_SPI 945 IRQ_TYPE_LEVEL_HIGH>;
> 
> Please document why disabled.
> 

Sure thing, will add background info to the commit message.

Thanks,
Andrew

>> +			status = "disabled";
>> +		};
>> +	};
>>   };
>> -- 
>> 2.36.1
>>
>