Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220629060435.25297-1-vidyas@nvidia.com> <20220629060435.25297-3-vidyas@nvidia.com>
 <20220630210449.GA3283899-robh@kernel.org> <e971a557-3387-efcf-87ec-983b998c5e93@nvidia.com>
In-Reply-To: <e971a557-3387-efcf-87ec-983b998c5e93@nvidia.com>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 6 Jul 2022 12:11:31 -0600
Message-ID: <CAL_JsqJQVJerfojCku9tmSa1_b2EDkvVgCs+2SvCmjCMe+gfyA@mail.gmail.com>
Subject: Re: [PATCH V3 02/11] dt-bindings: pci: tegra: Convert to json-schema
To:     Vidya Sagar <vidyas@nvidia.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jon Hunter <jonathanh@nvidia.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod <vkoul@kernel.org>, Krzysztof Wilczynski <kw@linux.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        PCI <linux-pci@vger.kernel.org>, devicetree@vger.kernel.org,
        linux-tegra <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>,
        Krishna Thota <kthota@nvidia.com>,
        Manikanta Maddireddy <mmaddireddy@nvidia.com>,
        sagar.tv@gmail.com, Thierry Reding <treding@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 6, 2022 at 3:53 AM Vidya Sagar <vidyas@nvidia.com> wrote:
>
>
>
> On 7/1/2022 2:34 AM, Rob Herring wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Wed, Jun 29, 2022 at 11:34:26AM +0530, Vidya Sagar wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> Convert the Tegra194 PCIe bindings from the free-form text format to
> >> json-schema.
> >>
> >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >> ---

> >> +  nvidia,bpmp:
> >> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> >> +    description: |
> >> +      Must contain a pair of phandle to BPMP controller node followed by controller ID. Following
> >> +      are the controller IDs for each controller:
> >> +
> >> +        0: C0
> >> +        1: C1
> >> +        2: C2
> >> +        3: C3
> >> +        4: C4
> >> +        5: C5
> >> +    items:
> >> +      - items:
> >> +          - minimum: 0
> >> +            maximum: 0xffffffff
> >
> > That's already the limit. Just a description is fine.
> >
> >> +          - enum: [ 0, 1, 2, 3, 4, 5 ]
> >
> > maximum: 5
>
> Setting the maximum to '5' is resulting in the following error.
>
> pcie-ep@141a0000: nvidia,bpmp:0:0: 4294967295 is greater than the
> maximum of 5
>
> Could you please help me understand why I'm seeing this error?

This is what you need:

items:
  - items:
      - description: phandle to BPMP controller node
      - description: controller ID
        maximum: 5