Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 15:18:10 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     kwankhede@nvidia.com, corbet@lwn.net, hca@linux.ibm.com,
        gor@linux.ibm.com, agordeev@linux.ibm.com,
        borntraeger@linux.ibm.com, svens@linux.ibm.com,
        zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
        jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
        rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com,
        airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com,
        mjrosato@linux.ibm.com, pasic@linux.ibm.com, vneethv@linux.ibm.com,
        oberpar@linux.ibm.com, freude@linux.ibm.com,
        akrowiak@linux.ibm.com, jjherne@linux.ibm.com,
        alex.williamson@redhat.com, cohuck@redhat.com,
        kevin.tian@intel.com, hch@infradead.org, jchrist@linux.ibm.com,
        kvm@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFT][PATCH v2 9/9] vfio: Replace phys_pfn with pages for
 vfio_pin_pages()
Message-ID: <20220706181810.GQ693670@nvidia.com>
References: <20220706062759.24946-1-nicolinc@nvidia.com>
 <20220706062759.24946-10-nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220706062759.24946-10-nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PyhFlks/ERCaJ2+h/dHFP90aRbULkoWUm8LjUuh8nrm9qCx25lftiNk3xkJe?=
 =?us-ascii?Q?KI5/HX0373LR4e+PKVFiX4kHMyQ1xOVXTLxDacpa6aod4amiZblMguuJMz7A?=
 =?us-ascii?Q?rlKJlskseFraz8XLmfe1EhVuKSIkhLfHFwEhKRNLuYkPqzovRCiNleYXyN4K?=
 =?us-ascii?Q?IEqYS30Chpf5xM8I0wLgYdgSHqiwXyGBcebwLGay5eOqXSv7jIafHTsagTlv?=
 =?us-ascii?Q?xAleETOPVuoi8dNmXgcmx7kduJpPHKP52B1W3tBPikwwCeJ0z48sRTkFf8WK?=
 =?us-ascii?Q?6WNmFSNnAJeG1GLpBI/PQVEOTueBjfew7jh3eMWS9pdG+GGlAE3iisHVT/tX?=
 =?us-ascii?Q?Vrn7j2uDc8XIxAAkFVdOpyjb1KZuPFtcJmLuwXitUEqEOKECFWNAo97eQMlA?=
 =?us-ascii?Q?8Mh0kkPR1LYxKdRKKF3cybKi+rKV/c7zcIDqyoxoVGX/bRRRC+6FG6fSiemQ?=
 =?us-ascii?Q?rjK9jG5Qyf4DpZ4fIjzKX4PJVE7VxihOx9B2cyhWvmjqnYGpNA45LN6oh9IC?=
 =?us-ascii?Q?PcXTvG0diPQsYZw1RLlrW+CETiIzVgPovJ5jXQP+MSd9dzXoZJ4ugcN1/tzY?=
 =?us-ascii?Q?fEq2bwK+g+/3W2Z0GKEedizxr/srBZ7Q0bxEbnw5TUTNtj7v6l2/T1PCe6DG?=
 =?us-ascii?Q?SpJuNakUd0fJZ8rqKl7Z5dmdQlE4JnTvpXX3QywDwbCmv1fzmnLv8iYITPWc?=
 =?us-ascii?Q?EZcnAgtMNrH9e/xGJlnR5cbY0jbNVBwcbOW/CcYtGX9Vz1w9RTsZQ6qRu04s?=
 =?us-ascii?Q?9B61mTeqkgTI9qvuo85RqyEiY+FOaug3QoBALfF2oDj0N1QXsZDXaohn+AJ6?=
 =?us-ascii?Q?/YUsPSw3ozLnEp3Ky8mELqwueDC4UxHvuwJ7k7Dv4qWeUUMi+VfRfX2lsp21?=
 =?us-ascii?Q?U8yV2wQS7+RRDHTgnTEC+9pe1/rBSm50TO7vpwSOy/MT7IwT6137ide+Yfem?=
 =?us-ascii?Q?NPy9d1y+OM94NN/5yEGX/b0ptQwe7IlnkPhUea5rveIC6xcTBhntZ9Iq3JNP?=
 =?us-ascii?Q?t3NLBIUAwobyLvxPeyNWNxD1sXQkZtNiNN2IgtoWB7zoiirUL38qrXx2EbWt?=
 =?us-ascii?Q?Wb14HImN1I8BL7mjNTf/M5nnJsL2pUypQI7zVXQF50whH6Ppc992Hu2B4zAk?=
 =?us-ascii?Q?rgeMw8kRUPZkiEPHg7REUoUZOayooetXacfIQqY1PaxuKjxD6E9JAluYfqkG?=
 =?us-ascii?Q?OQ1PiTjqf46/MsTNlagUpaGHqutWlxTtY+YNqgY0wihNWhhWD6O2Kr9Mdm1P?=
 =?us-ascii?Q?TBTaUhVyd1vmwpKlAmQoQLNsEC2myFOp3oapCK951ZzYn0pCzLqm6nj2WrkI?=
 =?us-ascii?Q?PiO6FgiBvX57RmcEFvtDazfQVj0KFqUvyA9HwNmbeAtvaW+aryOYx3E16La3?=
 =?us-ascii?Q?ZIFDcxvvB9pe3z69ARMchfb1SrLSICI289BHNzEOs4uPloIq2Et2ylx0osr8?=
 =?us-ascii?Q?WEfSC75XLx7DTzK9Qv8Xv5e5Tvh+WAB03Mt/wMQx1+uAWFkDoTCMLe8Uem9v?=
 =?us-ascii?Q?VRuTd1fB8nK5iW0jr9zjoPs9lRD9gymF4tN71j8sWNwePtZxqlpuk44Bw0wX?=
 =?us-ascii?Q?cr9nWQM3ErkcnSOmxg75aj3PUy8zuskmnwdHFXbJ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8207b41e-fbe3-42c2-8022-08da5f7be2e7
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 18:18:11.9878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2eUvxFAUVxGMGVUvHsNX0h6pmRelLngx5jxWHot0QX28txwvBQtpSXyHfZDPleUb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6601
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 05, 2022 at 11:27:59PM -0700, Nicolin Chen wrote:
> Most of the callers of vfio_pin_pages() want "struct page *" and the
> low-level mm code to pin pages returns a list of "struct page *" too.
> So there's no gain in converting "struct page *" to PFN in between.
> 
> Replace the output parameter "phys_pfn" list with a "pages" list, to
> simplify callers. This also allows us to replace the vfio_iommu_type1
> implementation with a more efficient one.
> 
> For now, also update vfio_iommu_type1 to fit this new parameter too.
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  .../driver-api/vfio-mediated-device.rst       |  2 +-
>  drivers/gpu/drm/i915/gvt/kvmgt.c              | 19 ++++++-------------
>  drivers/s390/cio/vfio_ccw_cp.c                | 19 +++++++++----------
>  drivers/s390/crypto/vfio_ap_ops.c             |  6 +++---
>  drivers/vfio/vfio.c                           |  8 ++++----
>  drivers/vfio/vfio.h                           |  2 +-
>  drivers/vfio/vfio_iommu_type1.c               | 19 +++++++++++--------
>  include/linux/vfio.h                          |  2 +-
>  8 files changed, 36 insertions(+), 41 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason