Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbXE3L36 (ORCPT ); Wed, 30 May 2007 07:29:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751514AbXE3L3v (ORCPT ); Wed, 30 May 2007 07:29:51 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:48895 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751511AbXE3L3u (ORCPT ); Wed, 30 May 2007 07:29:50 -0400 Date: Wed, 30 May 2007 13:29:46 +0200 From: Adrian Bunk To: Stefan Richter Cc: linux-kernel@vger.kernel.org, Josh Boyer , "Robert P. J. Day" , Andrew Morton , Alexander Viro , Randy Dunlap , Alexey Dobriyan Subject: Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t. Message-ID: <20070530112946.GT3899@stusta.de> References: <20070529110041.49bf57f1.akpm@linux-foundation.org> <20070529111902.27055fd0.randy.dunlap@oracle.com> <465C71EA.5040706@oracle.com> <625fc13d0705291144u1aef3b6dx4b00873f3d05b652@mail.gmail.com> <20070529123326.a8a1bd64.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 46 On Wed, May 30, 2007 at 08:41:56AM +0200, Stefan Richter wrote: > From: Stefan Richter > Subject: fs: clarify "dummy" member in struct inodes_stat_t > > Found by Robert P. J. Day: The role of inodes_stat_t.dummy wasn't clear > and one might be tempted to remove it. Give it a better name and add a > comment. > > Signed-off-by: Stefan Richter > --- > Only quickly compile-tested. > > Index: linux/include/linux/fs.h > =================================================================== > --- linux.orig/include/linux/fs.h > +++ linux/include/linux/fs.h > @@ -44,7 +44,7 @@ extern int get_max_files(void); > struct inodes_stat_t { > int nr_inodes; > int nr_unused; > - int dummy[5]; > + int reserved[5]; /* for sysctl and procfs ABI compatibility */ > }; > extern struct inodes_stat_t inodes_stat; Considering that we export this struct to usespace, I don't think renaming a member without a good reason is a good idea (but adding a comment makes sense). > Stefan Richter cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/