Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2784462imw; Wed, 6 Jul 2022 11:41:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sowgD9b2OEheRY6DO9bOCrYgReqwPsEOCG5eAcQONqUgaqjTaV9aQFtQZ++vUjnRBCMuSD X-Received: by 2002:a05:6402:3807:b0:435:20fb:318d with SMTP id es7-20020a056402380700b0043520fb318dmr55558805edb.272.1657132906316; Wed, 06 Jul 2022 11:41:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657132906; cv=none; d=google.com; s=arc-20160816; b=xbXFkyO5F1DLlIvgy2zlGCkL63+u9ucLrXP6CorBw+7q/Thi1AzXyPyjq5Ird9UPGC MN17DOsdTDRPo2PKd8u4XTY7TdcU6mCCxRL3YRQ9NV4FMlaPgHos6GkCDtDRJsCHhLKH rHUrcKKjuqDggc5OzbVcII3GovwZDV1fq3rjvThb54Hl1nS1qKS7FkbEnXu5NPh5GqQW R5y6yYqL7/BZve5Enb9dkEuOb9uF4DDJtDdpfML8/dA6nobCXhRvAULNUFRY1FPi+P3t eHGVANGKOhQ6T1TxZWVHNJKfU5n/CebmQqcqAomtg/muX0BsOCScc4PQVj1HLU9glOBH UU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=lG8GWm0pmr1Neu+cMWEfjz23I2y6CFYI8JxXePQozTs=; b=cQQxu6m0QtE8QnCPe7wDphhPZx9FI9qbJUqka1qTPAMNWLTqgQXwk9gLv+/fxdcN9K calB8ndegm/16lSOFkEKVnzP07pnAY3CZFYveKGQbl9ojrAuk7TXVpUSfqREeZ61RdsV DtR+OHNtrK0uYYvs3NPZFRDnbdXM3kDhoTvWOwJxOcv1ewOGzq/f80k7/07g3wmS+nCl ZnX+vSxOGK3V8xjXlrsKa1s4jmhyJ6q54GIzYe9U1R0qPl48qI3m5zCRuJLwgWoE11Sn hLvjacaCCYVl2sBw8Qdv7M+HNyyC3HdxqP1T5BQu4QGdLTtibIu5RVFK//8UKaBd7yiX d9/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=K6UVv820; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ez11-20020a056402450b00b0043a739b4b93si490276edb.303.2022.07.06.11.41.17; Wed, 06 Jul 2022 11:41:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=K6UVv820; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234655AbiGFSfR (ORCPT + 99 others); Wed, 6 Jul 2022 14:35:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234533AbiGFSe5 (ORCPT ); Wed, 6 Jul 2022 14:34:57 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91C432613B for ; Wed, 6 Jul 2022 11:34:55 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id r6so8931428edd.7 for ; Wed, 06 Jul 2022 11:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lG8GWm0pmr1Neu+cMWEfjz23I2y6CFYI8JxXePQozTs=; b=K6UVv820cw4CP15PiN8DijrpJiKXTK2nYW2xtVIQZTStYnHOZp1tjf20TsCZCG4HGr RZafD5eelpwYaHVcAyMuETGjixhszK4DQ6YKv+Q80G1fKFpt+G0t+ngcqsJyYT7nhalp Tt5yhV6pPeJFmbW/z+5gHkZta0h1PghK059lHia6BlfJdTtC1KiwQBLWh5RB4eluxNoP q912y26LeH0Graq9HfNSoI2iFrXc2npjKA+rDzeeExj9ItUikpyIwH8W2zqTSxqSlqkR uC+MqbwYAJWSLMTs6wWURW91QD/UdbvDNtMO/K16eQfzcaeADys3RXFvbp4d2iZV/J0Q Kf8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lG8GWm0pmr1Neu+cMWEfjz23I2y6CFYI8JxXePQozTs=; b=qjjZPm+REnJMcR45Gkfq+7M9EaHR/T+/HxIKqO9yVyb6qT+s0iP+x99/V7EXDWq+iz 6d3y5BmnOq8Aso0+/sUT3LfDsV9PvSNRedFotWsbixuc1xH7IE5ISdTx3iiivOzhDBxr jTu5noNVIqcrp8vZ3ZapwMyHE8xkosZsXBj3INcI9W5BayKkZab3uXw7HyOK1FsLscn/ Ewm33ntab8DXVL8mZK9f+QVSL2Th2Dh8yNUFaxBq7lJLPay60e7Oh6XcUL8u2qQYOGpY 70xSN9+getGycB0hXZrHjdlmAsreEEZg5wWgdShE3d8k/F//vFYVplgLtA74MQZ42LI+ G9jQ== X-Gm-Message-State: AJIora+bhd0d/torKEXUewlGI99DMwkCNmWKHefAfNy4DUJWhnbsDK70 ujUANJF38B18B7skUeyj60BOtbD1M3qgnV+EtbxNjQ== X-Received: by 2002:a05:6402:201:b0:431:665f:11f1 with SMTP id t1-20020a056402020100b00431665f11f1mr56090922edv.378.1657132493907; Wed, 06 Jul 2022 11:34:53 -0700 (PDT) MIME-Version: 1.0 References: <20220518170124.2849497-1-dlatypov@google.com> <20220518170124.2849497-2-dlatypov@google.com> In-Reply-To: <20220518170124.2849497-2-dlatypov@google.com> From: Brendan Higgins Date: Wed, 6 Jul 2022 14:34:42 -0400 Message-ID: Subject: Re: [PATCH 1/3] Documentation: kunit: fix example run_kunit func to allow spaces in args To: Daniel Latypov Cc: davidgow@google.com, elver@google.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 1:01 PM Daniel Latypov wrote: > > Without the quoting, the example will mess up invocations like > $ run_kunit "Something with spaces" > > Note: this example isn't valid, but if ever a usecase arises where a > flag argument might have spaces in it, it'll break. > > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins