Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 13:35:26 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Andrew Davis <afd@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node
Message-ID: <20220706183526.i6ysrsjgevz3w3ei@masculine>
References: <20220705170340.26719-1-afd@ti.com>
 <20220705170340.26719-6-afd@ti.com>
 <20220706180446.cyzujuasovjvsofk@lively>
 <16319b56-4b14-6f51-23c6-6b78b87119d7@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <16319b56-4b14-6f51-23c6-6b78b87119d7@ti.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 13:10-20220706, Andrew Davis wrote:
> > > +	mcu_crypto: crypto@40900000 {
> > > +		compatible = "ti,j721e-sa2ul";
> > > +		reg = <0x00 0x40900000 0x00 0x1200>;
> > > +		power-domains = <&k3_pds 265 TI_SCI_PD_SHARED>;
> > > +		#address-cells = <2>;
> > > +		#size-cells = <2>;
> > > +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> > > +		dmas = <&mcu_udmap 0xf501>, <&mcu_udmap 0x7502>,
> > > +		       <&mcu_udmap 0x7503>;
> > > +		dma-names = "tx", "rx1", "rx2";
> > > +		dma-coherent;
> > > +
> > > +		rng: rng@40910000 {
> > > +			compatible = "inside-secure,safexcel-eip76";
> > > +			reg = <0x00 0x40910000 0x00 0x7d>;
> > > +			interrupts = <GIC_SPI 945 IRQ_TYPE_LEVEL_HIGH>;
> > 
> > Please document why disabled.
> > 
> 
> Sure thing, will add background info to the commit message.

I'd suggest to document in dts as well. See thread [1]


[1] https://lore.kernel.org/linux-arm-kernel/YiizsYnKB0X9bDY2@atomide.com/

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D