Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2825459imw; Wed, 6 Jul 2022 12:23:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sB1ySTmiuGsCahe5F7qSbTfaLNPuUt1o8xANIWyYxjESOeKHTKafVJWdn/FI6CUyr39Up2 X-Received: by 2002:a17:906:4794:b0:722:f10e:6240 with SMTP id cw20-20020a170906479400b00722f10e6240mr42544443ejc.704.1657135381828; Wed, 06 Jul 2022 12:23:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657135381; cv=none; d=google.com; s=arc-20160816; b=SzH22pi8EoDlSO/EDcUrtVid/EasDyoB46p1zg/Shy1mVqwWaoZYnnV0cDPgbwwTX+ htxAGF57+xVKT3fpWk6ZzwsPGG7J40IEcaa/xG52BFf4BHNmRP4mE/O6UVSjqhmKHf4F DL842UGgN8vfLiKK5+1TI1taiZ1Xbcebwp1WL6/xTef5AplYIgZ4PTqvGk31LzwA1CQt bmBurVeSC387itSeKk0c/hGpTiqGn1ZMxEaIq3Smkj9Y8tSg1qn6q/KZHsvFzrMclfbN XP+PReeZojcjy7Ashl8em4irISDMLC2hJiYPYR6O3F1JkvGF4X0iR0hew8ZFIqde2HnO jxsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Q+PQw8bgTsUWzLK2GyjEyXbBw4GPBQs2jHRw73nMgOg=; b=jUsbPIIntDpQZHrsH3KswWXekBEqYfQQmXY/pnWq7YrsVE0+JBsX/etFdcvUXo4ajl COEKb/XZjQgthI5JBgQ/95ItuIb7WvWv+mLefixqaYzw+euX9y0/bkzdiwKTPowwddJR +KG2Rxg1tUT43YbT0pdIoCTysm3VRmRk3ZGSvAr91VEeyb8BPKmALL9Y2lM1p58OqmJd ohsYVLj7p+jqe8Gc8dySXyCC4N1XblR1X6A6vXJcAypcrITmHNw9KBe9/nscmvLxoSA0 Vgmyy62r1QNa2NRlAZIn82YCr8urgFCflysVSDGs6uZvmdlOE6EaCAEeAvQHEBlobTut /zzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=g18FQLbT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u17-20020a056402065100b0043a737ac218si8205986edx.539.2022.07.06.12.22.35; Wed, 06 Jul 2022 12:23:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=g18FQLbT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233214AbiGFSzK (ORCPT + 99 others); Wed, 6 Jul 2022 14:55:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbiGFSzJ (ORCPT ); Wed, 6 Jul 2022 14:55:09 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F8F2205FC for ; Wed, 6 Jul 2022 11:55:08 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id d2so28699559ejy.1 for ; Wed, 06 Jul 2022 11:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q+PQw8bgTsUWzLK2GyjEyXbBw4GPBQs2jHRw73nMgOg=; b=g18FQLbTBsNJjQwfyzkFrrOYV6TBFs7GbkjeeMRyNJjXBoYZvwu3B4Re8aLNhkahpW hcR+X5y/BYoQAL2WXhtq46FOiY3YG9EVE6CGxGWwYEP528MEY+IgAgrK7Yb5mqbYTLgJ BXbgNkGke93r0Uqpvmx8f6bBqk7gOEVp4fke2+8LQ0KiebBIkNrkf7kgTGJa635Nm5A9 jGKxl0kTgh7vdm0Kq6Xlbt7pCZnn1NO1/bPCqS61niSmnKHxitacAKycaE09axAHEddu PPtg4s1FFaHvHkuqB4jDEKVupA22T1z8FPzNfOWsJ38uo7sE2hTYUSLdoi1PlRJQHkAV W7Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q+PQw8bgTsUWzLK2GyjEyXbBw4GPBQs2jHRw73nMgOg=; b=KNJuzWI7DUpqKFbJuv5lmtIPGZ5EQkjOfMss1Ms4hkNzplQQF30eczpj7oBbDGjU9A njLD6j5fAyMH4Wz6xuW4S64MefBBZzu894oZvyeZQ7ukTX0CDvBBzd+b5zP11Z/PBwPv XoS/q+sGwNw9Cn2zvYq+/9vu3s1rSmo5zpKzo2OwtJeuVsJab8pfcJh1fwBIG+QM8xAO i6Y/yAVPil/1H2xmCh/GPTJju+D2JMDWuGMReJH2aNWeuVsOqPLe9oTlbrXyXjxBrT/M jSs2ujfCH8JKq7aonyeTBVN0lyPvGORfMVXW81AcWiCVbP1tN6f+3iuDqw0DIad9QNwj DVNw== X-Gm-Message-State: AJIora9qcXMEdDQ2hmfABegeIimymjTs0OBKnbuVJuh6cQFyp0yFO7dH FYmp9vNlpR/gKOYITkT1A9FsptD35z5bqWzdxaZeXA== X-Received: by 2002:a17:906:ce2a:b0:723:1587:9021 with SMTP id sd10-20020a170906ce2a00b0072315879021mr41894495ejb.725.1657133707087; Wed, 06 Jul 2022 11:55:07 -0700 (PDT) MIME-Version: 1.0 References: <20220516165446.1246262-1-dlatypov@google.com> In-Reply-To: <20220516165446.1246262-1-dlatypov@google.com> From: Brendan Higgins Date: Wed, 6 Jul 2022 14:54:55 -0400 Message-ID: Subject: Re: [PATCH] kunit: use kmemdup in kunit_filter_tests(), take suite as const To: Daniel Latypov Cc: davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org, kernel test robot Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2022 at 12:54 PM Daniel Latypov wrote: > > kmemdup() is easier than kmalloc() + memcpy(), per lkp bot. > > Also make the input `suite` as const since we're now always making > copies after commit a127b154a8f2 ("kunit: tool: allow filtering test > cases via glob"). > > Reported-by: kernel test robot > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins