Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753896AbXE3Ll0 (ORCPT ); Wed, 30 May 2007 07:41:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753834AbXE3LlQ (ORCPT ); Wed, 30 May 2007 07:41:16 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:52313 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbXE3LlO (ORCPT ); Wed, 30 May 2007 07:41:14 -0400 X-Originating-Ip: 72.143.65.211 Date: Wed, 30 May 2007 07:38:03 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Adrian Bunk cc: Stefan Richter , linux-kernel@vger.kernel.org, Josh Boyer , Andrew Morton , Alexander Viro , Randy Dunlap , Alexey Dobriyan Subject: Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t. In-Reply-To: <20070530112946.GT3899@stusta.de> Message-ID: References: <20070529110041.49bf57f1.akpm@linux-foundation.org> <20070529111902.27055fd0.randy.dunlap@oracle.com> <465C71EA.5040706@oracle.com> <625fc13d0705291144u1aef3b6dx4b00873f3d05b652@mail.gmail.com> <20070529123326.a8a1bd64.randy.dunlap@oracle.com> <20070530112946.GT3899@stusta.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.723, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00, TW_OC 0.08) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2120 Lines: 56 On Wed, 30 May 2007, Adrian Bunk wrote: > On Wed, May 30, 2007 at 08:41:56AM +0200, Stefan Richter wrote: > > From: Stefan Richter > > Subject: fs: clarify "dummy" member in struct inodes_stat_t > > > > Found by Robert P. J. Day: The role of inodes_stat_t.dummy wasn't clear > > and one might be tempted to remove it. Give it a better name and add a > > comment. > > > > Signed-off-by: Stefan Richter > > --- > > Only quickly compile-tested. > > > > Index: linux/include/linux/fs.h > > =================================================================== > > --- linux.orig/include/linux/fs.h > > +++ linux/include/linux/fs.h > > @@ -44,7 +44,7 @@ extern int get_max_files(void); > > struct inodes_stat_t { > > int nr_inodes; > > int nr_unused; > > - int dummy[5]; > > + int reserved[5]; /* for sysctl and procfs ABI compatibility */ > > }; > > extern struct inodes_stat_t inodes_stat; > > Considering that we export this struct to usespace, I don't think > renaming a member without a good reason is a good idea (but adding a > comment makes sense). that makes sense but, given that that array is guaranteed to always contain zeroes and therefore no useful information, it might be amusing to rename it just to see what userspace apps break because they're referring to it by name for what should be no good reason. no, no, just kidding ... that would be cruel. :-) rday p.s. i apologize for this thread having gotten this involved -- i thought i was submitting a fairly innocuous patch. live and learn. -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/