Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2891613imw; Wed, 6 Jul 2022 13:34:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tvhB7cL+BP2HOkzfWiLp+1CjSpJouuWKcs0N0vzR8CcCOxRB8VZ0pUf/EKqEM/iVSLPR8a X-Received: by 2002:a17:903:124e:b0:16b:e975:232f with SMTP id u14-20020a170903124e00b0016be975232fmr14922196plh.165.1657139647686; Wed, 06 Jul 2022 13:34:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657139647; cv=none; d=google.com; s=arc-20160816; b=U0Z4xzTXfgbyZzZqlbcajkq1kyTaHf5X1TlNx7MIgN2yE6bXIhmBXWEGg0XG0Ekbvo KSjHoRczNT1+LFD8/pcZzCqAxurShltkeg/0yC8pAQY9cynkHUQXRuWvZknCl4xAEtDx mbrOjya1ek/YixTUyel+AURkPxsKXgZFE1GomHBrH9V4puuSxXV7UHq5MdFgiZXyffns lI/NRLQm+4b3CqWoAd69E3yc0/KO/kfYGgz++TVBx9QfzFoC2vsD5SL3FvrS9CNvzylt /omQPVRO8xZSgLGMM3OObwKGgFXoIpsrvdM344I7eb+rphKor+PFVl350vpUFiGes1hy kYfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7PiCfuqqFQMm4Z7Pxo/Mkp0vSHbF19ROVfmwHiEwIp8=; b=Y7dRWjniWe8ef+CYZBKgRpfYPHLvInETjToW9MU6dsVLrWDbdNN9s6Q88SI+6VOhh3 r9pPva9eEV6+kW883yXBhpeumyrJQCZ+xRchMVmnWwEmGzwg43rMLOkvb7vzfNYN5R/S YgDoypdQBlcVzVS5ffFgP9B94FtUaejdcvKLU8hrtFKUD5T3G267Rx/fdLmWwtwVCn7+ rCGrsAhwweVzuo0i575Q3m2RjK6u7Os9KaSV2cV6bBgB2y8tLorkI5GpIpsFOnt1iy32 DoSJFyajYK2dwaZBsb/cAMEJZJjQKrlL8TxhuZ+foWN9Jv7L2jkMVy8mNm9rGMpG3b8n wcDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nP8OozGQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h11-20020a63530b000000b0040cc39c0357si4060492pgb.125.2022.07.06.13.33.54; Wed, 06 Jul 2022 13:34:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nP8OozGQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233576AbiGFUGr (ORCPT + 99 others); Wed, 6 Jul 2022 16:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231724AbiGFUGp (ORCPT ); Wed, 6 Jul 2022 16:06:45 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FA6F1EEF5 for ; Wed, 6 Jul 2022 13:06:44 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id z41so20654299ede.1 for ; Wed, 06 Jul 2022 13:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7PiCfuqqFQMm4Z7Pxo/Mkp0vSHbF19ROVfmwHiEwIp8=; b=nP8OozGQwV0hugk+1RizuLBuHeDBhO9I1ymaTbz9SVKu5nYndfbg6U0LGPb6gwFfHJ ToZbABTlGJpV7Fyk+IMRHWjt2JHxQ45DWhkDuCmFXEEaQbf6RfOr5CSueAaKi6gUsh5a Re0l7tzCHIGJ1Dw5CTE7fLIk/lTWUfy8Zu6/EVTWwCBo21YLl5rgE+ag9/k0RxO6uPdv GIBGew/Ulw3raH0Q/cIqfI03t9KZH/OVjZiX7syD/4LdZeoIB5GkytSbgTT0CvCF6QEF nNNtaoJCr1mmiucox/7veCDibYCx6ha7KADLG+MsqE7dMs9RavPoTfk7C/J1RzUZvtv6 dOFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7PiCfuqqFQMm4Z7Pxo/Mkp0vSHbF19ROVfmwHiEwIp8=; b=sw4mz7Ve9G4ZHdOnFMC+nQIoymDTzuDCoz05lbLoH2+ImEICZzH6qZah5aPFwd944L kJ90eUz1YvK3aSacNbO4w0vezWESjdz+p0pUUCw9aIYAhuU/jbrnmkYXDykAYgfJiDzO jdIp97WHTHXcpkO6MBgShVjmnVWJqerlVDpBa1kkNjbOlSefSFR3XjHu9Ok1Aw4+q4UA l9vbZtc2uaQTbpRdhPUCKNj1+jx96fSLnh8RJFplQpCExj+tIbIa33qL7reHXlmA5Eot GXLJaafv4UjoOqneikb6OSrNrBJSf9pAa8tVDWFcEK9FNh2wNmFHKxbEQQ8uYAhq/gAC Rp+g== X-Gm-Message-State: AJIora9bXtj5wfm1KQbEwCFTL0n+y4MFCdVker2H6t5lmL+6wrnioAdB eGRCWNNHPxr2yluKiAyaxcvBmj0WCDsko7aFXC9c7g== X-Received: by 2002:a05:6402:40c3:b0:439:6b72:483e with SMTP id z3-20020a05640240c300b004396b72483emr43951638edb.154.1657138003142; Wed, 06 Jul 2022 13:06:43 -0700 (PDT) MIME-Version: 1.0 References: <20220518170124.2849497-1-dlatypov@google.com> <20220518170124.2849497-3-dlatypov@google.com> In-Reply-To: <20220518170124.2849497-3-dlatypov@google.com> From: Brendan Higgins Date: Wed, 6 Jul 2022 16:06:31 -0400 Message-ID: Subject: Re: [PATCH 2/3] kunit: tool: simplify creating LinuxSourceTreeOperations To: Daniel Latypov Cc: davidgow@google.com, elver@google.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 1:01 PM Daniel Latypov wrote: > > Drop get_source_tree_ops() and just call what used to be > get_source_tree_ops_from_qemu_config() in both cases. > > Also rename the functions to have shorter names and add a "_" prefix to > note they're not meant to be used outside this function. > > Signed-off-by: Daniel Latypov Reviewed-by: Brendan Higgins