Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <39d56706-3fa8-bd3d-e661-6be91b8a2ea4@redhat.com>
Date:   Wed, 6 Jul 2022 22:40:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1 1/1] Input: goodix - switch use of
 acpi_gpio_get_*_resource() APIs
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Bastien Nocera <hadess@hadess.net>
References: <20220705180252.963-1-andriy.shevchenko@linux.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220705180252.963-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 7/5/22 20:02, Andy Shevchenko wrote:
> No need to open code functionality that is provided by the
> acpi_gpio_get_irq_resource() and acpi_gpio_get_io_resource().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/input/touchscreen/goodix.c | 22 ++++++++--------------
>  1 file changed, 8 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index 3ad9870db108..cc52f0d21dbb 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -822,22 +822,16 @@ static int goodix_resource(struct acpi_resource *ares, void *data)
>  	struct device *dev = &ts->client->dev;
>  	struct acpi_resource_gpio *gpio;
>  
> -	switch (ares->type) {
> -	case ACPI_RESOURCE_TYPE_GPIO:
> -		gpio = &ares->data.gpio;
> -		if (gpio->connection_type == ACPI_RESOURCE_GPIO_TYPE_INT) {
> -			if (ts->gpio_int_idx == -1) {
> -				ts->gpio_int_idx = ts->gpio_count;
> -			} else {
> -				dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n");
> -				ts->gpio_int_idx = -2;
> -			}
> +	if (acpi_gpio_get_irq_resource(ares, &gpio)) {
> +		if (ts->gpio_int_idx == -1) {
> +			ts->gpio_int_idx = ts->gpio_count;
> +		} else {
> +			dev_err(dev, "More then one GpioInt resource, ignoring ACPI GPIO resources\n");
> +			ts->gpio_int_idx = -2;
>  		}
>  		ts->gpio_count++;
> -		break;
> -	default:
> -		break;
> -	}
> +	} else if (acpi_gpio_get_io_resource(ares, &gpio))
> +		ts->gpio_count++;
>  
>  	return 0;
>  }