Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@fb.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     Song Liu <song@kernel.org>, Networking <netdev@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "mhiramat@kernel.org" <mhiramat@kernel.org>
Subject: Re: [PATCH v2 bpf-next 5/5] bpf: trampoline: support
 FTRACE_OPS_FL_SHARE_IPMODIFY
Thread-Topic: [PATCH v2 bpf-next 5/5] bpf: trampoline: support
 FTRACE_OPS_FL_SHARE_IPMODIFY
Thread-Index: AQHYdrj21zA3ifq/PEC7Yw0zyJbSw61x8o6AgAAhSYCAAADUgIAAAriA
Date:   Wed, 6 Jul 2022 21:50:34 +0000
Message-ID: <C319735F-9782-4AA4-AF63-A110A43E5597@fb.com>
References: <20220602193706.2607681-1-song@kernel.org>
 <20220602193706.2607681-6-song@kernel.org>
 <20220706153843.37584b5b@gandalf.local.home>
 <DC04E081-8320-4A39-A058-D0E33F202625@fb.com>
 <20220706174049.6c60250f@gandalf.local.home>
In-Reply-To: <20220706174049.6c60250f@gandalf.local.home>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ye2PAEKpC1hJhlzbLgQZ6omisXH+ekfcvWF0ylWBohG1fbUd0mo5XR0QFpUi?=
 =?us-ascii?Q?oNCZmz1cEfaR7BEaTnLIlQSvWxYkdqTzoCSy0/oyWiDhlJuSIOJXtWv4mguJ?=
 =?us-ascii?Q?lbolJqm6HQyTkYYVt5UOjjLdjz2GuhM8HaX9iOz+6mH/z72M4uOhqY3FZO3S?=
 =?us-ascii?Q?b1J8Q8LuCm0YaGKFqKTn0Q/8BADVAt9LoRhwJrPmVUNlX5BsiRLGhJrZmqsd?=
 =?us-ascii?Q?fcM8kOENVJSJbe2b3+afyOtztPiqvwSEiGKV8WRMxTBeBRkpyozza6KP/JuR?=
 =?us-ascii?Q?2Y8NeQbB7axoGNxC/cXjkxor/ieJSy9Y5zHeRcuYhpwt4XNptydVejmNTOdG?=
 =?us-ascii?Q?yGR3DxsCAC9tJeg328gdB1MYmK8kgslJBhpHZX+PDIG0eelJr0QnU6eAPAW7?=
 =?us-ascii?Q?6Mzue3HJkZVC21gdEFVGtNGqaYq7VMLU8Naez7ZDtZMtWlCzIxhum5DQEE+J?=
 =?us-ascii?Q?d78QQlxWHc+2a2BWO2JSRWOAf7yqAlZmSd7FX6t4XqaPKItdZj+/2Oqbx3jP?=
 =?us-ascii?Q?WsJEj1XCU95fk4n1xrnKly7N9uFpwQ9qXgoF27r5ElRlXpdimlJgCcL358EW?=
 =?us-ascii?Q?TJTvYRNswxy+CiJ2BO7ay2yIMCpd8FrjsPUV2CA/ZIG+FZ5UYhx+Q7tDyWad?=
 =?us-ascii?Q?jy2V4hRjhatb3U7f2Kz+iRUxaklq4fjtczlzACwJj213mMXzRK9dCA4iMLAr?=
 =?us-ascii?Q?t3f5SJI1qLNDstGdJ4CcRiRg7ZQ55rfnjLmP9YykwVOokin88rvkWrc5rXAV?=
 =?us-ascii?Q?68nsEjRBjyr2CzI8/U0nEDrKGG8+5/fnmvhJnexFe+Bm6DMA9ZI8u5Zu+A/Y?=
 =?us-ascii?Q?0sumIoxeCRePL921kYmVuZ7Gr+ZVnzC/+EBZD0rNKRW5iRY4G7l0UzkgCjUG?=
 =?us-ascii?Q?DfNpuDCoWT7RE5JSVpBqYJ9AYp1xWzLJEvv7ZYUAHX6ILkz/BRuTC2QeImuY?=
 =?us-ascii?Q?gR+cRyZBilWqrnlG/XMtueDM8zBP2rvP6ka1/Ke67f6KO83eI218kAR11D6M?=
 =?us-ascii?Q?vLwoFbVw2EqAN2AZFI+g5Gs/8C5KiWxZ5znrC4igPQbuF2r94naYx3GbrSYL?=
 =?us-ascii?Q?nnntdu9mpRYjUtPj6Zs9JIEImKaYuP/lnuSoxcGE1BlW+/RjwAXC4snQcjI5?=
 =?us-ascii?Q?v5M/sUmIKPp13qa8oL+kWekKGK7fxBQ/jGo4EagShWgjYbE3QFDPhojth7Kk?=
 =?us-ascii?Q?G8k/PvP6lCwOUdvfPuL7bqgIV+8wKQgOTK6cRKUNFJlend3VGvPer3vPExTL?=
 =?us-ascii?Q?dnEiWixGX4ExUz+Inte1zb4/655PF6OJkaB9jk55hq4EkAfcXcZ+I5JPyRiQ?=
 =?us-ascii?Q?PhFicMIEdqppEgi7izFA4HlcS15iE3rBtAUxzsOTC5RPfWskffRhqvyj42YF?=
 =?us-ascii?Q?zKPYn/GMlIk3XFQJsqAqgnNEde4vA1OIY+rSwV1B0wR0aALCJ47ZnklGSYdG?=
 =?us-ascii?Q?IdNgSGmloEMWbO+JQFk39vZBJGXrVHET6UXyrVV6r3NWlqEpv3r6G29IC71z?=
 =?us-ascii?Q?os74XyvPiwietfjN4hKZXa7dcpJ/OXEaRKKnaIuI1V/C95yyuENp3cCT6HGh?=
 =?us-ascii?Q?RxLbkr7FGV/ch1OBUkk3TByVKMOAarnHxInk17Rp2HdNvAcOKeE/j+e7Ve9A?=
 =?us-ascii?Q?mCfzvS+zNLl60P5eE3fW1eQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1DD1D6FE5341A24CBC15BE93C3995DD4@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83df15a3-2414-4913-1e99-08da5f998df9
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2022 21:50:34.2582
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6TgFhub6/qBJfrGLBNtWMhNqerbMeF/U+i936YiXS+5dWVnVb5ODUszX1/pDgGbVwpS+alilgr/QGXahwDMRsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1245
X-Proofpoint-GUID: 4sC_hQA7t8i-3fI8jqcPMwxODdk8iaQx
X-Proofpoint-ORIG-GUID: 4sC_hQA7t8i-3fI8jqcPMwxODdk8iaQx
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-06_12,2022-06-28_01,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jul 6, 2022, at 2:40 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Wed, 6 Jul 2022 21:37:52 +0000
> Song Liu <songliubraving@fb.com> wrote:
> 
>>> Can you comment here that returning -EAGAIN will not cause this to repeat.
>>> That it will change things where the next try will not return -EGAIN?  
>> 
>> Hmm.. this is not the guarantee here. This conflict is a real race condition 
>> that an IPMODIFY function (i.e. livepatch) is being registered at the same time 
>> when something else, for example bpftrace, is updating the BPF trampoline. 
>> 
>> This EAGAIN will propagate to the user of the IPMODIFY function (i.e. livepatch),
>> and we need to retry there. In the case of livepatch, the retry is initiated 
>> from user space. 
> 
> We need to be careful here then. If there's a userspace application that
> runs at real-time and does a:
> 
> 	do {
> 		errno = 0;
> 		regsiter_bpf();
> 	} while (errno != -EAGAIN);
> 
> it could in theory preempt the owner of the lock and never make any
> progress.

We can probably workaround this with some trick on tr->indirect_call. However, 
I don't think this is a real concern from livepatch side. We have seen many 
other issues that cause live patch to fail and requires retry. This race 
condition in theory shouldn't cause real world issues. 

Thanks,
Song