Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5e0a2a8-f206-e493-df7e-080ddec6a03f@collabora.com>
Date:   Thu, 7 Jul 2022 04:18:02 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v6 2/2] iio: light: Add support for ltrf216a sensor
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>, jic23@kernel.org,
        lars@metafoo.de, robh+dt@kernel.org, Zhigang.Shi@liteon.com,
        krisman@collabora.com
Cc:     linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        alvaro.soliverez@collabora.com, andy.shevchenko@gmail.com,
        digetx@gmail.com, kernel test robot <lkp@intel.com>
References: <20220615135130.227236-1-shreeya.patel@collabora.com>
 <20220615135130.227236-3-shreeya.patel@collabora.com>
 <60b6965b-7a14-8b7c-c9b9-c463fc0ad88c@collabora.com>
From:   Shreeya Patel <shreeya.patel@collabora.com>
In-Reply-To: <60b6965b-7a14-8b7c-c9b9-c463fc0ad88c@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/07/22 02:39, Dmitry Osipenko wrote:
> On 6/15/22 16:51, Shreeya Patel wrote:
>> +static int ltrf216a_probe(struct i2c_client *client)
>> +{
>> +	struct ltrf216a_data *data;
>> +	struct iio_dev *indio_dev;
>> +	int ret;
>> +
>> +	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
>> +	if (!indio_dev)
>> +		return -ENOMEM;
>> +
>> +	data = iio_priv(indio_dev);
>> +	i2c_set_clientdata(client, indio_dev);
>> +	data->client = client;
>> +
>> +	mutex_init(&data->lock);
>> +
>> +	indio_dev->info = &ltrf216a_info;
>> +	indio_dev->name = LTRF216A_DRV_NAME;
>> +	indio_dev->channels = ltrf216a_channels;
>> +	indio_dev->num_channels = ARRAY_SIZE(ltrf216a_channels);
>> +	indio_dev->modes = INDIO_DIRECT_MODE;
>> +
>> +	/* reset sensor, chip fails to respond to this, so ignore any errors */
>> +	ltrf216a_reset(indio_dev);
> Shouldn't SW resetting be done after enabling sensor? Perhaps that's why
> it fails to respond?


We tried to reset the device through i2c-tool to see if that works :-

(root@steamdeck ~)# i2cset -f 0 0x53 0x00 0x10
warning! This program can confuse your i2c bus, cause data loss and worse!
Dangerous! Writing to a serial eeprom on a memory dimm
may render your memory useless and make your system unbootable!
I will write to device file /dev/i2c-0, chip address 0x53,
data address 0x00, data 0x10, mode byte.
Continue? [y/n] y
error: write failed
(1)(b+)(root@steamdeck ~)#

But the problem here is that the light sensor resets itself 
instantaneously while the i2c transaction is still in progress.
So it never replies with the proper stop bit that is expected at the end 
of a transaction. Hence, we decided to ignore
the error.


Thanks,
Shreeya Patel
>