Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3072171imw; Wed, 6 Jul 2022 17:10:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1upLa3ZZc08aiBFUZj5ougfTlsUWNddrYScXvJRVESChUlSRdSjYWxrwZhCwK1v2GsayxTe X-Received: by 2002:a17:906:49d4:b0:6d6:e5ec:9a23 with SMTP id w20-20020a17090649d400b006d6e5ec9a23mr44109905ejv.79.1657152657933; Wed, 06 Jul 2022 17:10:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657152657; cv=none; d=google.com; s=arc-20160816; b=fMWHPBaCIGfHzY1mNoL/jaCMmSQUQeThhmoyAbXcudxStUQE8vnKI1ldjb8xidjHGY b+2PEgnzpo4+EAAVTGRUJOb8IViAMMzZMDuBHpWz8G1x2C5M1HbKbGoMO7Jj0pWH52p1 0PwTdbIy/Qkc7C0YTs1W3zk2TnL/nyyP6VEtNcUMZgYpciCapS083AmCofOZcA9IR9hj qCfMRw5ccq98J8yVEhRnSgLs7n8a7wrvMUKSbqQQr733YrCFuyzsqfw2hMQ+iUzqZGN/ VCyNsxiRSKLCXhWB137qUwnh3Cv/SkazqBi83xOORXxxWyBfnFTl91bqzq8zw2lwNMWI 8G4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=XjN6GpQY4nWOSdliTg5TstOsjxKtEZmHyJPBA3SGai4=; b=B5wq8pBMteUK29sewvsKhY2w8fqPtcel/SqWcuCdZWtB6kvxY4BhVSixm3gb4b4A0P Rx6JzbcGCHPPillo9jrjeNj1zXbP7zFD2XSRGIGw15MUAgzr63gSeCWIIOHYe751R9Oi 7i9d+2vDa4j1slGG80oiAJP0ugfhLhaqS8rQIbvphWFBcv5GZw/82ZWap+o5cPRmig7K hvZKMn4kuud5LBW2cUlSfN6GUvIsfa+9KutJeLHkqY1Qd3iV3PELyc19d1v80KdohsVJ eG/GtH2yECT98Yvd1Fscg3Pxf8KY58UUDLRLhyIwDXk9ZiovsJk892TFX7FJGEGcSq+g MMqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=NWmAlvx+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp37-20020a1709071b2500b0072a4249e9b5si15374071ejc.17.2022.07.06.17.10.33; Wed, 06 Jul 2022 17:10:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=NWmAlvx+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233917AbiGFXzu (ORCPT + 99 others); Wed, 6 Jul 2022 19:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234051AbiGFXzs (ORCPT ); Wed, 6 Jul 2022 19:55:48 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 750B42D1DB for ; Wed, 6 Jul 2022 16:55:47 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id r82so21707129oig.2 for ; Wed, 06 Jul 2022 16:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XjN6GpQY4nWOSdliTg5TstOsjxKtEZmHyJPBA3SGai4=; b=NWmAlvx+hIMXHWO+G9Z63Eb98yhqT+8AjKLRP1akM1C/W4XpF/H/VknMGxd8Nfsdgk XD96M4+0V53EXEOW5Q05c/i0wA05OAnLl+3xhSK8IbfCfn06UCDJcqEHJee6r1N3FPYE 2+1DT5CQWeMW0/3YDxqmsKfR+2PAZhw7vX2KbYDTj5JKrbDrJ3SmqltaHgEuZBBFV5Pj tVkzQe9TPw+SkvcMqMssC3Y5DbldxfUrHYQPtj+NB1QQnlE4tkH8qPz881PauWsSExbZ yL4cyXjzMqW9bYA56uFsgLNTWoArD/jIQdvBelaYoLMkmCy7v3AvK5ueEdYsm4tSXnDb BYQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XjN6GpQY4nWOSdliTg5TstOsjxKtEZmHyJPBA3SGai4=; b=I1LLm+xFpbgj6dlbVRSyat/zDD/AcZWMwEvP2MYKG5weVoRT9PAQIXVGU9Fb9bgDoi 4Bb84GUaD72qNn88ZqiUIZJJMKaLSDlHBK9269w/p0dMRyYD4sCs5d3RdULRN8TSKNt/ gA4Ahl3FyrJ5hFEayMdnFrVB8LwORmTEFxn+wKFn/N8VsReE8wowhot6XhiJB4QXyvPF 7MKyndjHYwJIw55lHTrKwUxPNtmcP1AMF5h8/frXpULyGV+mefZC6JlJ+V5FLFB472t5 /KhrZqFhjpWNcDY2UzI9wVumzVi77ugFOnv4Vf0kS+W6vqsLcZ8IlaS4d3kUTP+alQwb DGNg== X-Gm-Message-State: AJIora9TRmVau8wvI/mAUiTaa/BXWoduPa4+U5MtYkJ3KJJgTPP2TicB z9G7ctUf5ZGSzGTm3xAL+i7RSslC8dEfkKXJr6jTOA== X-Received: by 2002:aca:5e05:0:b0:337:bd43:860b with SMTP id s5-20020aca5e05000000b00337bd43860bmr719740oib.181.1657151746538; Wed, 06 Jul 2022 16:55:46 -0700 (PDT) MIME-Version: 1.0 References: <20220614204730.3359543-1-seanjc@google.com> <20220614204730.3359543-7-seanjc@google.com> In-Reply-To: <20220614204730.3359543-7-seanjc@google.com> From: Jim Mattson Date: Wed, 6 Jul 2022 16:55:35 -0700 Message-ID: Subject: Re: [PATCH v2 06/21] KVM: x86: Treat #DBs from the emulator as fault-like (code and DR7.GD=1) To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Upton , Peter Shier Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2022 at 1:47 PM Sean Christopherson wrote: > > Add a dedicated "exception type" for #DBs, as #DBs can be fault-like or > trap-like depending the sub-type of #DB, and effectively defer the > decision of what to do with the #DB to the caller. > > For the emulator's two calls to exception_type(), treat the #DB as > fault-like, as the emulator handles only code breakpoint and general > detect #DBs, both of which are fault-like. Does this mean that data and I/O breakpoint traps are just dropped? Are there KVM errata for those misbehaviors? What about single-stepping? Is that handled outwith the emulator?