Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220705121756.41660-1-kai.heng.feng@canonical.com>
 <CAHp75VdnvxhR7yB2sroH4y8VgU3ORnCC3wH4CEKYCX1XSPvMxg@mail.gmail.com>
 <CAAd53p4ZNna2G7hD4vDfDF-fAtLNJinr+tr9LddMq06yFT26YA@mail.gmail.com> <CAHp75VegnLShEPHg=aRG=M3kf36M3tHPL7Jwz-i=A3Z48-2pYA@mail.gmail.com>
In-Reply-To: <CAHp75VegnLShEPHg=aRG=M3kf36M3tHPL7Jwz-i=A3Z48-2pYA@mail.gmail.com>
From:   Kai-Heng Feng <kai.heng.feng@canonical.com>
Date:   Thu, 7 Jul 2022 07:54:15 +0800
Message-ID: <CAAd53p5fb8-2SbOGwgkvPMnEtYc7wh4hksokLJNz6uesArqchw@mail.gmail.com>
Subject: Re: [PATCH] iio: light: cm32181: Add PM support
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Kevin Tsai <ktsai@capellamicro.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 6, 2022 at 8:36 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Jul 6, 2022 at 4:02 AM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
> > On Wed, Jul 6, 2022 at 3:12 AM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Jul 5, 2022 at 2:31 PM Kai-Heng Feng
> > > <kai.heng.feng@canonical.com> wrote:
>
> ...
>
> > > > +static int cm32181_resume(struct device *dev)
> > > > +{
> > > > +       struct i2c_client *client = to_i2c_client(dev);
> > > > +       struct cm32181_chip *cm32181 = iio_priv(i2c_get_clientdata(client));
> > >
> > > Simply device_get_drvdata(dev) ?
> >
> > iio_priv() is still needed to get the struct priv.
>
> I'm not objecting to that. My point is that you don't need to
> dereference dev --> client --> dev.
>
> And yes, I see that client is still used, but it's again not about my point.

You are right, let me send v2.

Kai-Heng

>
> > > > +       return i2c_smbus_write_word_data(client, CM32181_REG_ADDR_CMD,
> > > > +                                        cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
> > > > +}
>
> --
> With Best Regards,
> Andy Shevchenko