Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754607AbXE3NQX (ORCPT ); Wed, 30 May 2007 09:16:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752676AbXE3NQM (ORCPT ); Wed, 30 May 2007 09:16:12 -0400 Received: from mail.suse.de ([195.135.220.2]:47513 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753276AbXE3NQG (ORCPT ); Wed, 30 May 2007 09:16:06 -0400 Date: Wed, 30 May 2007 15:16:00 +0200 Message-ID: From: Takashi Iwai To: Jiri Slaby Cc: Bill Nottingham , linux-kernel@vger.kernel.org Subject: Re: [PATCH] alsa: fix comparison of unsigned < 0 In-Reply-To: <465D6460.6030003@gmail.com> References: <20070530073554.GA28809@nostromo.devel.redhat.com> <465D6460.6030003@gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 52 At Wed, 30 May 2007 13:47:44 +0200, Jiri Slaby wrote: > > Takashi Iwai napsal(a): > > Hi, > > > > thanks for checking this. > > They seem actually hitting some real bugs. > > Bug fixes are ok, but keep on your mind this (I haven't checked if this is > the case): > http://lkml.org/lkml/2006/11/28/206 Yep, I already committed real bugfixes but didn't apply the rest. thanks, Takashi > > > At Wed, 30 May 2007 03:35:54 -0400, > > Bill Nottingham wrote: > >> diff -ru linux-2.6.21-old/sound/pci/ac97/ac97_patch.c linux-2.6.21/sound/pci/ac97/ac97_patch.c > >> --- linux-2.6.21-old/sound/pci/ac97/ac97_patch.c 2007-05-30 02:53:05.000000000 -0400 > >> +++ linux-2.6.21/sound/pci/ac97/ac97_patch.c 2007-05-30 02:32:41.000000000 -0400 > >> @@ -2086,8 +2086,7 @@ > >> struct snd_ac97 *ac97 = snd_kcontrol_chip(kcontrol); > >> unsigned short val; > >> > >> - if (ucontrol->value.enumerated.item[0] > 3 > >> - || ucontrol->value.enumerated.item[0] < 0) > >> + if (ucontrol->value.enumerated.item[0] > 3) > >> return -EINVAL; > >> val = ctrl2reg[ucontrol->value.enumerated.item[0]] > >> << AC97_AD198X_VREF_SHIFT; > > > > This one is fine. > [...] > > regards, > -- > http://www.fi.muni.cz/~xslaby/ Jiri Slaby > faculty of informatics, masaryk university, brno, cz > e-mail: jirislaby gmail com, gpg pubkey fingerprint: > B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/