Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 18:24:46 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Ratheesh Kannoth <rkannoth@marvell.com>
Cc:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sgoutham@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <pabeni@redhat.com>,
        <kbuild-all@lists.01.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] octeontx2-af: Fix compiler warnings.
Message-ID: <20220706182446.2fb0e78d@kernel.org>
In-Reply-To: <20220706130241.2452196-1-rkannoth@marvell.com>
References: <20220706130241.2452196-1-rkannoth@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 6 Jul 2022 18:32:41 +0530 Ratheesh Kannoth wrote:
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:388:5: warning: =
no previous prototype for 'rvu_exact_calculate_hash' [-Wmissing-prototypes]
> 388 | u32 rvu_exact_calculate_hash(struct rvu *rvu, u16 chan, u16 ctype, =
u8 *mac,
> |     ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c: In function 'rv=
u_npc_exact_get_drop_rule_info':
> >> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1080:14: warn=
ing: variable 'rc' set but not used [-Wunused-but-set-variable] =20
> 1080 |         bool rc;
> |              ^~
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c: At top level:
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1248:5: warning:=
 no previous prototype for 'rvu_npc_exact_add_table_entry' [-Wmissing-proto=
types]
> 1248 | int rvu_npc_exact_add_table_entry(struct rvu *rvu, u8 cgx_id, u8 l=
mac_id, u8 *mac,
> |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c: In function 'rv=
u_npc_exact_add_table_entry':
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1254:33: warning=
: variable 'table' set but not used [-Wunused-but-set-variable]
> 1254 |         struct npc_exact_table *table;
> |                                 ^~~~~
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c: At top level:
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1320:5: warning:=
 no previous prototype for 'rvu_npc_exact_update_table_entry' [-Wmissing-pr=
ototypes]
> 1320 | int rvu_npc_exact_update_table_entry(struct rvu *rvu, u8 cgx_id, u=
8 lmac_id,
> |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

There are also these warnings not fixed by the follow up:

In file included from ../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_=
fs.c:14:
../drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:15120:28: error:=
 =E2=80=98npc_mkex_default=E2=80=99 defined but not used [-Werror=3Dunused-=
variable]
15120 | static struct npc_mcam_kex npc_mkex_default =3D {
      |                            ^~~~~~~~~~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:15000:30: error:=
 =E2=80=98npc_lt_defaults=E2=80=99 defined but not used [-Werror=3Dunused-v=
ariable]
15000 | static struct npc_lt_def_cfg npc_lt_defaults =3D {
      |                              ^~~~~~~~~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:14901:31: error:=
 =E2=80=98npc_kpu_profiles=E2=80=99 defined but not used [-Werror=3Dunused-=
variable]
14901 | static struct npc_kpu_profile npc_kpu_profiles[] =3D {
      |                               ^~~~~~~~~~~~~~~~
../drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h:483:38: error: =
=E2=80=98ikpu_action_entries=E2=80=99 defined but not used [-Werror=3Dunuse=
d-variable]
  483 | static struct npc_kpu_profile_action ikpu_action_entries[] =3D {
      |                                      ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Annoyingly kernel defaults to -Werror now so they break the build for
me, and I'm not immediately sure how to fix those for you. So I think
I'll revert the v2 and you can repost v3 as if v2 wasn't applied. SG?