Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 5.15 v3] mm/filemap: fix UAF in find_lock_entries
To:     Matthew Wilcox <willy@infradead.org>
References: <20220706074527.1406924-1-liushixin2@huawei.com>
 <YsWXeLo9gXTEv3pw@casper.infradead.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jan Kara <jack@suse.cz>,
        William Kucharski <william.kucharski@oracle.com>,
        Christoph Hellwig <hch@lst.de>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>
From:   Liu Shixin <liushixin2@huawei.com>
Message-ID: <536cb9e4-983d-80db-6590-44ae7fc02415@huawei.com>
Date:   Thu, 7 Jul 2022 09:25:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <YsWXeLo9gXTEv3pw@casper.infradead.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/7/6 22:08, Matthew Wilcox wrote:
> On Wed, Jul 06, 2022 at 03:45:27PM +0800, Liu Shixin wrote:
>>  	rcu_read_lock();
>>  	while ((page = find_get_entry(&xas, end, XA_PRESENT))) {
>> +		unsigned long next_idx = xas.xa_index;
> It's confusing to have next_idx not be the actual next index.
> That was why I made it 'xas.xa_index + 1'.  I know it's somewhat
> used as an indicator that we don't need to call xas_set(), and so
> it doesn't really matter, but let's say what we mean.
I'll modify it and resend again, thanks.
>
>
> .
>