Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        "Zhu, Tony" <tony.zhu@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v10 08/12] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Thread-Topic: [PATCH v10 08/12] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Thread-Index: AQHYkC3RawHjE5fI4kOPQdVz+DQ3s61yKD+A
Date:   Thu, 7 Jul 2022 01:56:59 +0000
Message-ID: <BN9PR11MB527661C920696BCA56C064F78C839@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-9-baolu.lu@linux.intel.com>
In-Reply-To: <20220705050710.2887204-9-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yK38aRMERcZLBJJpLYdfc9vycC6z9C9acztcvTySOSB5shZ14KKIe/iPoKQI?=
 =?us-ascii?Q?B6OdPkmNNgffmO7G123L2SjR+tGtaee0BC6n+NtKriF4V6ODf7hA53CcFK7V?=
 =?us-ascii?Q?v7q+4XGik4GvoaIayIfE1s9QszfrkXcrixs7NOASpXYVaj/iPbAWS7blXvmV?=
 =?us-ascii?Q?1vHxTHQ9HCegMy+MRjl207o+JJUdNanfFCAd7plxVFOw17LfwoYVgq4KT8xk?=
 =?us-ascii?Q?gn+tOw4yaQF6ZeBeixAuJROe3fjiwmDtPD4z0QHe3WmWF2a9GSaK8ia5Gbu6?=
 =?us-ascii?Q?B8EOACzx+VYPqZvIdH/R6gNzplW37CitiOgHJFLMbW/W37iL5guQpKnq7I2I?=
 =?us-ascii?Q?J5nkI4zkwPl1CRN704VrwmKPjpA8RDuVArj4fJ+ZqFlTw6vUB9JJlztYyRtr?=
 =?us-ascii?Q?Cd4M4x/qyltyq/atGtBHjpt+73azHmaHzNEnp7TAU9LwoR0Jhtpte2Wk2RDn?=
 =?us-ascii?Q?IsyJn47hMdqjHsQHZBELLOiSUfB0uBASAe8eu7Zk605zS+GxnfuwUAIPFm37?=
 =?us-ascii?Q?UJViRXcP53uR7i9GOg4m41SnUIOFhD8QWG0AEepXtSrB+c6uE0Z/Ut5Vypby?=
 =?us-ascii?Q?D/CnmHRAyJIZu51KcvmcGV4k/7Do2ISUFt6BDw/oEzzCrkhhmJdm+y6kXaiU?=
 =?us-ascii?Q?bxiqo+uKwjN1fLnfvCV71hg3H93SX+ibaCDN4RflMk7roV82ilOniPUbvYoa?=
 =?us-ascii?Q?OeVi3AtbHBNquwVzR9znWg230ay2qvz91b0L3WFY07Vun00JuJq54CdDcG3f?=
 =?us-ascii?Q?IFUe/aBP6T4dgkVon9wuzQOndMzpgOhRM6HvRa+DGK2NO545hAL7sFth0gJ1?=
 =?us-ascii?Q?bXelYCDa/abmWf9jaaFhz5pohtp8bEnCpdn4+3HqsO6omRcJDZfBhee4BMKa?=
 =?us-ascii?Q?97gQr3ENvtTqABKbHk7ca7c5wWf1rXt1OitbL9Nwjb8/vJMaU6f1Sc1jxEWe?=
 =?us-ascii?Q?ORAF6QsVJYVITjjXYV5CQreguA3Fanis9mRD3UQiSs3qqJPk6Nd7Oic2jaIn?=
 =?us-ascii?Q?AqPtfl2QPVqLcQJ+T30Ni9vxR3GWDmdLI3GTueqDTCQFrsPmnMdZnnjVg61q?=
 =?us-ascii?Q?6jB32ZPl6bQ/8c7hnP3PseLHDmEmkqFeXki/or92eHWpY7JizUt95OW2EGLR?=
 =?us-ascii?Q?AXyBabbfpcOnNZkoHR3mbIl2ijvpX1qSPleiqGZlnpiiG7nFHQWzc3pwJUn0?=
 =?us-ascii?Q?rJ3tQw7/a9xBmqoA/FOCjHX4avV1hbZ16H0fwo2reiY6DjeXAz4H5p+aRs1r?=
 =?us-ascii?Q?AglaGJxM3OTvJQeG5o6Rr25OM7HqS5I8P4V+HCzi731vjKyOqW3sCiiqj1B3?=
 =?us-ascii?Q?ZxAGoxggXeMeeEOCBiplPMUuIVSo+IMeDjVP4FNXLQ6+7pvRN8ikL3N/mbVO?=
 =?us-ascii?Q?WG0pq4Q5+3C458hHhOQQN2LyHvClPHm/QKsGEUI/7l8OyXdfWWlSjYRp1Wh3?=
 =?us-ascii?Q?/RRwysDiMDdQthvz+RYje6RCJFDFkdPAIF1nbcM5LZQknCNq16QUjW72Fhe+?=
 =?us-ascii?Q?irf1wVrftsWmmcPZjQ52V87VmTTVLBO9EzZw01AxwPir7AMGTbz3v/uzikYp?=
 =?us-ascii?Q?6N+SSmxGYbzWDU5SFfbhiG5By2xpHwRip8Ah/lsI?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06dc1d9d-a3ac-4954-7874-08da5fbbfac7
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 01:56:59.7089
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GnUcvRkafYbihE+MgjSoYvaLzf71Kw6e0AOdRpxBO5V1Z2Whf0F7hMLNTlBS8oWDVEadzBgrbY+BgAvh0P8/vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, July 5, 2022 1:07 PM
>=20
> +struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct
> mm_struct *mm)
> +{
> +	struct iommu_domain *domain;
> +	ioasid_t max_pasids;
> +	int ret =3D -EINVAL;

-EINVAL is not used.

Reviewed-by: Kevin Tian <kevin.tian@intel.com>