Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3166855imw; Wed, 6 Jul 2022 19:14:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vUlUvjA6TaGEMWknW3Uxho1fFGMWCCq6Vp6izhkwCJh+VP8cwgcDPhk7keHiRLYlvJ6C7c X-Received: by 2002:a17:907:6d1d:b0:726:363e:cca3 with SMTP id sa29-20020a1709076d1d00b00726363ecca3mr42316244ejc.713.1657160083502; Wed, 06 Jul 2022 19:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657160083; cv=none; d=google.com; s=arc-20160816; b=pl8VtnEnTLktdDwawlhQ4DhmevorMzPdPStUPZQSUO06Qu3HMerD+xjsG1gWqb/Hlp HI0ZIhYutq1jZnauQcffvlAYbuGDqPGB8CP9kArYVw/ae239x+9buFfzLugH/Y+ug1GQ jPJjKR0ekKMLRaCRgv47zW6wsAyBT6b6FzhM8K9DZ120C+ZfBC+yi/yB7Yfl+CaFbKLw rSwVPFGnJJhA3iIwJsLYQ3mMT7bu9wIqHCXriCb5BK+MosQ4FhrtrIqH4F+9BP46r3lb 7cW2tIFsqamteI8LCBkMWgmXTDUrsDnGEpZN547xJOEQ5GlPqcPzY5Y9xO/KVG9d6syv 4/bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=agNhk//C2GNf3J6n7h08MjOw3ESuyghHRQ5sH3RPCXs=; b=mqRlYZ9LuppBGAQ1kZDy2m757yC2wjFYcVYz1pJM/6yT69tjeKUh0nrfx8RnrNQzBO DTGOWNABL9MrbG7LOGk1Fp1wcm3wr7i5YtjgA79bzQolpWQ1h832uL4VZKbOn9d5zx16 FBl+yVG5gpQYSjvxa8Kf0SxtAKska2LW7MyqsthG1vcLGX1G8Oe8Y/N1vcI8NDkXlJYN i0h5cWwmOyHoF0w+PiV6x15csgVbIaFotL/zsueOhHmaQ3xwW0uuUxpdP7fwXze9Pkf1 GWOe4fL2lEeyc7nP7KE45s9cDKQmo+aGapKhgY4qmYNDwG2/PfxhicW2WhZbgvORJlLu 77dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa20-20020a1709076d1400b007267675e18bsi5429897ejc.676.2022.07.06.19.14.17; Wed, 06 Jul 2022 19:14:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234051AbiGGBrJ (ORCPT + 99 others); Wed, 6 Jul 2022 21:47:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbiGGBrI (ORCPT ); Wed, 6 Jul 2022 21:47:08 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DCAA2ED6F for ; Wed, 6 Jul 2022 18:47:06 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VIaWWVA_1657158423; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VIaWWVA_1657158423) by smtp.aliyun-inc.com; Thu, 07 Jul 2022 09:47:04 +0800 From: Yang Li To: tomba@kernel.org Cc: daniel@ffwll.ch, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH -next] drm: Remove unnecessary print function dev_err() Date: Thu, 7 Jul 2022 09:47:01 +0800 Message-Id: <20220707014701.74829-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:817:2-9: line 817 is redundant because platform_get_irq() already prints an error Signed-off-by: Yang Li --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index ac869acf80ea..61a27dd7392e 100644 --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c @@ -813,10 +813,8 @@ static int omap_dmm_probe(struct platform_device *dev) } omap_dmm->irq = platform_get_irq(dev, 0); - if (omap_dmm->irq < 0) { - dev_err(&dev->dev, "failed to get IRQ resource\n"); + if (omap_dmm->irq < 0) goto fail; - } omap_dmm->dev = &dev->dev; -- 2.20.1.7.g153144c