Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3170224imw; Wed, 6 Jul 2022 19:19:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vL6WYYwU4nodGe/nQ1Dj539NU+qJQiWL1GklN/nXw78cYsxsTAVzuZ/VI8FR6lPa8tnRuB X-Received: by 2002:a05:6402:1d53:b0:43a:9ba7:315b with SMTP id dz19-20020a0564021d5300b0043a9ba7315bmr660385edb.350.1657160368958; Wed, 06 Jul 2022 19:19:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657160368; cv=none; d=google.com; s=arc-20160816; b=Rv+t6fL9ca2VtjCgAG1+M9R2lGF+dbLZGSUeEqHKE+0zEytzKh+AiX5862/zHaQ+je Ie9Bh33DUr4TP9PJi/eb5pBrRwzr7WN0W4BTFvr9x+T+8yyHdHZ09vKh5gs7HDgmm4sv 0m8F3BXZmoaZwwXGiNSSYa/8s2/A4LTp2GyAWz/fCB8SGnYEVsH4A7OP3NW/BRgDDiKn fpNflbgvxNwLeTErgY+mC+oP/qLNNT/RgvNaiHsgIgwHRosYq33CdFtTlvR8iGsOIz3A aME+WDIa8JfuI/xjdf+K4yyCnKpQIDrZs7e6RG6vH8oiIKuN+SvY35cNvRZ9RqwqGr76 C4AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=t58ggzgj1NV6ShDEBFTm/kHLy4aFebyFbLWMk8zpebA=; b=WD0Ith8o+S6vHNNF75tQ6v4dbiinelKGORuAx9H7cZTSgIPOJDwODzxVxXvGyezbzv 6RA7EncrNx5sZA33q6210jTNP1lUexe9F8XQS4uq3V6V1PtURjkgawx9UjhElJSZ7Qtk 6huWQkQlfOQ0YDJ60dIjyD2/b53LpEFsRBjMnvY5Y8Rz0nwW3NQBkV+LrRSZOuWyYmiS CAVfzSisugQZAaRBZk2BPWKIPSeRjc/MsngwnqgRfKr/Qpjafjc+/KXujHnNAREkpz2c /tMOv2kfQnFszMPU34HFelbu/fK+VhqnyrjiUpa39deMib8MJegusxqz+yGvd50RQBsZ DNbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dfkB/ry2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb42-20020a1709076daa00b007263fe6c42fsi32909337ejc.675.2022.07.06.19.19.01; Wed, 06 Jul 2022 19:19:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dfkB/ry2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234785AbiGGCCm (ORCPT + 99 others); Wed, 6 Jul 2022 22:02:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234690AbiGGCCk (ORCPT ); Wed, 6 Jul 2022 22:02:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C3F42F03D; Wed, 6 Jul 2022 19:02:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AC0376208C; Thu, 7 Jul 2022 02:02:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A96DAC3411C; Thu, 7 Jul 2022 02:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657159359; bh=abt2fnMs2RLeFsNRDbZp4ICtDX00jnIhZbJrTMIbwro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dfkB/ry2ouo+vFAA83fScF1vliSCTQLU9aRmNkJYJZmA01OKIGpBtccjixQeqtZZm q8eHDkQStzqYwREHb4NwveofynUWl3jLZubWCENVsJ9B8OQ3uLe1T1wyIph/Z/L+vF te/8KVbE6Jv4X6Mmoyg+RgRKYAFwdhM6AolkSRSm6WkR1quhpp2dcbqxJaDkKKwSiP n92v24MccNdaPjC9n4XGpFigZlWGMzvr4ljOI7UwChVJm6X7a+NOL2jo1nNPuoP6i+ yITHWhzmH7xKFRnHrtzIKBt1VwVBkpXsq4rNJdBSgWL/H4/jH+wpYmYHtl7YOWfvd3 qId/SQrGUtUkg== Date: Wed, 6 Jul 2022 19:02:37 -0700 From: Jakub Kicinski To: Duoming Zhou Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com Subject: Re: [PATCH net v2] net: rose: fix UAF bug caused by rose_t0timer_expiry Message-ID: <20220706190237.477f24ee@kernel.org> In-Reply-To: <20220705125610.77971-1-duoming@zju.edu.cn> References: <20220705125610.77971-1-duoming@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jul 2022 20:56:10 +0800 Duoming Zhou wrote: > + del_timer_sync(&rose_neigh->t0timer); /** * del_timer_sync - deactivate a timer and wait for the handler to finish. [...] * Synchronization rules: Callers must prevent restarting of the timer, * otherwise this function is meaningless. how is the restarting prevented? If I'm looking right rose_t0timer_expiry() rearms the timer.