Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3279299imw; Wed, 6 Jul 2022 21:46:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vzlYrxMzvYS2KgCuFO5kgPxrKS20EVAi9AWMitqrr52iNOn3OfIP1hh5iKWe3P97+AtXkr X-Received: by 2002:a05:6a00:cd1:b0:525:4c0e:d0a3 with SMTP id b17-20020a056a000cd100b005254c0ed0a3mr49885096pfv.67.1657169189485; Wed, 06 Jul 2022 21:46:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657169189; cv=none; d=google.com; s=arc-20160816; b=oeEYNCcDCA6whXKlt/Gp6aRQWzkh/b0umdcbaQwbg5FA2j0e+IOUMuy8FUnqiEfaYi 9SMi0xeyhqK4ywfhWlrFkGIOHMJKnDI2bBLolQXa3Dp+uKjehY7YMGJJOL13hBcnkw3H f2k5XWHxrVMXl/sOBXn+U8D+f6psqlbghe5a7ZSrZdAsGHYMSCPTX254TYteRQLnaxUP EZ+/vG/yijcxgvdo1XweuPHgv7u1bUlxfdYOY8fFB9emYSnReF18+e8q9PisGsVxXaNG j/GSXMLHfq8+T9DjkNzxTyOpkar1wJkcdJ/yyHSu2W95UQodItids62nMDOrTldMhgJ5 4JTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AbIgiz4HdWTHJrDcwgiMjNLozJ+fa1Um61VNXrTWXuw=; b=CXH12ZCCQA79UZbbfqcs/kPcqjlLfxj21gBMoJPWQGB21HmD4nXYcGSFk++KR69uHl FZ7YZH3iAiyZBi89bXNnm4wVwoyrM55+0ujqpLJZGBiFkxS5d8jR2SBYfC7WkAKOUepB rSNdLo5SVheXyC4IXT8pkhDS4LonPnmjrR07fXBfJiuNXv7PEVYCOCIBmRBZPgGdC5vq KMbnqZbml5wogbKmsp4Z1q7QxjeNYCZ0felsnC+uGg/1DKGj8Q+gLjFWpChYejpbp5ex jRc5CHNb19AMxFv3cpzgFl/zSNlCHK/8HHt/wGrAICRD3dHkntoSbKnZ4usDeZW8iwHx lDPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JLXuMSRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2-20020a655942000000b0040ca239942csi55938502pgu.432.2022.07.06.21.46.07; Wed, 06 Jul 2022 21:46:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JLXuMSRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234530AbiGGEmw (ORCPT + 99 others); Thu, 7 Jul 2022 00:42:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiGGEmr (ORCPT ); Thu, 7 Jul 2022 00:42:47 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25A322F037; Wed, 6 Jul 2022 21:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AbIgiz4HdWTHJrDcwgiMjNLozJ+fa1Um61VNXrTWXuw=; b=JLXuMSRapJzauQSgyJpNyTpYAj FHX1E3ZNecpiiGROvvfEp8SwwbAs3xM7y7Gtww8T317u7YSPOLnT7Om54pv+VxZCzOcBD9Wf617/U yOM3KkO/FIEZ72d73h5KUdTJADuM8/wuU5dGtUEIr5/LNK4TbRZbdy1IB+ApOtViLobIewkOar6fx R3cwAKogG84EkVmlNXr2awmyI///KOGitJJfgjGOjUVyoRiDbY1Blylwee9XOgx/Ql13EuncLaMeN BEww+BEZ9E4q+i0/JKMTPE9dGNbmok0FTBvCd/LTdoUoZvgdVi9X+x9JeWzH7MYTDSb8xYIOZYUSB ZG3eBhbw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9JLc-00DW1r-FB; Thu, 07 Jul 2022 04:42:40 +0000 Date: Wed, 6 Jul 2022 21:42:40 -0700 From: Christoph Hellwig To: Konstantin Komarov Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/2] fs/ntfs3: Refactoring and improving logic in run_pack Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Konstantin, now that you have time to actively work on the ntfs3 driver again, can you consider looking into converting the I/O path to iomap, as already request during the merge? Getting drivers off the old buffer head based I/O helpers is something we need to address in the coming years, so any relatively simple and actually maintained file system would be a good start. On Wed, Jul 06, 2022 at 08:31:25PM +0300, Konstantin Komarov wrote: > 2 patches: > - some comments and making function static; > - improving speed of run_pack by checking runs in advance > > Konstantin Komarov (2): > fs/ntfs3: Added comments to frecord functions > fs/ntfs3: Check possible errors in run_pack in advance > > fs/ntfs3/bitmap.c | 3 +-- > fs/ntfs3/frecord.c | 8 ++++---- > fs/ntfs3/ntfs_fs.h | 1 - > fs/ntfs3/run.c | 41 +++++++++++++++++++++++------------------ > 4 files changed, 28 insertions(+), 25 deletions(-) > > -- > 2.37.0 > ---end quoted text---