Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3390236imw; Thu, 7 Jul 2022 00:32:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vslVeb83eJzi1RsY2rbbSh6UiqjUyPyrN4oHnikLy4sSOL2sdbZBpMJRUh29g8cS2A6HNa X-Received: by 2002:a17:902:b590:b0:16b:ef83:c3c7 with SMTP id a16-20020a170902b59000b0016bef83c3c7mr15010818pls.42.1657179122976; Thu, 07 Jul 2022 00:32:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657179122; cv=none; d=google.com; s=arc-20160816; b=gCNT+Xh2Zw9kiqwR8Io17vW4M7x58EZMmOqAJYF5A34fzu3m7D7cLwQ39c6E/lMQm8 ZoJ850RQ8zDrjaLio3ILKL7/p0zAMs8WpjRPlJR3Z2ZjkRYkFm0h64dtfcTKoKDqQh4i iVEWvXzaDic7Rnis0FjFOxfW3KJIe1cZxUGIXIkXps2wHrnW/NOEbZnKaGIXESHE8RAG EV3Tgj3BHU8EYs5Zl0Z5XVSe1lLnaaua6UBukD2hFP1KuFNcGe99PE5o1FveT8dKh6yN jyAEwICirHq2YTqqDs9uxRVBOTeYwXDg2z3qs+dNEOWYpPPr+TFrI+8R2gx8fZBvJux/ I02Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=hVlQwC9cFexPcp4fCHiVd+M0+X9x7yKdEmsb4yyO7qQ=; b=J+PBPEUMb5eX47OarqwuxmpkPiJDhlDlDEjP2vU1CBkuzZHXWf58cMkeUs6Uy9B29y gkpgDokKpNuxJ4W4vx749tKQWp622MzPZHTDm1dHJbhndwjOyLZ+iSU8p3jKusxB8022 YdZbJYiKdEGASC4Q6HxYWXB01rbzXvVxZcOlGfTmZnkj3jdiydZYEGvqmcv7y7GFmLO2 l2lcmcKKenS8vkfl30vjcwWhMYoV8N2Ss/oFzAqxqplPjbDmynI+PfrnBBP5fkX5nD4Y +2GVRM1UhheLESKnAOJ1K5m32rdgKl8ricgvIcf6BSRYq5NQsJIStJYlEwy5T/5nX1eE BzdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji9-20020a170903324900b00168b2d83958si9561389plb.133.2022.07.07.00.31.51; Thu, 07 Jul 2022 00:32:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233255AbiGGHav (ORCPT + 99 others); Thu, 7 Jul 2022 03:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbiGGHat (ORCPT ); Thu, 7 Jul 2022 03:30:49 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D05331235; Thu, 7 Jul 2022 00:30:44 -0700 (PDT) X-UUID: d2c34ff1fee144f4b921b7d1d663d878-20220707 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:6841d9ae-7ef7-40e6-9bc8-40cef7c34611,OB:0,LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:50 X-CID-INFO: VERSION:1.1.8,REQID:6841d9ae-7ef7-40e6-9bc8-40cef7c34611,OB:0,LOB: 0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:50 X-CID-META: VersionHash:0f94e32,CLOUDID:5e91a763-0b3f-4b2c-b3a6-ed5c044366a0,C OID:95ab2f9f30ad,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: d2c34ff1fee144f4b921b7d1d663d878-20220707 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 583295451; Thu, 07 Jul 2022 15:30:41 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 7 Jul 2022 15:30:40 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 7 Jul 2022 15:30:40 +0800 Message-ID: <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com> Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188 From: Johnson Wang To: Krzysztof Kozlowski , , , CC: , , , , , Date: Thu, 7 Jul 2022 15:30:40 +0800 In-Reply-To: <41e17a56-5cb0-8e90-c7ae-a7a56de986d0@linaro.org> References: <20220707054710.1396-1-johnson.wang@mediatek.com> <41e17a56-5cb0-8e90-c7ae-a7a56de986d0@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,MAY_BE_FORGED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote: > On 07/07/2022 07:47, Johnson Wang wrote: > > This commit adds dt-binding documentation of mmc for MediaTek > > MT8188 SoC > > platform. > > > > Signed-off-by: Johnson Wang > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > index 2a2e9fa8c188..3fbf33ad4f7c 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > @@ -32,6 +32,9 @@ properties: > > - items: > > - const: mediatek,mt8186-mmc > > - const: mediatek,mt8183-mmc > > + - items: > > + - const: mediatek,mt8188-mmc > > You duplicate quite a lot. Use enum. > > Best regards, > Krzysztof Hi Krzysztof, Thanks for you suggestion. I will use 'enum' to place this compatible strings. Just like this: - items: - enum: - mediatek,mt8186-mmc - mediatek,mt8188-mmc - mediatek,mt8192-mmc - mediatek,mt8195-mmc - const: mediatek,mt8183-mmc Moreover, it seems that missing an "items:" between oneOf and enum in the compatible property. Is my understanding wrong? BRs, Johnson Wang