Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kavyasree.Kotagiri@microchip.com>
To:     <robh@kernel.org>
CC:     <krzysztof.kozlowski+dt@linaro.org>, <Nicolas.Ferre@microchip.com>,
        <alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new
 compatible string for lan966x
Thread-Topic: [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new
 compatible string for lan966x
Thread-Index: AQHYkSi2d8vdUqQCqkCL84gayHBxnq1xaxKAgAEZa0A=
Date:   Thu, 7 Jul 2022 07:40:05 +0000
Message-ID: <PH0PR11MB4872E0DBEC7B10E550FC33AB92839@PH0PR11MB4872.namprd11.prod.outlook.com>
References: <20220706110619.71729-1-kavyasree.kotagiri@microchip.com>
 <20220706110619.71729-3-kavyasree.kotagiri@microchip.com>
 <20220706144303.GA7885-robh@kernel.org>
In-Reply-To: <20220706144303.GA7885-robh@kernel.org>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BwZrILSjY2YHRDzVGXqFdrP4XqX2f6EW9KNXIAQiSJLT9VfUYi0QrofC4nYZ?=
 =?us-ascii?Q?6F0/NhtdT8MrieG3KJOGVHPrmXZ6ucXwz+NJftLvRiPh/YdBNUff5mP/FtKk?=
 =?us-ascii?Q?BScjlvtuc+zinsKOt2Xt1EbUrPnyQZXrydGctEgQhf6Clrc+4BHaiHKx+My5?=
 =?us-ascii?Q?NPslIlJuAjGN2gWweMwV8bPL2DmdZ4/HUNk+Fsd84P8r/UlPJJDKYecsdwau?=
 =?us-ascii?Q?9h0MgPQtJKLKySR4aL3aDOsuL0YpSGVXQDh1/X6ZTcg2hhtdg6qoRHocLjCV?=
 =?us-ascii?Q?+5vhtx6pZPpfD6y5W+CiQGldwbTJO47qUN9+4aXEblPAi+K7p/OLqe2xA4Ut?=
 =?us-ascii?Q?0tKLzom98m2CccLQ8B2i163as4BiGocdisuIcoz0ufHSEMWQyfAnWXLL6dhi?=
 =?us-ascii?Q?QalJfpqKRv/y05OSTnfCY5KJuTWplyivWPtXd4KXQZb9lRUN+BSlHwtU3HU5?=
 =?us-ascii?Q?dAB3VxYu/ejKTdc/OJ+/UiB0of2/vVql2VX19vbc9UtjMluEGCBqWrhrzw2Y?=
 =?us-ascii?Q?HaQeCCN8DEZT0/JOGooHm/tjNW3yOp0Gx3pjkmmrMcrf7Wyt25TR8g7Y6BaN?=
 =?us-ascii?Q?BVu8oWFFdgcraUm5G9N8u18MT/tBjLEQL9Cq/Q4+J3EnUwsH6pYNTdGNBGkr?=
 =?us-ascii?Q?BoAPkv7900TSARaqR94CZQt9eB/b5096+X6X2rOlElNQ2ddH8hAesA3HDNzm?=
 =?us-ascii?Q?3UBQC+ODpI0nZj3pSb16qsHKAD0LYdAtd3zll6dVtVoxGl0ZTuiKgO9BgK+x?=
 =?us-ascii?Q?DMaGjCBNNQzzifOZ0jSAvZGWUjc2Zwt+Fyfk2p69uqSkzyeJzrWr6w281Af1?=
 =?us-ascii?Q?KZly/l0Fe71JA1YIW06JTlWriqHQP+Ml2vGpNnb/YzXeUKo2pAtFU18/lbPW?=
 =?us-ascii?Q?IB3XaIFE7Po6XCN6EVbYsDz1BX/nbKYEeOVdBgLKV2Uy4hupd32cdOqwtvUC?=
 =?us-ascii?Q?PxmIWua66eqRixgy0mXMkdgCkIt2KeGW/YLbRbUl1HvSaYVVG6tAMFlxeCRT?=
 =?us-ascii?Q?151CRuRZISpJFE9+/JOwxFE9LW+iB5I4gHw6hgp97IpSHbEX+rDuX5QnHwri?=
 =?us-ascii?Q?6MX235N9IU51Fo2GiYnVKLsHWXc5XqBBjB8H5E+vipw87U7BlmuK4wnJWDyF?=
 =?us-ascii?Q?98LVsOgIQbpuCVUmhSJ/9WA5zHi/U16G4qc99mYozDMC/Ffd9fVa7yUns282?=
 =?us-ascii?Q?eTpt/Xbat/aXF9ElGNjork7B+NPr65wMbKAQ/UZfLER2zUmM1FVbS4EP2AqW?=
 =?us-ascii?Q?gPvnBLxL6yV7P1VSbSQWtKV+p74+Wey8SBsmny69mIXj7I/8cWzf1orE/VVj?=
 =?us-ascii?Q?uQWigs52wkWS9YI79IT7rAuz0gtrpot61KyhWxt89st2WviFtyDK2aUE2hi6?=
 =?us-ascii?Q?ixIpArgks4ZtExxobMZDQMv6bGK6RU5QFAp+/HC8fvjo3IAfL6We24tCZFRu?=
 =?us-ascii?Q?fjPo+Dbrr577yUzsVCKnKkxOa4/VQfZ0y9qTm0ejdTRIHL0yWxtbr06gHAIu?=
 =?us-ascii?Q?F4yBbo7lJ1vla6i7MEM9y5keSxfO73T3S0ytyL4sM97/Ejhz5e3oMf8Fl2Wg?=
 =?us-ascii?Q?tqUul6eecUJdNTLUjedEtS83C1l8TiYVvKJl3hAA6RnoBAZe1HCkMmEDuh86?=
 =?us-ascii?Q?bA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4872.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 670537ef-180c-46ca-47db-08da5febe8c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 07:40:05.3059
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /vyZQ8NEB9FDIS7/wPdszqZo74zRA/6fSJzaMiS/rp+ZjeqYHn/4AVEp6vkXJeDmJAjDJK1d47YLk+L9tNw7nEnjgeFbND7JkCmhQc5iKxkdAvPBjAaJWexOUHbthXSE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3648
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > @@ -18,9 +18,11 @@ properties:
> >    compatible:
> >      enum:
> >        - atmel,sama5d2-flexcom
> > +      - microchip,lan966x-flexcom
>=20
> Don't use wildcards in compatible strings.
>=20
Ok. I will change it.
> >
> >    reg:
> > -    maxItems: 1
> > +    minItems: 1
> > +    maxItems: 2
> >
> >    clocks:
> >      maxItems: 1
> > @@ -47,6 +49,27 @@ properties:
> >      $ref: /schemas/types.yaml#/definitions/uint32
> >      enum: [1, 2, 3]
> >
> > +  microchip,flx-shrd-pins:
> > +    description: Specify the Flexcom shared pins to be used for flexco=
m
> > +      chip-selects.
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      minimum: 0
> > +      maximum: 20
>=20
> It's not clear how one uses this. It's selecting 2 pins, or a range of
> pins, or ???
>=20
I used minItems and maxItems to represent number of entries allowed. Either=
 one shared pin
can be mapped or max of 2 based on pins mapped on board and 0-20 is allowed=
 shared pin numbers.

> > +
> > +  microchip,flx-cs:
> > +    description: Flexcom chip selects. Here, value of '0' represents "=
cts" line
> > +      of flexcom USART or "cs0" line of flexcom SPI and value of '1'
> represents
> > +      "rts" line of flexcom USART or "cs1" line of flexcom SPI.
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      minimum: 0
> > +      maximum: 1
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -56,6 +79,31 @@ required:
> >    - ranges
> >    - atmel,flexcom-mode
> >
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: microchip,lan966x-flexcom
> > +
> > +    then:
> > +      properties:
> > +        reg:
> > +          items:
> > +            - description: Flexcom base registers map
> > +            - description: Flexcom shared registers map
> > +      required:
> > +        - microchip,flx-shrd-pins
> > +        - microchip,flx-cs
> > +
> > +    else:
> > +      properties:
> > +        reg:
> > +          items:
> > +            - description: Flexcom base registers map
> > +        microchip,flx-shrd-pins: false
> > +        microchip,flx-cs: false
> > +
> >  additionalProperties: false
> >
> >  examples:
> > @@ -71,4 +119,19 @@ examples:
> >          ranges =3D <0x0 0xf8034000 0x800>;
> >          atmel,flexcom-mode =3D <2>;
> >      };
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    flx3: flexcom@e0064000 {
> > +        compatible =3D "microchip,lan966x-flexcom";
> > +        reg =3D <0xe0064000 0x100>,
> > +              <0xe2004180 0x8>;
> > +        clocks =3D <&flx0_clk>;
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <1>;
> > +        ranges =3D <0x0 0xe0040000 0x800>;
> > +        atmel,flexcom-mode =3D <2>;
> > +        microchip,flx-shrd-pins =3D <9>;
> > +        microchip,flx-cs =3D <0>;
> > +    };
> >  ...
> > --
> > 2.25.1
> >
> >