Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3415410imw; Thu, 7 Jul 2022 01:06:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ueFsDDjQWgu6Ul2yyqYhWLGI9GP3SeeSwmn93BD/NoNAL0TpPbpeR5Bg7jnftUWw31c4KN X-Received: by 2002:a17:907:da7:b0:726:9c0b:708b with SMTP id go39-20020a1709070da700b007269c0b708bmr44282966ejc.595.1657181172643; Thu, 07 Jul 2022 01:06:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657181172; cv=none; d=google.com; s=arc-20160816; b=0kabyQc/t3tVn3K5X43e/yWWhVRuA4zb0J/U7da7pJQA1JxkWderXI/8TlmsiShLkh BZk2UAiRNyE+phr4Yj2JOrGgbcFbDsftI01BMPC4OnTGiinC65ei3STS0rPwkbP8Dyrd h/1H7wDlBAvIDuxqPtHfa2NLcpsqB6GTSlCUBdDf+DC04q8wrUr8YHJh/yp/Wmsm8VuV Ew4G6bDPmDaJu0+mEBLwbz87gqC6cKCPLeUBNq90WQ6S7I26ATBIAQcF+np6irmeVNjf pBsV7ELIjiD8UlgSbjUacjU+arTUvM/Noke4qlS1GBhsh7EYZE6YJBR9/C6w9HCod3+6 Q4MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=70xtc+uGcQwXm4fuaD/+Dh6Vj8lV/MgZmktrLD3peVk=; b=QVLxDs09SM9l4QEaJif1S2xM3Ukdh219tBMXUSSjFrV3o8GMgC0tZT9xJfRq8r2WXM NyWGqAXh7noO9Un2vUme1OVW5VhxXnQfeomdmWnfO8CGmHnDvA0ugpHt7FGnMIW9kBZ+ Fp8bDeqtKMaH99mPrt7VCW/DStlB4dcJavaqL/oqJ57lqr8veuSKmOsFvn6a+RLgiJc9 ctbzkeKcUbJazIix7cxVZKG+dEA3/YSJ8a0/rp5ExFJ2cwbByfDOcicAoC1kFVoEUHln daWIDOqqcjSb6knWZHjKl25WXwaf4cVdRHFrw2xjDjmVY6F1pHiPu1nJ7RYZSVp6seQZ Hu9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=q+ABpgrD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a0564021e8800b00437a34192cbsi490927edf.283.2022.07.07.01.05.47; Thu, 07 Jul 2022 01:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=q+ABpgrD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235200AbiGGHwp (ORCPT + 99 others); Thu, 7 Jul 2022 03:52:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235187AbiGGHwm (ORCPT ); Thu, 7 Jul 2022 03:52:42 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D584733366 for ; Thu, 7 Jul 2022 00:52:40 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id bk26so10026145wrb.11 for ; Thu, 07 Jul 2022 00:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=70xtc+uGcQwXm4fuaD/+Dh6Vj8lV/MgZmktrLD3peVk=; b=q+ABpgrDDFIRVVXBzf1fEBgDOZzkcnovjTczwvCHoQEx9EgtVFK1S3cP2uNewqCcTu p46x/EAuzL8Mq8CqKyQKnXaxdbv3t5xEZRPHIX+0v+6H8mmMHaFBVqG/LkKwzDxuMvnC hBFFYWRW6D7mzE+7JF28l0mzOAPa6pzYpJundz2VwprhE2P8uOzoL2H6ZCYKZxy9MJ// BeAQIkrUCwLtgQ8mgVS0wZ1tqgWgPyRDmcXgxyV01Cd757TNNiA/UbgAwSOyR+wXyAvU Qqv9uxflEEFTnsmPUuz5NOh649OaU3wk0Y4VIjLPFzrTqwduxHStzOCezNJdJWkRcmOQ SUdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=70xtc+uGcQwXm4fuaD/+Dh6Vj8lV/MgZmktrLD3peVk=; b=czvriuBz57DhrSTavDzEdWMoQnF9J4iChfNLDh2hcSFrQi94rpC86RY+WTZZTypzuu cb5KEgBByg6WDg1wm6ZMrdszq1jbNUdRdsxc3cdKA5To+Tm8WLK5vMdREADXa8cZcz3s TEowBx/x1yIXDskQ7Sa5rijfSVmZ+hcUx3ZUPh71TKJBUdfxh8oq+1OMO+/8Q2pdM3i4 wLlUPm6QryMskzm0WGJmR1rWVJd4sGVsrvf9P5fdAXJAWHwlnG+w1EUOEOF+xwA3y+ff R8P+9rPhNcPR9s/O027flSIKIVZSblwXiwrfNNNlRM/XwPTtwZ50r7pH5zDajqMn3f81 On/w== X-Gm-Message-State: AJIora+PmgzsQgZBpZgiowHAvkFwMskYlCOqZNdB59UqZldB0dAX472y 2tWIaH1v0C52x+yJPu28ORSTqw== X-Received: by 2002:adf:f34c:0:b0:21d:6705:87dd with SMTP id e12-20020adff34c000000b0021d670587ddmr20717172wrp.430.1657180359439; Thu, 07 Jul 2022 00:52:39 -0700 (PDT) Received: from groot.home ([2a01:cb19:85e6:1900:334b:5931:88c6:bbd2]) by smtp.gmail.com with ESMTPSA id m16-20020adfe950000000b0021d70a871cbsm6972089wrn.32.2022.07.07.00.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:52:39 -0700 (PDT) From: Mattijs Korpershoek To: Dmitry Torokhov Cc: Matthias Brugger , AngeloGioacchino Del Regno , Kevin Hilman , Fabien Parent , linux-input@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek Subject: [RESEND PATCH v3 0/2] Input: mt6779-keypad - fix hw code logic and row/col selection Date: Thu, 7 Jul 2022 09:52:34 +0200 Message-Id: <20220707075236.126631-1-mkorpershoek@baylibre.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Input: mt6779-keypad - fix hw code logic and row/col selection This serie is the first follow-up on the mt6779-keypad in order to enable it on the MediaTek mt8183-pumpkin board. To fully enable it on mt8183-pumpkin, we still need: * double key support * dts changes To ease up reviewing, I preferred sending this first. The first patch fixes a logic bug based on the (non-public) datasheet I have. The second patch configures the keypad correctly in order to not report bogus values. Thank you, Mattijs Changes in v3: * reworked row/column logic as discussed in [1] * Dropped Angelo's review since patch 1 changed Changes in v2: * Simplified SEL_COL/ROW_MASK macros as suggested by Dmitry * Added Angelo's Reviewed-by on patch 1 Mattijs Korpershoek (2): Input: mt6779-keypad - match hardware matrix organization Input: mt6779-keypad - implement row/column selection drivers/input/keyboard/mt6779-keypad.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) [1] https://lore.kernel.org/r/YpMDZORAlHmg/x/0@google.com base-commit: c4bcc1b99b8b8acdfe673e4701a9c2acb6b8b2fb -- 2.34.1