Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <458f78a3-3e32-a80d-e503-5e8252227ef6@amd.com>
Date:   Thu, 7 Jul 2022 09:55:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v1] drm/syncobj: Fix sync syncobj issue
Content-Language: en-US
To:     jie1zhan <jesse.zhang@amd.com>, broonie@kernel.org,
        dri-devel-bounces@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
        lucas.demarchi@intel.com, nirmoy.das@linux.intel.com,
        lionel.g.landwerlin@intel.com,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        open list <linux-kernel@vger.kernel.org>
References: <20220707030845.4059465-1-jesse.zhang@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220707030845.4059465-1-jesse.zhang@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qkk1SytiM0ErOVBZRDBab0VaRkkxM2pPcElxT2NGQXk2Z1UvWEt6Z3NIUTRl?=
 =?utf-8?B?eE9QaEhkQjNDcW5YekN4WnM4cVQ4VTNERHduZ1NNVjZPeEY4aTRsN2dsV2Va?=
 =?utf-8?B?eWduWEVzODhxSXM5WGdqb3VnUGNxT0gwYklwVUFuVGk1VUxaOElWaXlCQTk3?=
 =?utf-8?B?aVI0RXRYNmc0ajBmcXpoWU5BNEdyVllVTWZhODg4bmd1NFNZUXIvd09KTzN2?=
 =?utf-8?B?OWE2WG1ud0gwR21aVjJlT2MyTGExaW00aTJ5RklHalF2VnV1eDBkVFJZZzA0?=
 =?utf-8?B?ZWJPd2VYaWlLL1VGYUVHYTRhTk5maHUzeFpod3hDUmFLWTRycXdOWlpKS3RU?=
 =?utf-8?B?UHNWRWxHcVkrN3IwcHpqcE8zS0NZeE90V0crTEJqVUUvRUxjVWRqR3QyN1RK?=
 =?utf-8?B?ek96SUxVYlJxWHM1ZG5JU1pnV3NlQmQzbWFpR1h2blJkcE5FaVVzbVRVeWRs?=
 =?utf-8?B?NnJqK1QvYlBDaTJhckdQM3hvZU13OXdRVW9xdyt3UDF5ZTVJSDkybEsvVzBl?=
 =?utf-8?B?YURiajFnMHU4aHlKclBpY2lPU2wxNUtXQkdkdENXbmExMjdHYlBiMzJXVmFt?=
 =?utf-8?B?ZzRiRlg2R2x1ak8xNkRERytzLzZLQTFFdzlTWnkrRmttRTBWeS94REFWRVBk?=
 =?utf-8?B?eXF0Q0tTRENXOStHcUtVWmw3T2lQREV6NmVwQ0F3SmhJQ0lLYnpqWm5GWm03?=
 =?utf-8?B?UXFlMTdBSmh5SWpTUVZqWkFYVGp5cVhCazB1TnZHdS9hYS9FK3NDK0xlQkZI?=
 =?utf-8?B?Tlk2amFCUGJMYVdHL0lFMWZIMm1BaHp6dW5OTGJJd05abGEyYWV2QUs0ckRx?=
 =?utf-8?B?UVM0QUFIZE1ZNjJObzdkK04raHBmRDFnTnF1Ync3SEtqbzhpV0lVMTJtOFVT?=
 =?utf-8?B?MXZmMTFJRUVQNG9MWTBwcjZ4ZWZyakhhbGxiWWFLa0N2OVMzdnNXM3lMUVFH?=
 =?utf-8?B?Zk1ZY0t0SDZhWnZIZFhVTU9TWkpKZGtKRmtSU1pTWFRrUmI1bWtYM1pZSG9Y?=
 =?utf-8?B?eHNmTCsvSjlDTHhTc3B4cnlhY2gzamRaRnUzTU02dUk0TFF2WFk5SndibWdR?=
 =?utf-8?B?RnZaaS9vb0RzcHJCdlVRd3FVYmwxRXhrQk9QR2RKbjRmK1p2eWJqdzdibjVP?=
 =?utf-8?B?NytScHNraGRlcDdiOVArekxocXE2OVN5SktkM2szU21BN3JQME9Xdk94cllP?=
 =?utf-8?B?YXoydU4yQS80ZzhjZ0IvTFpTcUJncmxubVYyclFBdWxtRjROTnRHNC9HY1NB?=
 =?utf-8?B?OEY0MktVWk41L09HWUdST09GZ1g4N1ZQSy8xQklWVGxVNXRuRXFNWFo0OVdH?=
 =?utf-8?B?MnNQS0NUa0Jsc3ZieU1vbmtVR0pDaWRwdi92ZU9PZ0pJaGlkazB1YUNCVXVm?=
 =?utf-8?B?M2dSZ3YvMU81bkxkcHovNVVNTVFRaDZhT0lrQlQwam9wWmdlY1pSVjY2SjVV?=
 =?utf-8?B?czUxT1JGc3AvMUhMSXlIQVZ3cTc5RTZDRUVwb0JDYU9lK0RpU1pybDY2L3kw?=
 =?utf-8?B?ZW9LM0hyT3VYZzdFbzJQU1QybVRqODQwcUpsS1crbXNmdHBjZUVPbkxzNkY1?=
 =?utf-8?B?ZmNLRmlWMmVzRU0xRWhMTDNCYVJ3SU8zV0dFdTRJR2RTeHUxdFc0TWZVUkJu?=
 =?utf-8?B?M2Q2OW5nczhaNk1BTmZVTXpoVjY5WU41VFN0MGdyUGZnekFVS0NGY2RmWWRI?=
 =?utf-8?B?SStNenpVSThMcjFLUnVaelExbU40by85UWFTSnBxQ2JicVYzdGt5VkJUV09F?=
 =?utf-8?B?UGIreGpEcElYMGNxNXRuQWZkV0ZPNEZ0dks5NEJmVFYvOElWZjBIajRXUmQr?=
 =?utf-8?B?M0FOckpnSlBWMG9HYWhUQzVZanhOU1NmRkJKeUVQVjZBUGIrSWVvRThjQ1FY?=
 =?utf-8?B?UDBZQ3JndytpUk45djhUMjlxZlFia2NUUUptcmRGZTBuNDZWdlhhaW1FaDcr?=
 =?utf-8?B?M3ZtSnBUajRsSERhbVNvS0xXS09xOFM3eVNkRk10US8vUStoZ2R4SWgwb21J?=
 =?utf-8?B?VXcyN3UvK05oazk4Wk9nSlpEL2JCQTduV0JiTFZWZnFuOEkzTXFNV0c5SVYx?=
 =?utf-8?B?K05qT05XdFdGYlJUSlVrSkVUOFNVV2FXS0tSN2RQbmh6ZXNPTXQ5dHNwOVFp?=
 =?utf-8?Q?Kv23I4gmmOXtYBbwyJKtddiTX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e7041e5-d5cc-44b4-195f-08da5fee073b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 07:55:15.7014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mu6Fv3J/fjqwjBe+xCaZX08eL/AIstlMESSWXNlg7J3JV0UQIbiuRl3owTFyVyEK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5082
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 07.07.22 um 05:08 schrieb jie1zhan:
> enable signaling after flatten dma_fence_chains on transfer
>
> Signed-off-by: jie1zhan <jesse.zhang@amd.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Reviewed-by: Nirmoy Das <nirmoy.das@linux.intel.com>

Well please drop those Reviewed-by lines immediately! Neither Nirmoy nor 
me gave you the permission to add an rb to this patch. It looks like you 
have a major misunderstanding when to add that.

> ---
>   drivers/gpu/drm/drm_syncobj.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 7e48dcd1bee4..0d9d3577325f 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
>   	if (ret)
>   		goto err_free_fence;
>   
> +	dma_fence_enable_sw_signaling(fence);

That looks better, but ideally we would enable signaling when the fence 
is retrieved from the drm_syncobj and queried for it's signaled state.

Regards,
Christian.

>   	chain = dma_fence_chain_alloc();
>   	if (!chain) {
>   		ret = -ENOMEM;