Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2ae24b07-92ae-8bdb-8b2d-f90a4a9557a9@redhat.com>
Date:   Thu, 7 Jul 2022 10:37:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/ssd130x: Fix pre-charge period setting
Content-Language: en-US
To:     Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     David Airlie <airlied@linux.ie>
References: <20220706184133.210888-1-ezequiel@vanguardiasur.com.ar>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20220706184133.210888-1-ezequiel@vanguardiasur.com.ar>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Ezequiel,

Thanks a lot for your patch.

On 7/6/22 20:41, Ezequiel Garcia wrote:
> Fix small typo which causes the mask for the 'precharge1' setting
> to be used with the 'precharge2' value.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
>  drivers/gpu/drm/solomon/ssd130x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
> index 08394444dd6e..f4886e66ff34 100644
> --- a/drivers/gpu/drm/solomon/ssd130x.c
> +++ b/drivers/gpu/drm/solomon/ssd130x.c
> @@ -350,7 +350,7 @@ static int ssd130x_init(struct ssd130x_device *ssd130x)
>  
>  	/* Set precharge period in number of ticks from the internal clock */
>  	precharge = (SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep1) |
> -		     SSD130X_SET_PRECHARGE_PERIOD1_SET(ssd130x->prechargep2));
> +		     SSD130X_SET_PRECHARGE_PERIOD2_SET(ssd130x->prechargep2));

It's a typo indeed. Nice catch!

I wonder how did you notice this. Or was it just looking at the code ?

Acked-by: Javier Martinez Canillas <javierm@redhat.com>

I'll push it to drm-misc (drm-misc-fixes).

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat