Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "hca@linux.ibm.com" <hca@linux.ibm.com>,
        "gor@linux.ibm.com" <gor@linux.ibm.com>,
        "agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
        "borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
        "svens@linux.ibm.com" <svens@linux.ibm.com>,
        "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
        "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        "tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "farman@linux.ibm.com" <farman@linux.ibm.com>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "pasic@linux.ibm.com" <pasic@linux.ibm.com>,
        "vneethv@linux.ibm.com" <vneethv@linux.ibm.com>,
        "oberpar@linux.ibm.com" <oberpar@linux.ibm.com>,
        "freude@linux.ibm.com" <freude@linux.ibm.com>,
        "akrowiak@linux.ibm.com" <akrowiak@linux.ibm.com>,
        "jjherne@linux.ibm.com" <jjherne@linux.ibm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "hch@infradead.org" <hch@infradead.org>
CC:     "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "jchrist@linux.ibm.com" <jchrist@linux.ibm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>
Subject: RE: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to
 vfio_pin/unpin_pages API
Thread-Topic: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to
 vfio_pin/unpin_pages API
Thread-Index: AQHYkQGk+7oqdDT4NUCRLeKa0V01Qa1ymTqQ
Date:   Thu, 7 Jul 2022 08:46:12 +0000
Message-ID: <BN9PR11MB52769E657ED58B29677AC4F88C839@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220706062759.24946-1-nicolinc@nvidia.com>
 <20220706062759.24946-5-nicolinc@nvidia.com>
In-Reply-To: <20220706062759.24946-5-nicolinc@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xb0suVkbcdmoXQC8/9F5Yg01+16/zVaftGb1HluVhUAqPMKuoDLSM7f4/tKA?=
 =?us-ascii?Q?oCHWbLgR60GCW0aKHxXhsYB7pVgC6Ys/GWBAsOGOOMMqF0h8+FDI0YwPdUeI?=
 =?us-ascii?Q?zjBzy8vCJIcc6jzSYa8gWYKc8Z+yrazAOFYkCituKdrqTkv7QzKNeDNWw8ay?=
 =?us-ascii?Q?VeYVdOAqZ8hKVNzFMXtk3/a6BY3ifrJ3rgu37DeJnZT0pdoqn2qLP87nPeq6?=
 =?us-ascii?Q?+Ke7r0XPXO/3Kd2ApBOK/zSiiVdfnWbPGokz0wyWU3tAR/AW5PtHcI27wwwM?=
 =?us-ascii?Q?D4PA0xb+ddIHVj4U+VQ48dries4RkwLXR1dGQIf3A4wTWj/rYkPhvl1M9kNh?=
 =?us-ascii?Q?gjWQ8//rKzWrFbc7zQWWC9U3hpTAEpoejtA4vBBUwEH8x/XVP0Zm5C+vhMQR?=
 =?us-ascii?Q?22GDgyk97SiCYFoVt7lBjtLAWCzIyPcLcLyHfUyPofNc446IzagxyHaMMHp1?=
 =?us-ascii?Q?NT5V1eCU9N7cDAgevtNXn/B0oSJPgz4EmUfoA4d1D4odhWeXLWsun2s8jc0U?=
 =?us-ascii?Q?TXMO3/SxRmWEsUjPsd6fNS1RevNNd0kMDnvhXiKaPz3TWRBoP3+3CvjjQhXx?=
 =?us-ascii?Q?2+ECtc9YE/cqAuO8TxJcN+EdQfrGR/TGjQX51HJx3YBN9FDRudsdNIcZaaDH?=
 =?us-ascii?Q?ecP4U2srAGztfWzaTHFztPNxzUydqtOVlio/JcN0mC7US3vRBhEA0JJqLH7g?=
 =?us-ascii?Q?8plCQzhNgzLs21t9U6pHUariii4nXfIrT2F5S7obR5XL+em7rxJtSJauxC4Q?=
 =?us-ascii?Q?kNc7eGrSEi+QPMkGQmPxRZ2KaRuTJzZIsg45Yy7bhYt5BQt0wZ12SDC+sh85?=
 =?us-ascii?Q?73dSVKCP/IPDeoak/aK//NvsDe+BhSPYCHE2BRyaVPcsLGcp7k2C2rAaXejU?=
 =?us-ascii?Q?a+2f0CIxPQH8NeEB6SSzUl8Y7EFeaYi57Hvd5dtizPgAo5+deSmkGIzX48lK?=
 =?us-ascii?Q?eph/aasugUhsU1ES/+mfoA+auTq+8F4tncRu0kUOQRLeGNIj8RxGZISf3ySs?=
 =?us-ascii?Q?A0OecRyBHkxCib3csaZGeFnYDvFKjY6/WrW4dMIs2C5BzPqtjjNLYS+t33dD?=
 =?us-ascii?Q?7cbKNRsJnhN2/kmL7qvSL3eCB7Sveuua02fy8fRz8Le43pokoOPpOocd5ECg?=
 =?us-ascii?Q?ofBlJsdD7NnTe0A0Fy595naGhyLTujbHOQGQuT+RrSumDTtewo/HPbTUdaZz?=
 =?us-ascii?Q?6ErszZ1N4RAp3O4nuNClnarfKfRTN+SRe3ruxFbS6sA90AwGiV4Q/PuWTPIF?=
 =?us-ascii?Q?u7v5AR1uwYXrAU0VgSHMQWrpyHW/PTSkvh9nRj3oKyfngN3twTjcaJyqWlQM?=
 =?us-ascii?Q?pyD+W4snAbVdCCozbXqYl7p5FisuaVOxVHSXPvVZF6NafPX1/6OYcIjmTSyu?=
 =?us-ascii?Q?QdNN8pme/5u8IEvcWqDJcGf/teIDYkwL0URVPZcJyNqkIEoFywPBfGQDb7li?=
 =?us-ascii?Q?wlzzQ/CnuFHuK6BvKQCnC161TfEMBHuGfThLOxuEbGnyEi/b2sIkYvZLSDUi?=
 =?us-ascii?Q?qtmkNQLgO/hbaiwefwr6C7UuRAMnOLMPG8JMZi7YQd5zOyIpLFABsCtdgikG?=
 =?us-ascii?Q?1B6YbT27boS8ahslMDHAzJdXmVbjoHOnTmypDTUJ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 611f6179-7572-4cb7-b826-08da5ff52534
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 08:46:12.2028
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aoBWMx37ZcNIcvvZ23/z1adTdPhOsAWTMhhEPh7dUeHivdeUAm9sa+WiheyxQtkB9D5MTku7JTK4g642XlK4og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5907
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Nicolin Chen
> Sent: Wednesday, July 6, 2022 2:28 PM
>  /*
> - * Pin a set of guest PFNs and return their associated host PFNs for loc=
al
> + * Pin contiguous guest pages and return their associated host pages for
> local

can we replace 'guest' with 'user'?

>   * domain only.
>   * @device [in]  : device
> - * @user_pfn [in]: array of user/guest PFNs to be pinned.
> - * @npage [in]   : count of elements in user_pfn array.  This count shou=
ld
> not
> + * @iova [in]    : starting IOVA of user/guest pages to be pinned.

remove 'guest'.

> + * @npage [in]   : count of pages to be pinned.  This count should not
>   *		   be greater VFIO_PIN_PAGES_MAX_ENTRIES.

greater 'than' ...

otherwise looks good:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>