Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 07 Jul 2022 10:53:47 +0100
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH 11/11] ASoC: jz4740-i2s: Support continuous sample rate
To:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, linux-mips@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Message-Id: <N5ANER.SGRSW7GYX3423@crapouillou.net>
In-Reply-To: <20220706211330.120198-12-aidanmacdonald.0x0@gmail.com>
References: <20220706211330.120198-1-aidanmacdonald.0x0@gmail.com>
        <20220706211330.120198-12-aidanmacdonald.0x0@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


Le mer., juil. 6 2022 at 22:13:30 +0100, Aidan MacDonald=20
<aidanmacdonald.0x0@gmail.com> a =E9crit :
> The I2S controller on JZ47xx SoCs doesn't impose restrictions on
> sample rate and the driver doesn't make any assumptions about it,
> so the DAI should advertise a continuous sample rate range.
>=20
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  sound/soc/jz4740/jz4740-i2s.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/sound/soc/jz4740/jz4740-i2s.c=20
> b/sound/soc/jz4740/jz4740-i2s.c
> index ee99c5e781ec..053697c7f19e 100644
> --- a/sound/soc/jz4740/jz4740-i2s.c
> +++ b/sound/soc/jz4740/jz4740-i2s.c
> @@ -378,13 +378,13 @@ static struct snd_soc_dai_driver jz4740_i2s_dai=20
> =3D {
>  	.playback =3D {
>  		.channels_min =3D 1,
>  		.channels_max =3D 2,
> -		.rates =3D SNDRV_PCM_RATE_8000_48000,
> +		.rates =3D SNDRV_PCM_RATE_CONTINUOUS,
>  		.formats =3D JZ4740_I2S_FMTS,
>  	},
>  	.capture =3D {
>  		.channels_min =3D 2,
>  		.channels_max =3D 2,
> -		.rates =3D SNDRV_PCM_RATE_8000_48000,
> +		.rates =3D SNDRV_PCM_RATE_CONTINUOUS,
>  		.formats =3D JZ4740_I2S_FMTS,
>  	},
>  	.symmetric_rate =3D 1,
> @@ -415,13 +415,13 @@ static struct snd_soc_dai_driver jz4770_i2s_dai=20
> =3D {
>  	.playback =3D {
>  		.channels_min =3D 1,
>  		.channels_max =3D 2,
> -		.rates =3D SNDRV_PCM_RATE_8000_48000,
> +		.rates =3D SNDRV_PCM_RATE_CONTINUOUS,
>  		.formats =3D JZ4740_I2S_FMTS,
>  	},
>  	.capture =3D {
>  		.channels_min =3D 2,
>  		.channels_max =3D 2,
> -		.rates =3D SNDRV_PCM_RATE_8000_48000,
> +		.rates =3D SNDRV_PCM_RATE_CONTINUOUS,
>  		.formats =3D JZ4740_I2S_FMTS,
>  	},
>  	.ops =3D &jz4740_i2s_dai_ops,
> --
> 2.35.1
>=20