Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 7 Jul 2022 13:56:26 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Karthik Alapati <mail@karthek.com>
Cc:     Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: don't use index pointer after iter
Message-ID: <20220707105625.GI2338@kadam>
References: <Ysa1oopf0ELw+OfB@karthik-strix-linux.karthek.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ysa1oopf0ELw+OfB@karthik-strix-linux.karthek.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z2445jrHVibJr9UYLlYspNC24k8WqzvU+LmuvuMI5iXf6YppZqPdr1LOzGry?=
 =?us-ascii?Q?UvJdmMmr+S7/c912sA3K1lm37a0BLuhnDLNraLLRCxHRVePbhTWxpFrT/Gmd?=
 =?us-ascii?Q?H1AVhyPjKBYYJtGvTwmjakaR+v2SaZXewF9Ju9vaoY7ORMXsjZfPtHXPL9VP?=
 =?us-ascii?Q?mqxvOAQQwkZs86olk62Kl2ptNfUTGe6vVK8cDBrHopvxJqrcMNFsSOTNqfsy?=
 =?us-ascii?Q?sEtE64yBBq6wgRi/1wzJqdR8x5OJu5/ysAnRYv9CrOXvnv523FINHXPcfO2H?=
 =?us-ascii?Q?86w7vio0Wh/QkQz9xh/hm8vxzYS3f1Ksd/n5klmUQhEkaOIz4EpoZcR1Df6s?=
 =?us-ascii?Q?PYrmGusO1natqPwYaBi3wqwFTH6/0c+ux2MpsGynCL/amrduKm+RJKyVAAY8?=
 =?us-ascii?Q?3ZicaNxLKhCO5POTGBXXsh7yvd2sE9Txz1KWfCFU00b3JvwyCxyMhvsMBaMx?=
 =?us-ascii?Q?8PQ9XY0s76Id0R012blu8dncPO22DBYEHEKw8pFS+dJ1C1XZ8j4/p88NB7+z?=
 =?us-ascii?Q?RnpZfDd8LVtgNjGdm2JESU7K65tZW26rQmKvC1jLGErhak4b8Yw2dDRHZf+O?=
 =?us-ascii?Q?YxeZkErRVa2aoQXwFkuGQvPRwqrwn9tLSE1YSBOoYmOUAu3624BU08Kn9NRn?=
 =?us-ascii?Q?6z7jIQrMDRhFe/zGdtYTuEIeuRnixvUlpk0QqLWwul3Qi8b5rVHq0xTdfRbN?=
 =?us-ascii?Q?EeCkcMuS1YSMSUzYSpIRpxwYlOxGSWUkQ8mcWKr7b0d2O7yd0lRT5eP0/eXF?=
 =?us-ascii?Q?Plfii6r3BFP+RvwweBZB3ByOYX84C8MWpAojm7FjS+eDqxP9GQqix5vrJTgf?=
 =?us-ascii?Q?2YB/LTfMXxgj+EvVMjBYqosW2rEO+0HL9jYXMIKIByy8FcsCNg9KgmMp6e5D?=
 =?us-ascii?Q?8/EEFr7HhzweAlA9Lfe0qcXXZn4p2vdJbwpoPyh5B/AJp60WuUAkLT2XAW0M?=
 =?us-ascii?Q?RXnWkDLSmMKxOlzQKjKbek+X7r8aARkLiiOf9JJ9RaeDk6RLZpTV5+ILxb1Q?=
 =?us-ascii?Q?r8bmPyHkUP76Wz3xw/bZ7Gm7DwiWVzKZmwKvI80QMUz8GI3AE+kBaNgsFyrl?=
 =?us-ascii?Q?qwSWlKfvdKPiWGSCjQj8BwTEQ0U5k1sYYGOfxqGCcFPm0ZrYsXOHUKlxoy9h?=
 =?us-ascii?Q?ItUb55STnsaoHWF7Zn+3pEnek++5ptwjqJe5lEVs5tYA+6m7Pza2PsOq7WVv?=
 =?us-ascii?Q?gCCQ5BuBzfjoxMxT+aAiu1MaSS7+YN35sFgwXe2DRVq7vgoe0TY4WJlMi8cs?=
 =?us-ascii?Q?FXp/SLMIqoDKsiv8YjS7NFviGLGgQnjRBFqg75X//w9CtbCES0VQ0yBvjlJ7?=
 =?us-ascii?Q?NWKNSGW0d/IHvjsFT7oeYpBY93hDpmqEe2GS7nxHItqgpnbHYo6dbEJzJzg/?=
 =?us-ascii?Q?JEilq7XVfkWKIQmKGqoVlmDjqYePIYtuSmI9g7S7JvJMKKSKZpvRoy2vJ6fA?=
 =?us-ascii?Q?VjAFsj54kk0fD4Wksp5FpguLUFBMHms56jWxzgLnmqBh+LaEAerqqmL34+9G?=
 =?us-ascii?Q?i/rvtm+iVyHYCg8odZcFCKX7yXkfSRRDJ3YtwQ8Y2Oh+vaJa8ELJ4aw001tF?=
 =?us-ascii?Q?WrPoKuyK1LCpQCedimegUeWT9QuIHXm2klxfTkDcKRgyOs4MDzykmhZxP7Gu?=
 =?us-ascii?Q?Sg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6096e919-5f1d-4eb9-16b0-08da60076212
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 10:56:45.5548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lvgp0+f2LG5c+N0J/BRxZxYNgiqaynnGZfTeJLrOPPam6+teBrlj6thFRbQnkxMrmmGmDMAANHvFm2rvrw1giaK6oFsiNtNTsduS8NBIU8I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4315
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-07_08:2022-06-28,2022-07-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207070043
X-Proofpoint-ORIG-GUID: iBZJ2_wYMPToJN4ZA1icGeZ1wefuE98K
X-Proofpoint-GUID: iBZJ2_wYMPToJN4ZA1icGeZ1wefuE98K
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2022 at 03:59:54PM +0530, Karthik Alapati wrote:
> There are some usages of index pointer of list(w) which may not point to
> the right entry when the required entry is not found and the list traversal
> completes with index pointer pointing to the last entry. So, use w_found
> flag to track the case where the entry is found.
> 
> Currently, When the condition (w->dapm != dapm) is true the loop continues
> and when it is not then it compares the name strings and breaks out of the
> loop if they match with w pointing to the right entry and it also breaks
> out of loop if they didn't match by additionally setting w to NULL. But
> what if the condition (w->dapm != dapm) is never false and the list
> traversal completes with w pointing to last entry then usage of it after
> the iter may not be correct. And there is no way to know whether the entry
> is found. So, if we introduce w_found to track when the entry is found
> then we can account for the case where the entry is not actually found and
> the list traversal completes.
> 
> Fixes coccinelle error:
> drivers/staging/greybus/audio_helper.c:135:7-8: ERROR:
> invalid reference to the index variable of the iterator on line 127
> 
> Signed-off-by: Karthik Alapati <mail@karthek.com>
> ---

Already fixed a month ago.  Please always work against staging-next or
linux-next.

regards,
dan carpenter