Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f60dacead3da4ab78edd225749d698f8e621f577.camel@kernel.org>
Subject: Re: [PATCH v3 2/2] afs: unlock the folio when vnode is marked
 deleted
From:   Jeff Layton <jlayton@kernel.org>
To:     xiubli@redhat.com, dhowells@redhat.com, idryomov@gmail.com
Cc:     marc.dionne@auristor.com, willy@infradead.org,
        keescook@chromium.org, kirill.shutemov@linux.intel.com,
        william.kucharski@oracle.com, linux-afs@lists.infradead.org,
        linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org,
        linux-cachefs@redhat.com, vshankar@redhat.com
Date:   Thu, 07 Jul 2022 06:56:08 -0400
In-Reply-To: <20220707045112.10177-3-xiubli@redhat.com>
References: <20220707045112.10177-1-xiubli@redhat.com>
         <20220707045112.10177-3-xiubli@redhat.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-07-07 at 12:51 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>=20
> The check_write_begin() should unlock the folio if return non-zero,
> otherwise locked.
>=20
> URL: https://tracker.ceph.com/issues/56423
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  fs/afs/file.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/fs/afs/file.c b/fs/afs/file.c
> index afacce797fb9..b23e7b5a48ad 100644
> --- a/fs/afs/file.c
> +++ b/fs/afs/file.c
> @@ -379,7 +379,13 @@ static int afs_check_write_begin(struct file *file, =
loff_t pos, unsigned len,
>  {
>  	struct afs_vnode *vnode =3D AFS_FS_I(file_inode(file));
> =20
> -	return test_bit(AFS_VNODE_DELETED, &vnode->flags) ? -ESTALE : 0;
> +	if (test_bit(AFS_VNODE_DELETED, &vnode->flags)) {
> +		folio_unlock(*folio);
> +		folio_put(*folio);

Don't you also need this?

	*folio =3D NULL;

> +		return -ESTALE;
> +	}
> +
> +	return 0;
>  }
> =20
>  static void afs_free_request(struct netfs_io_request *rreq)

--=20
Jeff Layton <jlayton@kernel.org>