Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <872891aa-11ea-ed60-5090-940e8e7e4458@amd.com>
Date:   Thu, 7 Jul 2022 16:38:04 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: linux-next: build failure after merge of the sound-asoc tree
Content-Language: en-US
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20220707200428.3eb1a20e@canb.auug.org.au>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <20220707200428.3eb1a20e@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTZaVmVyRmREdG9XRGlGd2RPNC9PUEZWTjFiaFVJQ0I5akphMlRDbm5ONG85?=
 =?utf-8?B?NzhYTkgwMTNtRFdiSEtlQ1dTMkUrallMQlFIenlWNGxsRWpXeXFGSGlmWGFV?=
 =?utf-8?B?VUQ1WC9nSkVsT1dDVDE3MktXSmc3cUtsM2tvZWcrN2c0S1Ayc1RBNnhwZVIx?=
 =?utf-8?B?am1yYjJERVdHRUtQNjN4eWVNZ2RjQzAwZkh5dDMwZWRjYXN5TzhxQ3RqQm9R?=
 =?utf-8?B?Uk51am9pSklIeG1LTG5oUzluZmVkdDhHdTIzRjV3aE9wZjhQR0ZDdlJEb2w5?=
 =?utf-8?B?b3FQU1I4OCtXZlRkM0N0TThNT1RVVjJGNEFZaC9BUnVMbVR1cDBHRUhVb3RR?=
 =?utf-8?B?NnRmMTJoVE9qd2RoSFY4NVFxcnh2TjNrbXFqRjZvOEpEWTVMR1ZFaHNUT09m?=
 =?utf-8?B?STNrM2JMNU5DUlUxS0JPVEdxZzdMWHExdHlleDgzWW8zR3BPN1k4SDFoTHZz?=
 =?utf-8?B?b3pZRTQraEw5RnNaNmRxd3ZQVlZJT1NUZWZQNDQ4S0h2MnJ2TmhMVTJBY29I?=
 =?utf-8?B?RUdVOG5lR2pPTTM1T1pPQ0o0K1hqaEpYQi9wRFRTYVdqYlJoenFlajhOWktG?=
 =?utf-8?B?T093dWJza2ZMakQ4WldLdzNkd3BxdHZpOXg5ak9BQVZDU1Vvc3BCSG9oSUtT?=
 =?utf-8?B?UVIrV1hLTVNjMmRvTm4raGZiV01RRFJSeFZzc1hmclM4NUxlTDhZS0tsN29s?=
 =?utf-8?B?VGNrQ2VBbFdRK2dmMllyVUVjeWo0dDdUdXc4U2NWdFY2amFLaldUWlJ6YVo1?=
 =?utf-8?B?V0t2NHhxM0N0anF6bC9MbzdUbU9ZVG10WUFQTjkxV3ZPSUVoYjZsS2NwQlJY?=
 =?utf-8?B?NGxBQk1BRksxZTN0Mmg1ejJQOEVvZiszS3huQXU3dm5EZ09Id3loS2w5NVB2?=
 =?utf-8?B?NE9kTlVqODlhZ2ticnlZNTArUWR6aUVmYWprSFBXekZmZGZUbThwaE5VVVNn?=
 =?utf-8?B?ZEw4MmpMbDNPY2Q4UzhCbUsyRWp3eDI0bFp6ZW9QK211ZFVpcHFyK0JwNUhT?=
 =?utf-8?B?WWdndUVUdlJuVWNQaGhXQnFpL1dqelNqYk9kUHlCQTNPR0RuRVZkU05wcjdD?=
 =?utf-8?B?U21tWGpHZUF3MjRteVUxeGpRbGRTLzVwcHV0eTRXWXFlY0dBdUZhYTFmTUhw?=
 =?utf-8?B?aG5TOERjVWdSVnN4UmkrdURhcXhJOU00N3dtZmIvcFFKT2h2M1dLUjhSWWNU?=
 =?utf-8?B?RU1vMVV0ZVhxby9EbEJocnRkVGdQRlRLYi9xRmdmUjV6OFBnNzdlVkpORmFQ?=
 =?utf-8?B?V3MrYXZ0U3gxaXpSNWEwbHZYZjdtL1A0QnRVeGFWS2ZuK2piZGxrMDFMVGtx?=
 =?utf-8?B?RG4wUU9TQkNGOUQxS3FGNHhKamlSRzIxbFZwendXMGpqZDFZK25iVTl6WG9h?=
 =?utf-8?B?c09DOUJMcUNPRnBEL0Jxb3BkY1FvRWFjNHhoV1Z3bE1peFN6MWUzR0g2dk9z?=
 =?utf-8?B?bW4vN2lUMWZDWE53UnlHanBOUEttemplS2R4MnRsTzd0Z0dxNllHWDJ1S3ho?=
 =?utf-8?B?VXhNWkNCalJTakNnTnZGNzBJSkMxN3lkbWhpRXR6aWFRMzVDeFQ2bVgyOFBM?=
 =?utf-8?B?NnRjaXFyY2lzSksyWG9ZdUUranVPaU1iYXZ1VVIxbEVWVTFNelhnMU1oTTJI?=
 =?utf-8?B?VXNJcTIwaTQxaXl1Q2lEdE83NDg2ekp1d3d1ZmVUZmY5a0pSdnRRZS9HMHVu?=
 =?utf-8?B?cXozWGpyRWpqYmdIZ255WGhFcUJXQ2RhZTFzQnBuUGlSenRlNzR5N3E1UE9y?=
 =?utf-8?B?WGJ4MFZOVVRmZ2N6ckh2RnhzK2lVdm9wM0c2Q3MwaUg3c0JoaFNRMS9uQm1Q?=
 =?utf-8?B?SFdsTC9iUkVHWDhEM21ncC9TcDZZNDJ2RUhqTHE4cElXZVdMV3VqaUg3dGZx?=
 =?utf-8?B?b3R5UU9kS2R5MEdmSjJVUnlkTit6dlVjd0creloyd3BZcVc0dTh2aHFhWUVp?=
 =?utf-8?B?MWhWWXJWZWVCeG4reC9vdHduRDVUbzE2Zk0vZDJqQ0ZwcVVSbkYzVzBvRkRF?=
 =?utf-8?B?UzdRL2NTTU50a3dGTzJuWlFnRTF3T3ZPVzcvNndpZnFjenJ1M0EyVkxCSUFK?=
 =?utf-8?B?K1dXQmprOWhlNjRmcHRhY3kyeEZtaEswM29lTkJ0RnFkcGRpTjd0UzNGdlVD?=
 =?utf-8?Q?rR+mBYDfKGrF8RSHpm8OnaHYQ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96fa8455-6877-4ec0-180a-08da6008a19c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 11:05:41.7305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AW6cEtPdaIOuTrENjWjHoAWxN2TyjZB3g5ug9b0s4DRB4eb84o0wLngT075r9fJDEMl9WEm14J8qsAkFSEi7Pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3753
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/7/22 3:34 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> sound/soc/amd/acp-es8336.c: In function 'st_es8336_late_probe':
> sound/soc/amd/acp-es8336.c:204:33: error: invalid use of undefined type 'struct acpi_device'
>   204 |                 put_device(&adev->dev);
>       |                                 ^~
> sound/soc/soc-acpi.c:34:1: error: redefinition of 'snd_soc_acpi_find_machine'
>    34 | snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from sound/soc/soc-acpi.c:9:
> include/sound/soc-acpi.h:38:1: note: previous definition of 'snd_soc_acpi_find_machine' with type 'struct snd_soc_acpi_mach *(struct snd_soc_acpi_mach *)'
>    38 | snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/soc-acpi.c: In function 'snd_soc_acpi_find_package':
> sound/soc/soc-acpi.c:58:36: error: implicit declaration of function 'acpi_fetch_acpi_dev'; did you mean 'device_match_acpi_dev'? [-Werror=implicit-function-declaration]
>    58 |         struct acpi_device *adev = acpi_fetch_acpi_dev(handle);
>       |                                    ^~~~~~~~~~~~~~~~~~~
>       |                                    device_match_acpi_dev
> sound/soc/soc-acpi.c:58:36: error: initialization of 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> sound/soc/soc-acpi.c:64:25: error: invalid use of undefined type 'struct acpi_device'
>    64 |         if (adev && adev->status.present && adev->status.functional) {
>       |                         ^~
> sound/soc/soc-acpi.c:64:49: error: invalid use of undefined type 'struct acpi_device'
>    64 |         if (adev && adev->status.present && adev->status.functional) {
>       |                                                 ^~
> sound/soc/soc-acpi.c:80:26: error: implicit declaration of function 'acpi_extract_package' [-Werror=implicit-function-declaration]
>    80 |                 status = acpi_extract_package(myobj,
>       |                          ^~~~~~~~~~~~~~~~~~~~
> sound/soc/soc-acpi.c: At top level:
> sound/soc/soc-acpi.c:95:6: error: redefinition of 'snd_soc_acpi_find_package_from_hid'
>    95 | bool snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from sound/soc/soc-acpi.c:9:
> include/sound/soc-acpi.h:44:1: note: previous definition of 'snd_soc_acpi_find_package_from_hid' with type 'bool(const u8 *, struct snd_soc_acpi_package_context *)' {aka '_Bool(const unsigned char *, struct snd_soc_acpi_package_context *)'}
>    44 | snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/soc-acpi.c:109:27: error: redefinition of 'snd_soc_acpi_codec_list'
>   109 | struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
>       |                           ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from sound/soc/soc-acpi.c:9:
> include/sound/soc-acpi.h:51:41: note: previous definition of 'snd_soc_acpi_codec_list' with type 'struct snd_soc_acpi_mach *(void *)'
>    51 | static inline struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
>       |                                         ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   f94fa8405801 ("ASoC: amd: enable machine driver build for Jadeite platform")
> 
> I have reverted that commit for today.
> 

Hi Stephen,

We have provided fix for build error and pushed patch for upstream review.

Patch title: " ASoC: amd: fix ACPI dependency compile errors and warnings"
patch link:
https://lore.kernel.org/lkml/20220706205515.2485601-1-Vijendar.Mukunda@amd.com/

We will resend the fix for upstream review.

Thanks,
Vijendar