Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e8811c9b-f826-2810-ee9e-df86250fd4cc@quicinc.com>
Date:   Thu, 7 Jul 2022 17:58:19 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Move wcd specific pin conf to
 common file
Content-Language: en-US
To:     Doug Anderson <dianders@chromium.org>
CC:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        <quic_rohkumar@quicinc.com>,
        "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Judy Hsiao <judyhsiao@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>
References: <1657102611-20067-1-git-send-email-quic_srivasam@quicinc.com>
 <CAD=FV=UaUnZfWsXGQx6PoVQ5qqtsq10Dnui1v0Xn0S5Y-YgwRw@mail.gmail.com>
From:   Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Organization: Qualcomm
In-Reply-To: <CAD=FV=UaUnZfWsXGQx6PoVQ5qqtsq10Dnui1v0Xn0S5Y-YgwRw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/7/2022 2:13 AM, Doug Anderson wrote:
Thanks for your time Doug!!!
> Hi,
>
> On Wed, Jul 6, 2022 at 3:17 AM Srinivasa Rao Mandadapu
> <quic_srivasam@quicinc.com> wrote:
>> +/* PINCTRL - BOARD-SPECIFIC */
> It's not really "board specific" since this is actually a file that's
> included by multiple boards.
Okay. Will update accordingly.
>
> Maybe just use the header "PINCTRL" for now. Everything here is just
> adding pull/drive strength/slew-rate info to existing pinctrl
> settings. If we ever have more than that and want to separate into
> different sections we can always adjust later.
>
>
>> +/*
>> + * Methodology for gpio-line-names:
>> + * - If a pin goes to CRD board and is named it gets that name.
>> + * - If a pin goes to CRD board and is not named, it gets no name.
>> + * - If a pin is totally internal to Qcard then it gets Qcard name.
>> + * - If a pin is not hooked up on Qcard, it gets no name.
>> + */
> This file doesn't include "gpio-line-names" so you don't need to
> include documentation about it.
Okay. Will remove it.
>
> -Doug