Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3669157imw; Thu, 7 Jul 2022 05:52:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t9V43GHfFlA9XQtRsBz7K9kAfMsux+nJsRX2jWimA7patGS+J2Nb8wjmYQ1OvYRk0WRuej X-Received: by 2002:a17:907:6295:b0:703:92b8:e113 with SMTP id nd21-20020a170907629500b0070392b8e113mr45005486ejc.594.1657198339707; Thu, 07 Jul 2022 05:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657198339; cv=none; d=google.com; s=arc-20160816; b=ze/M917IT3ExJN1U2ovGQ8UTz9qxGDMnQ2ZHZT1AdfggWXthIgsIorEvAesxS2HfV5 9+UbHwafpeWYYH4j7vVSbLGse9JvEi48/VC/FOCardPhl9JCsot59CyXkBG9wnkhceLj JB30Mt1i9T2xpyRmS0S9A3cjnX3BTXlUP+kkd4lzOJ8v8zQ9ow/H7viFfIGssCR7O3TM d4p39hix7uvGKH+ruYSF3IXzyd+jK0kzggdlj/ffYz3MRgOmWh45RztfWvjPjN1J0eff z5MN/vCLGw0l708kuDSr6MoYcQr6QEqfWaxCrPpvkipRB7VFbmXzqMXYQJy8jrU+DTwB KiWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QfuCQfWw0R4Q88qq2d57w+fLKWKJ84NLA20PhY0262o=; b=qkId6rM3AUymJPpLB6goEgzC+sIC+uDjvd0bClARhJaGNSdGvm+DssGGClyFI2OVCy ddTpKOz0N7mYUE9w3RaPAwTrIexB5N4VrEqvc9tZ/WUeTIvqL2I4EFgbJO7YN356Xpko zXhduMOlJ9jO41wAt3Bzg0GV8wyWcREPQSxVLaL0SeFQ645DWkHuNY5m0OC1s4Es0M8i ezAZsHVh56lpIpePoTvK6BN4xXaq7zENHT2a8o4TSqS3jvsRBvVYwrIgoJ23MpNJqCty o3H4Drtqkn9GC6zkN3bgCMoyUU/fpd10v6ySYe+HyLSt/VcquITqksh43+G2TGZtHq6A FkVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=kAlWH5oh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020a50fd11000000b0043a7c1caabfsi3170304eds.223.2022.07.07.05.51.53; Thu, 07 Jul 2022 05:52:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=kAlWH5oh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235392AbiGGMga (ORCPT + 99 others); Thu, 7 Jul 2022 08:36:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234713AbiGGMg1 (ORCPT ); Thu, 7 Jul 2022 08:36:27 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04D2524097; Thu, 7 Jul 2022 05:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QfuCQfWw0R4Q88qq2d57w+fLKWKJ84NLA20PhY0262o=; b=kAlWH5ohaNATSdC1GQ+NF2V6wa 41jRRwvfAUbq1hdmSbrCRtXj4idHyrlgsPxys7tc+KTCasciNhdDEIKsBbCW14UzM/iYRju60W6e0 3OLUH4f4PnHF+cmu1zdW62QPubeaen4F8Kl7rqUKw5LRgrwWsMPHT1T7yQTVuiEVYlWeDpsIDoJj3 mkpS6nTh/BWVvMakjPk0qHKzhcmrpEfmunYvnRN+uhV/CL/ny6AFL92yCQ4rBL32t3aOf8iRQq3Tz mseVv320eJqzcAFoCs6bM7UQFtHD7ImIZPNFyVD00AghM9/jdDazuTrHjbX3y/cJJHP4bTjXQnxR7 1UgM5z7A==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.95 #2 (Red Hat Linux)) id 1o9Qjt-0098gu-Mm; Thu, 07 Jul 2022 12:36:13 +0000 Date: Thu, 7 Jul 2022 13:36:13 +0100 From: Al Viro To: Alexander Gordeev Cc: Alexander Egorenkov , Heiko Carstens , Vasily Gorbik , Matthew Wilcox , Baoquan He , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v2 1/1] s390/crash: allow multi-segment iterators Message-ID: References: <613f63d652bb4fa6fb3d2bb38762de6bb066b35a.1657172539.git.agordeev@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <613f63d652bb4fa6fb3d2bb38762de6bb066b35a.1657172539.git.agordeev@linux.ibm.com> Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2022 at 08:01:15AM +0200, Alexander Gordeev wrote: > Rework copy_oldmem_page() to allow multi-segment iterators. > Reuse existing iterate_iovec macro as is and only relevant > bits from __iterate_and_advance macro. > > Fixes: 49b11524d648 ("s390/crash: add missing iterator advance in copy_oldmem_page()) > Signed-off-by: Alexander Gordeev To be followed by duplication of every change ever done to those macros? Hell, no. Do it the same way it's done for that _copy_from_iter_flushcache() thing - i.e. an ifdef in lib/iov_iter.c and no duplication of that forest of macros.