Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 7 Jul 2022 14:58:07 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Alexander Potapenko <glider@google.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv4 3/8] mm: Pass down mm_struct to untagged_addr()
Message-ID: <20220707115807.pzrj7bngm2ndcjwk@black.fi.intel.com>
References: <20220622162230.83474-1-kirill.shutemov@linux.intel.com>
 <20220622162230.83474-4-kirill.shutemov@linux.intel.com>
 <CAG_fn=WgyitSd9h2ni2xpBBvgnoGTcwZOpWyNE5QRSRn+PcC=A@mail.gmail.com>
 <20220706231349.4ghhewbfpzjln56u@black.fi.intel.com>
 <CAG_fn=Ut8OaQ40VmNvG8HtJ7Cb4M03ce3ihFPrmj+PNQB0tF3A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG_fn=Ut8OaQ40VmNvG8HtJ7Cb4M03ce3ihFPrmj+PNQB0tF3A@mail.gmail.com>
Precedence: bulk

On Thu, Jul 07, 2022 at 10:56:53AM +0200, Alexander Potapenko wrote:
> On Thu, Jul 7, 2022 at 1:14 AM Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> >
> > On Tue, Jul 05, 2022 at 05:42:21PM +0200, Alexander Potapenko wrote:
> > > Kirill,
> > >
> > >
> > > > diff --git a/lib/strnlen_user.c b/lib/strnlen_user.c
> > > > index feeb935a2299..abc096a68f05 100644
> > > > --- a/lib/strnlen_user.c
> > > > +++ b/lib/strnlen_user.c
> > > > @@ -97,7 +97,7 @@ long strnlen_user(const char __user *str, long count)
> > > >                 return 0;
> > > >
> > > >         max_addr = TASK_SIZE_MAX;
> > > > -       src_addr = (unsigned long)untagged_addr(str);
> > > > +       src_addr = (unsigned long)untagged_addr(current->mm, str);
> > >
> > > In a downstream kernel with LAM disabled I'm seeing current->mm being
> > > NULL at this point, because strnlen_user() is being called by
> > > kdevtmpfs.
> > > IIUC current->mm is only guaranteed to be non-NULL in the userspace
> > > process context, whereas untagged_addr() may get called in random
> > > places.
> > >
> > > Am I missing something?
> >
> > Hm. Could you show a traceback?
> >
> > As strnlen_user() intended to be used on an user string I expected it to
> > be called from a process context. I guess I'm wrong, but I don't yet
> > understand why.
> 
> Oh, I see now. The old implementation of devtmpfsd()
> (https://elixir.bootlin.com/linux/v5.4/source/drivers/base/devtmpfs.c#L397)
> uses ksys_mount(), which assumes that the strings must be copied from
> the userspace, whereas they are actually constants in kernel .rodata
> 
> Wonder if the validity of mm->current for userspace accesses is
> actually enforced anyhow in newer kernels.

I think it is.

See 967747bbc084 and how it changes strnlen_user(). With max_addr equal to
TASK_SIZE_MAX, strnlen_user() will always fail on a kernel string.

-- 
 Kirill A. Shutemov