Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3671038imw; Thu, 7 Jul 2022 05:54:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uTIEWfVoaFVRH8SX2Qik1jF+eD0qTL4PkCI5EKLVbme8FOLeUINT6voRytaYJ6PfKupjdi X-Received: by 2002:a05:6402:1941:b0:435:5972:7811 with SMTP id f1-20020a056402194100b0043559727811mr61237823edz.234.1657198462626; Thu, 07 Jul 2022 05:54:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657198462; cv=none; d=google.com; s=arc-20160816; b=jGKc/c5vD8Q22uw+vtrLyry6jT5zs0HEGgUIghpnf43US6N4Kq8ldnuWc+yaBJiSXz /4edhxwx1511aQIzayXH741S1pIaGWENoX1cIo/CUMs2AkbMqhsbRjPT7rPmmLwY74hX uvXQqn1miqOMPbXHRWj8lUofrbR/ahhzEq2/9xk0m3DH4HC7po004jMgk03TRceXp+ut JNU8zKVzIGf8K7ZtI2wZh5SSO5YiIRJL2zOMAsK2II+tWh+w2h2desevMmNN+TiuHSJx MegEuAKdBX82k2ky4EKFn0mHdkTCDfH6i6AOiGsbtfVziCv8B+rPt6N0mV38Owtnmiw6 Ammw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=dUmFi8DZaDYcJf12L/Xx0NmEj/l0aTrBYJ3yxA0AGTs=; b=utOpR8TL0JM0qpQr5PTwWsWbcRKoKBLyF/ehlo1dJFw3HSa9rkvvrvKMoXwXH9/CK4 ZpUM5X1x/2tX+foO+kywHwnkF+TquAmB1euRFqpW2/5eXfk8wbO6umU32Wgj2C0K9mlq B9qzqEDl5sLDp3m+YrHK3bPtq4v0s9BNNa/qgKyLCZKrvg2qlwpKyTPNZZL4rIKWdun2 uSnwsA0eBoywQpdOUqT3qihAwhX/VJC4/CBtHkL1SKxyno6rAUxV6xFq4XaYPCl2nmR1 HrD/FnUgNt4P9mUS5TSaoBToE2jjHJXhdXlz/ij7m1aDQtauilsKvz91bi7TSdyTDrVq LUdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TYm9w2Wq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u10-20020a170906408a00b0072af7b45e21si5560027ejj.438.2022.07.07.05.53.56; Thu, 07 Jul 2022 05:54:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TYm9w2Wq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235888AbiGGMxB (ORCPT + 99 others); Thu, 7 Jul 2022 08:53:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235853AbiGGMwp (ORCPT ); Thu, 7 Jul 2022 08:52:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C8DC23136E for ; Thu, 7 Jul 2022 05:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657198353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dUmFi8DZaDYcJf12L/Xx0NmEj/l0aTrBYJ3yxA0AGTs=; b=TYm9w2Wqa5vNOhdSik7C8xsbtahmiledO/OHKsSiqKuY9XT/iAAzwwY5H0RMy2VCdD0PK4 3CmXdonO4Bbrl4jN/ypEwZtANHNR7Uta8z6eBdix0NWZffPFbXKOURnQR3VsoJT6PJssEm Dn69XgOHv2vP/RlVQQyQ2/LQkLG4+Go= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-460-o2jcox1COZ-558705x74gw-1; Thu, 07 Jul 2022 08:52:30 -0400 X-MC-Unique: o2jcox1COZ-558705x74gw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E59A5395AFE3; Thu, 7 Jul 2022 12:52:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C8E62026D64; Thu, 7 Jul 2022 12:52:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20220707045112.10177-1-xiubli@redhat.com> <20220707045112.10177-3-xiubli@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, xiubli@redhat.com, idryomov@gmail.com, marc.dionne@auristor.com, willy@infradead.org, keescook@chromium.org, kirill.shutemov@linux.intel.com, william.kucharski@oracle.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cachefs@redhat.com, vshankar@redhat.com Subject: Re: [PATCH v3 2/2] afs: unlock the folio when vnode is marked deleted MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2433376.1657198347.1@warthog.procyon.org.uk> Date: Thu, 07 Jul 2022 13:52:27 +0100 Message-ID: <2433377.1657198347@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Layton wrote: > > + folio_unlock(*folio); > > + folio_put(*folio); > > Don't you also need this? > > *folio = NULL; It shouldn't need any of those three lines. David