Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3738953imw; Thu, 7 Jul 2022 06:56:56 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vz/aoeiy5AyujVles5Dtw7rVVn6BE8gCDNVefDOjRckAQs2wqQMVoHsTAt2CapOMcuUyM4 X-Received: by 2002:a17:902:ea12:b0:16b:a264:3817 with SMTP id s18-20020a170902ea1200b0016ba2643817mr46763729plg.52.1657202215706; Thu, 07 Jul 2022 06:56:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657202215; cv=none; d=google.com; s=arc-20160816; b=vGBdhso7lo0EDUXQqZKvJc3+3/MCDAYGCkGoyPZB0Vo2pDQRvHVkyUsS1YcbWu4vcF uYB/f1AZlRiTZ7j3OdBpt9TIanosiU5hzf8BfDIgUMPgcwdlh0fx8CLSH0VL4XuMIdBt 5e1UsRS7XSijJjGAgkT69Pb9yKAn0MLcfgs6p2251AM4s5Jt3ltccQHprGf5LmSy3jKG ucqtFjXnllUrGUeWHWCoIzhuAK1+XeY1JW7XWUddpQAbJmQxmh6hb7SqLx6InDPsHXBS EYNTz/1PzbmqA8Ug9N8drUFRacslEGvcj8x1JciDQ05GT2AbN/fsDolY5C8DrSofDV2s H3+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bVv9WQG89TN8juBsNhKtamqi2Z2/Az5uoVuY81G7GUo=; b=q4dF2zDT2YRTsQswe/ZlmFNRWbGDqHnazQCP/iHxKEmLKukoMoXBhlfnYhZThp7Gsu Kk6lqxc9VnkFrWvTs9W9Fmodt+2Clb81ElABS9+maD2zOYclNcU8x0TkxTYJYGcPISjB jAxvQ8YnNq5NsU0YleEexuwK5mZ3xp9aSCqXIKIH+QLz/ZKRAOoRNibB3BRK24MQznr3 27SBLXfvlXzQPwLHRcTTC2wPfDiWoRLFdSaEqT5Mq8UN9ThwfJnejvQpxCznydIKtCEl 3ibTIx46RklZOFqmsZGpl4A+6MF9tPdcuW7MAysiVIuvE6FSQzrkGwd8u+Zwm9bmziFK Sxcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DqNem0BH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t16-20020a634450000000b0040de29fae99si2008007pgk.540.2022.07.07.06.56.41; Thu, 07 Jul 2022 06:56:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DqNem0BH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235847AbiGGN07 (ORCPT + 99 others); Thu, 7 Jul 2022 09:26:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235814AbiGGN06 (ORCPT ); Thu, 7 Jul 2022 09:26:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D28451112; Thu, 7 Jul 2022 06:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bVv9WQG89TN8juBsNhKtamqi2Z2/Az5uoVuY81G7GUo=; b=DqNem0BHBG/Pj0KArFjfNORno1 4HXSgi/mJEhvwepsIyt/Tf9NWOUxQOD3qySP47KqcXtaQAY48vHzI7/BhM4Gn3/L6cZ6KYTWch9F2 jy8sVyPAp7p2dKyzoxCA0x0J+KR1CxeSoRleqhmut/OFYkNQ/yoAf3yXCDzMntuJAq7GNWuuOgC2f MddTPowrGMlGd/mmsE3UPI01Bqkv/mZxXYwxNtdqUijDn577u+QQ/rNL6NGINHZU8Vk2tYgjqZB8y /bJq1lSIvDUHRkuub3en7ww+RHFCMsw5qeh8d1V6XKGjD9KJ3Uv8J3+s5xwdwkCtAQlo88w6x6DAO OXbdXPkQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9RWb-002bGB-Mq; Thu, 07 Jul 2022 13:26:33 +0000 Date: Thu, 7 Jul 2022 14:26:33 +0100 From: Matthew Wilcox To: David Howells Cc: xiubli@redhat.com, idryomov@gmail.com, jlayton@kernel.org, marc.dionne@auristor.com, keescook@chromium.org, kirill.shutemov@linux.intel.com, william.kucharski@oracle.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cachefs@redhat.com, vshankar@redhat.com Subject: Re: [PATCH v4] netfs: do not unlock and put the folio twice Message-ID: References: <20220707045112.10177-1-xiubli@redhat.com> <2520851.1657200105@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2520851.1657200105@warthog.procyon.org.uk> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2022 at 02:21:45PM +0100, David Howells wrote: > - struct folio *folio, void **_fsdata); > + struct folio **_folio, void **_fsdata); The usual convention is that _foo means "Don't touch". This should probably be named "foliop" (ie pointer to a thing that would normally be called folio).