Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220707034143.37991-1-jiahao.os@bytedance.com>
In-Reply-To: <20220707034143.37991-1-jiahao.os@bytedance.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Thu, 7 Jul 2022 16:17:14 +0200
Message-ID: <CAKfTPtAb==WjCpmqOaVdwna6c+yxxskkRKwBKB7_EuJC9SrmJA@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: Remove unused parameter idle of _nohz_idle_balance()
To:     Hao Jia <jiahao.os@bytedance.com>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 7 Jul 2022 at 05:42, Hao Jia <jiahao.os@bytedance.com> wrote:
>
> Since commit 7a82e5f52a35 ("sched/fair: Merge for each idle cpu
> loop of ILB") was merged. The parameter idle of _nohz_idle_balance()

The description of the commit should be in a single line.

commit 7a82e5f52a35 ("sched/fair: Merge for each idle cpu loop of ILB")

> is not used anymore so we can remove it.
>
> Signed-off-by: Hao Jia <jiahao.os@bytedance.com>

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  kernel/sched/fair.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 77b2048a9326..8d4be2a95e37 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -10682,8 +10682,7 @@ static bool update_nohz_stats(struct rq *rq)
>   * can be a simple update of blocked load or a complete load balance with
>   * tasks movement depending of flags.
>   */
> -static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags,
> -                              enum cpu_idle_type idle)
> +static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags)
>  {
>         /* Earliest time when we have to do rebalance again */
>         unsigned long now = jiffies;
> @@ -10798,7 +10797,7 @@ static bool nohz_idle_balance(struct rq *this_rq, enum cpu_idle_type idle)
>         if (idle != CPU_IDLE)
>                 return false;
>
> -       _nohz_idle_balance(this_rq, flags, idle);
> +       _nohz_idle_balance(this_rq, flags);
>
>         return true;
>  }
> @@ -10818,7 +10817,7 @@ void nohz_run_idle_balance(int cpu)
>          * (ie NOHZ_STATS_KICK set) and will do the same.
>          */
>         if ((flags == NOHZ_NEWILB_KICK) && !need_resched())
> -               _nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK, CPU_IDLE);
> +               _nohz_idle_balance(cpu_rq(cpu), NOHZ_STATS_KICK);
>  }
>
>  static void nohz_newidle_balance(struct rq *this_rq)
> --
> 2.32.0
>