Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1d0fec7d-ed83-e1ff-92a1-e721bcc50298@kernel.org>
Date:   Thu, 7 Jul 2022 17:29:16 +0300
MIME-Version: 1.0
Subject: Re: [PATCH v4 4/5] interconnect: qcom: icc-rpm: Support multiple
 buckets
Content-Language: en-US
To:     Leo Yan <leo.yan@linaro.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220705072336.742703-1-leo.yan@linaro.org>
 <20220705072336.742703-5-leo.yan@linaro.org>
From:   Georgi Djakov <djakov@kernel.org>
In-Reply-To: <20220705072336.742703-5-leo.yan@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5.07.22 10:23, Leo Yan wrote:
> The current interconnect rpm driver uses a single aggregate bandwidth to
> calculate the clock rates for both active and sleep clocks; therefore,
> it has no chance to separate bandwidth requests for these two kinds of
> clocks.
> 
> This patch studies the implementation from interconnect rpmh driver to
> support multiple buckets.  The rpmh driver provides three buckets for
> AMC, WAKE, and SLEEP; this driver only needs to use WAKE and SLEEP
> buckets, but we keep the same way with rpmh driver, this can allow us to
> reuse the DT binding and avoid to define duplicated data structures.
> 
> This patch introduces two callbacks: qcom_icc_pre_bw_aggregate() is used
> to clean up bucket values before aggregate bandwidth requests, and
> qcom_icc_bw_aggregate() is to aggregate bandwidth for buckets.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
>   drivers/interconnect/qcom/icc-rpm.c | 51 ++++++++++++++++++++++++++++-
>   drivers/interconnect/qcom/icc-rpm.h |  6 ++++
>   2 files changed, 56 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index 8c9d5cc7276c..b025fc6b97c9 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -254,6 +254,54 @@ static int __qcom_icc_set(struct icc_node *n, struct qcom_icc_node *qn,
>   	return 0;
>   }
>   
> +/**
> + * qcom_icc_rpm_pre_bw_aggregate - cleans up values before re-aggregate requests

This does not match with the name of the function below.

> + * @node: icc node to operate on
> + */
> +static void qcom_icc_pre_bw_aggregate(struct icc_node *node)
> +{
> +	struct qcom_icc_node *qn;
> +	size_t i;
> +
> +	qn = node->data;
> +	for (i = 0; i < QCOM_ICC_NUM_BUCKETS; i++) {
> +		qn->sum_avg[i] = 0;
> +		qn->max_peak[i] = 0;
> +	}
> +}
> +
[..]
Thanks,
Georgi