Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAK8P3a12-atmqjtjqi-RhFXH2Kwa-hxYcxy3Ftz2YjY5yyPHqg@mail.gmail.com>
 <mhng-f5938c9b-7fc1-4b0c-9449-7dd1431f5446@palmerdabbelt-glaptop>
 <CAKXUXMzpWsdKYbcu5MxvrAEMLHv4_2OGv2bRYEsQaze5trUSiQ@mail.gmail.com>
 <CAK8P3a32m42gT9qz+Ldvr8okYGOc=kKeoJTGNWyYT71N8tJfEA@mail.gmail.com>
 <4ff47e50-8702-1177-612b-73d9700e47c5@microchip.com> <CAK8P3a01x_ETchX2Vwm9oNaFJDhVZEu+G-2vRwegqKkMe54m6g@mail.gmail.com>
In-Reply-To: <CAK8P3a01x_ETchX2Vwm9oNaFJDhVZEu+G-2vRwegqKkMe54m6g@mail.gmail.com>
From:   Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date:   Thu, 7 Jul 2022 16:41:17 +0200
Message-ID: <CAKXUXMxOUs31SkGb0JD=nmHxgFy4tQ5vn6yD6ivgRpbSAxm7mA@mail.gmail.com>
Subject: Re: [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Conor Dooley <Conor.Dooley@microchip.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Palmer Dabbelt <palmerdabbelt@google.com>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 7, 2022 at 3:07 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Jul 7, 2022 at 2:20 PM <Conor.Dooley@microchip.com> wrote:
> > On 07/07/2022 13:13, Arnd Bergmann wrote:
> > > On Thu, Jul 7, 2022 at 1:40 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > >>
> > >> On Wed, Oct 6, 2021 at 6:52 PM Palmer Dabbelt <palmerdabbelt@google.com> wrote:
> > >>>
> > >>> On Wed, 06 Oct 2021 08:17:38 PDT (-0700), Arnd Bergmann wrote:
> > >>>> On Wed, Oct 6, 2021 at 5:00 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > >>>>>
> > >>>>> Commit 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
> > >>>>> introduces the config symbol GENERIC_LIB_DEVMEM_IS_ALLOWED, but then
> > >>>>> falsely refers to CONFIG_GENERIC_DEVMEM_IS_ALLOWED (note the missing LIB
> > >>>>> in the reference) in ./include/asm-generic/io.h.
> > >>>>>
> > >>>>> Luckily, ./scripts/checkkconfigsymbols.py warns on non-existing configs:
> > >>>>>
> > >>>>> GENERIC_DEVMEM_IS_ALLOWED
> > >>>>> Referencing files: include/asm-generic/io.h
> > >>>>>
> > >>>>> Correct the name of the config to the intended one.
> > >>>>>
> > >>>>> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
> > >>>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > >>>>
> > >>>> Acked-by: Arnd Bergmann <arnd@arndb.de>
> > >>>
> > >>> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
> > >>> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
> > >>>
> > >>> Thanks.  I'm going to assume this is going in through some other tree,
> > >>> but IIUC I sent the buggy patch up so LMK if you're expecting it to go
> > >>> through mine.
> > >>
> > >> Palmer, Arnd,
> > >>
> > >> the patch in this mail thread got lost and was not picked up yet.
> > >>
> > >> MAINTAINERS suggests that Arnd takes patches to include/asm-generic/,
> > >> since commit 1527aab617af ("asm-generic: list Arnd as asm-generic
> > >> maintainer") in 2009, but maybe the responsibility for those files has
> > >> actually moved on to somebody (or nobody) else and we just did not
> > >> record that yet in MAINTAINERS.
> > >>
> > >> Arnd, will you pick this patch and provide it further to Linus Torvalds?
> > >>
> > >> Otherwise, Palmer already suggested picking it up himself.
> > >>
> > >
> > > I've applied it to the asm-generic tree and can send it as a bugfix
> > > pull request. I don't have any other fixer for that branch at the moment,
> > > so if Palmer has other fixes for the riscv tree already, it would
> > > save me making a pull request if he picks it up there.
>
> lkft just found a build failure:
>
> https://gitlab.com/Linaro/lkft/users/arnd.bergmann/asm-generic/-/jobs/2691154818
>
> I have not investigated what went wrong, but it does look like an actual
> regression, so I'll wait for Lukas to follow up with a new version of the patch.

Thanks for your testing. I will look into it. Probably it is due to
some more rigor during builds (-Werror and new warning types in the
default build) since I proposed the patch in October 2021. That should
be easy to fix, but let us see. I will send a PATCH v2 soon.

Lukas