Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 3/3] ASoC: amd: acp: Add legacy audio driver support for
 Rembrandt platform
To:     Randy Dunlap <rdunlap@infradead.org>, broonie@kernel.org,
        alsa-devel@alsa-project.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, venkataprasad.potturu@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Arnd Bergmann <arnd@arndb.de>,
        Akihiko Odaki <akihiko.odaki@gmail.com>,
        Jia-Ju Bai <baijiaju1990@gmail.com>,
        Syed Saba kareem <ssabakar@amd.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Meng Tang <tangmeng@uniontech.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220624194821.287462-1-Vsujithkumar.Reddy@amd.com>
 <20220624194821.287462-4-Vsujithkumar.Reddy@amd.com>
 <6a210c39-2a04-2d39-9d5f-51b4e777b81d@infradead.org>
From:   "Reddy, V sujith kumar" <vsujithkumar.reddy@amd.com>
Message-ID: <472517b9-523e-36a2-9f00-e718ba0708f3@amd.com>
Date:   Thu, 7 Jul 2022 21:35:52 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <6a210c39-2a04-2d39-9d5f-51b4e777b81d@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3UvZkYxY3hMdUxnQ29vcUVkR1NyeGNDNHAzejN0TkxlVTF2QkdoRjJySTh6?=
 =?utf-8?B?VW85bTdTanMwSjcreDZDRXNKYjlpdDI5UHNEZUoxRmFtaDBHS3l0dFpvRHZl?=
 =?utf-8?B?WHhqWlVRbE95ZVJuaTUxRU1XR1drckl5eFh6Wm9kNVM1WndzUzRKT28wNkF0?=
 =?utf-8?B?M2h2NmorUlN4aTdqTnprSzlyb05oWkNseXNsYWJacUhXc1F4YTNzcVBQejZR?=
 =?utf-8?B?dWk3bWZDSDk1R2VScXFJS1lYMVE4UEY4bmQwQXdRWGlwNWpJcmFNOWRETWZ3?=
 =?utf-8?B?bEVNNWY5eVpCOGhuenpINGRUMk40UU5YbGZHc2hCRGNpS0RqWktVdmN5a1lr?=
 =?utf-8?B?K1owMVcxQnVuQTNyaTFWeXFkbTBlRExZTE0rVzlocWh3VzYyTzBqSkJycVln?=
 =?utf-8?B?eVRwWjRPZmNzdHFnLzFKeTVDVlZIWlFSOXk0cUxnZFhHcmtMZ250ZmJzNFBI?=
 =?utf-8?B?SSsramRtd1hhK0dwb2lPbXFDUDFHQWw0NzhxWnN1UFVZVUIxVFYyN1Qvbk44?=
 =?utf-8?B?aFd3STlSdXg5a0JRZlJkL296SE5jYzVRNm9QOHgzMDBpNU9ZSHNhd25wNlBv?=
 =?utf-8?B?anV0cW51K2svVzNlMUJWQkVQemV2OTBTblhiQjN3ajYvdVZ1WXdQd2lPSFVU?=
 =?utf-8?B?RU1KZHRzR0dSeFJRMnFzZUJhU1o2b016SElCakFYTVpHUVlhdFR6UUpXK0lw?=
 =?utf-8?B?MHZmR2N5Nmt2dzlaUlhKaWNZNGRVVUhLVXJUczZ3dHFrYWFERTdjeDkrQmtt?=
 =?utf-8?B?TkZkQXJVY3RBL2oyb0NhRGZOU25pRUxpUWZsU3VHRjBpSmNPb1JqV21xbW9j?=
 =?utf-8?B?ak82NmxVRUxCVWg4amRlT0s1b01LSTlxbHBibVVDN0pQOTJ3akNNa2ljZnF2?=
 =?utf-8?B?dk1pd3BPcnpyeXhVb053bkxSblpkZFhMWnVZbUxCQzhWTmtZTFhya0hzWWJj?=
 =?utf-8?B?SDByNG1pVXUxT1JsZnJqWXZjemdKL1VMSGxFekVRajBvRXFMZmJQZlBkV01s?=
 =?utf-8?B?bXhXU293MWUyLzdEckVIZ1JNazAvaUs4bnBEL0ZSUUNLK1ZTTkhUbjdRZldT?=
 =?utf-8?B?bzBBc3J1cmowbGxGM1JFejhMc090ZmhWd3RBZm9VRnN4RVE4dUZHaWllYzN3?=
 =?utf-8?B?b0RRRGRzbHVvWVQrQzBLWnYvWnZLeXpXRjEreHp1alo2b0xQTjFDdmVtRi9K?=
 =?utf-8?B?ZUQyQXVRTmlEcjNUZTNTQlUvUVFycFUzc1htMnZhQ3hUYU9sMzdpekxqYVI5?=
 =?utf-8?B?SWdZNEMyem1kZHNYd2hSWFFRejRpcCtGdkxGYitOTFFQcktMQ3M0MFNUM3J0?=
 =?utf-8?B?Y0VpZ3R4RWFxazVicFBSTmZySXFJQ2JHYUtiN00rZSsvdnJvNFRKUjNkR2hl?=
 =?utf-8?B?VG9NOGhUVGN2K1JlN1NSdXA1bzZKMW5mUnBSY0hLSXRRWlZ1M0N1bjFrV1V0?=
 =?utf-8?B?ckZUSXVVTkRLTG5hbXgyQ3lYSlR1UTR1Rm9VazBMZVRDdUdFZlJvSVI1YllW?=
 =?utf-8?B?RHVQNmc1WFlqSk42NlVNQ3FRRTBZUVFVcnptWVR3bTlUZ28rUExDc2R4cVRJ?=
 =?utf-8?B?dmNpRFl6R3k1cDRqRjIrZ2FZTVlkN1prZlR6Y3JSZ1EvVkhqc3hWYkpTcFRj?=
 =?utf-8?B?VTZRTFpSTStldHIyN252QzJ2cjNQb3hmYjlCT3FMcExvZW53QXNiUVZ3SVYw?=
 =?utf-8?B?MUJQZjJ3THhpTzAvTnFPM2NBRktRaHhmVllZRVNVY1RvUmRjMXdyRzQrcVpC?=
 =?utf-8?B?ZndhTzBvUHladld6TDBQcTZhRmE5andSVHUrSXNMT3ROMys0aVpQa0JCYk1u?=
 =?utf-8?B?MllQZFFLYUJ3RThwSjQ5UjFod1JNRi85MW1sR3F6VmE2OEI5K2VjWVlyMzlh?=
 =?utf-8?B?TjYrYnRXWjBQekp0eUdsdUdVdk50TmptVENNZXE1RmhIY01paURsRGJ2cGlh?=
 =?utf-8?B?MUdzL2crcFp5bDJRUWd5YmxyajRVYXYvb0RtRzlCL3FPMjZFU1dkdFRuRGZP?=
 =?utf-8?B?QTRRK3FLYUhSelpjZloxejFPVlREVktveG4vdE16ckdyR3VtcFFnY3d4eWZU?=
 =?utf-8?B?ejZCTkdDVG9ybTJ5OW5GdEJqZ01pQjcrWXloaDVpT3FRV2tQbnRuZCtSRjVN?=
 =?utf-8?Q?vWf83GbNmrLkMEM5iO0D9Juv+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa8d97c9-6273-4aa5-eac4-08da6032997f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4171.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 16:06:06.8005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pfuHtivNQmKOYWionh0sLZBaAUaH4/43B726NIbzKPpWv/UjJpSkJme8KD7XL3ng
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3267
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/25/2022 4:34 AM, Randy Dunlap wrote:
> [CAUTION: External Email]
>
> Hi--
>
> On 6/24/22 12:48, V sujith kumar Reddy wrote:
>> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
>> index 7e56d2644105..abc089f38b6c 100644
>> --- a/sound/soc/amd/acp/Kconfig
>> +++ b/sound/soc/amd/acp/Kconfig
>> @@ -40,6 +40,17 @@ config SND_AMD_ASOC_RENOIR
>>        help
>>          This option enables Renoir I2S support on AMD platform.
>>
>> +config SND_AMD_ASOC_REMBRANDT
>> +        tristate "AMD ACP ASOC Rembrandt Support"
>> +        select SND_SOC_AMD_ACP_PCM
>> +        select SND_SOC_AMD_ACP_I2S
>> +        select SND_SOC_AMD_ACP_PDM
>> +        depends on X86 && PCI
>> +        help
>> +          This option enables Rembrandt I2S support on AMD platform.
>> +       Say Y if you want to enable AUDIO on Rembrandt
>> +       If unsure select "N".
>
Done
> Documentation/process/coding-style.rst says:
>
> 10) Kconfig configuration files
> -------------------------------
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different.  Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>
>
> so please indent as expected, and consistently.
>
> --
> ~Randy