Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3897974imw; Thu, 7 Jul 2022 09:14:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sGWqqy5i8yemenQCwlv/+9EQ2jOUw/OsszEafUyvUwou2r2wG88RJ9MpJRj/e2gD80qd9R X-Received: by 2002:a17:907:6eac:b0:72a:fb80:d39 with SMTP id sh44-20020a1709076eac00b0072afb800d39mr8223691ejc.536.1657210475396; Thu, 07 Jul 2022 09:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657210475; cv=none; d=google.com; s=arc-20160816; b=u9OBGNS0NukIGmJlHRH6IQdzHPNRFMSDucEFt/BdF4Jp4BN2O4tPapAVNgtdmRbX7E kAzj9zZRrFu0oWa4jhCbdqnzmPH4JGCZyJDTR3CwF0cYtVL5DPSJoKFWpK+4EhC3IELQ EodCpiAGeRq5P5oYDXgURgmquIac02NPjZ8w1o65CyoytVd2ZqCuYb8MnC8xkt5eWeJG XYJN5sWwBsrlRm8RgidNvDsDkzktp4Yr3UQV4/NBx7O0RJ2uNOs1FEnDfK4mjc6TH177 zoDejcKiRMaZt++BKvCDHHDcW4TYh/F5YWIXnSwxsLIwTLcVbfd+UPXOY//zBvy+spAS 8IOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=zSICPVFeoGuXrSUUGgngblxqjcM4vvGDmp0pX37kGv4=; b=ULxD0hGE208FeCWsjeDn+I9+lEQSBGF7N3NbP/bCAr9I5cj3vCXImM4WERMf7047L1 X+6G3jfqIFouh7tdNZS67CtTMQiZuUtFfqBuwX1DgQaULvh0mR3KmCBGpS09AyZwEuFV I2Oi1QEU1Thu7XsB0Xpk/12VoMdhCJrHl3J6gu+fhvDin1CxlJYRu1lC/RaBKL48EMEJ eQDgACa0H3W0JAtboi+NpvH4cjXr9OTBYpZmgm//QkK1YI0WI1KYJDL/X5pKpUZdtEv1 QGx4Kvz+km0Prv/tffjJWyssEt1cPhNJf942PUEIx0aDVW3yU4FoZSyfFWe0iVlgdo95 pLpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=wANNrb18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr20-20020a1709073f9400b00726a5db994bsi2757536ejc.477.2022.07.07.09.14.09; Thu, 07 Jul 2022 09:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=wANNrb18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235894AbiGGQMn (ORCPT + 99 others); Thu, 7 Jul 2022 12:12:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235884AbiGGQMC (ORCPT ); Thu, 7 Jul 2022 12:12:02 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8130A4D169; Thu, 7 Jul 2022 09:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657210295; x=1688746295; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=zSICPVFeoGuXrSUUGgngblxqjcM4vvGDmp0pX37kGv4=; b=wANNrb18x4qEDxnUOGAYmpYLKOHYio3tAan8POfeQrfAcjg0dNnbM/29 DgJYSvmnvPzAxAPUUakMyPDpRF02RSDCr7uYc1gET6z5AKf+r1hVgncgv 6LLinRtJdtHhpXiyTPClL0f0j3SK6xX6+ua0woCuk7mitz0C5OL7lFIl6 s=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 07 Jul 2022 09:11:35 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 09:11:35 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 7 Jul 2022 09:11:34 -0700 Received: from hyd-lnxbld559.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 7 Jul 2022 09:11:29 -0700 From: Akhil P Oommen To: freedreno , , , Rob Clark , Bjorn Andersson CC: Jordan Crouse , Douglas Anderson , Matthias Kaehlcke , Jonathan Marek , Akhil P Oommen , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Sean Paul , Subject: [PATCH 1/7] drm/msm: Remove unnecessary pm_runtime_get/put Date: Thu, 7 Jul 2022 21:40:56 +0530 Message-ID: <20220707213950.1.Icf1e8f0c9b3e7e9933c3b48c70477d0582f3243f@changeid> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1657210262-17166-1-git-send-email-quic_akhilpo@quicinc.com> References: <1657210262-17166-1-git-send-email-quic_akhilpo@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We already enable gpu power from msm_gpu_submit(), so avoid a duplicate pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/msm_ringbuffer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c index 4306632..82bee84 100644 --- a/drivers/gpu/drm/msm/msm_ringbuffer.c +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c @@ -29,8 +29,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) msm_gem_unlock(obj); } - pm_runtime_get_sync(&gpu->pdev->dev); - /* TODO move submit path over to using a per-ring lock.. */ mutex_lock(&gpu->lock); @@ -38,8 +36,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) mutex_unlock(&gpu->lock); - pm_runtime_put(&gpu->pdev->dev); - return dma_fence_get(submit->hw_fence); } -- 2.7.4