Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387AbXE3Pc4 (ORCPT ); Wed, 30 May 2007 11:32:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752451AbXE3Pcs (ORCPT ); Wed, 30 May 2007 11:32:48 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:40526 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbXE3Pcr (ORCPT ); Wed, 30 May 2007 11:32:47 -0400 Message-ID: <465D9933.2000209@oracle.com> Date: Wed, 30 May 2007 08:33:07 -0700 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Jan Engelhardt CC: Andy Whitcroft , Andi Kleen , Andrew Morton , Randy Dunlap , Joel Schopp , linux-kernel@vger.kernel.org Subject: Re: [PATCH] add a trivial patch style checker References: <9a1288909c10f2935af82ec5cea0c46b@pinky> <465BECCC.5030001@shadowen.org> <20070529153651.d65fa07c.randy.dunlap@oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 31 Jan Engelhardt wrote: > On May 29 2007 15:36, Randy Dunlap wrote: >>>>>> + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){ >>>>>> + print "Gotos should not be indented\n"; >>>>>> + print "$herecurr"; >>>>>> + $clean = 0; >>>>>> + } >>>>> emacs generates one space label in front of a goto label. I wouldn't >>>>> outlaw this. >>>> Yep, we also now allow one space something to do with diff -p not >>>> getting confused... >>> Not only diff and emacs. At least joe (joe.sf.net) is another editor > [...] >> That's just a joe bug then. >> >> diff no longer requires a beginning space, at least in the testing >> that I did it worked with no leading space on a label:. > > But not everyone runs the latest and greatest. diffutils 2.8.7 > takes /^label:/ as a marker for the @@ line. OK. What does "marker for the @@ line" mean? -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/