Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan McDowell <noodles@fb.com>
To:     Dave Hansen <dave.hansen@linux.intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mimi Zohar <zohar@linux.ibm.com>, Baoquan He <bhe@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [tip: x86/boot] x86/kexec: Carry forward IMA measurement log on
 kexec
Thread-Topic: [tip: x86/boot] x86/kexec: Carry forward IMA measurement log on
 kexec
Thread-Index: AQHYkiH4JPbBMg4J5U2KvaHM6yRn+q1zK2uA
Date:   Thu, 7 Jul 2022 17:37:20 +0000
Message-ID: <YscZM+N77zUb1uam@noodles-fedora.dhcp.thefacebook.com>
References: <YmKyvlF3my1yWTvK@noodles-fedora-PC23Y6EG>
 <165721275237.15455.6157055713679490274.tip-bot2@tip-bot2>
In-Reply-To: <165721275237.15455.6157055713679490274.tip-bot2@tip-bot2>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lI1DuchM/7UsQVHHdjt3zKnspYJiJ2Gesyd9fSbtQF2gQtGYlN5q8Ww/Epv7?=
 =?us-ascii?Q?7debk8e+FnJehNvAm26ybC5F9OE3rCyahUvER7QmnI40wxAd9qHb/oizsrtk?=
 =?us-ascii?Q?rmRy5q/21fizTOiaPpkU1uVEJM8HDFDfVzJcr8jKRKhUDJ5h9nyGWsmy/cnY?=
 =?us-ascii?Q?v0ENN+H/mpeUuC3RBmhpdUB9lmoCbZ4UILioYqN8PvPAoBDmc49rxY1xVAA6?=
 =?us-ascii?Q?gaMKe9ofcxw+0LynQLfO5/ZJDn7T34xHd71vEZDy/Agh83fw8gaK0okExdKt?=
 =?us-ascii?Q?k+/ZbTuUp5ygEQetupLONZQa/DORkB9MeYzLPepIUbJMRKgswuvYtf7CsLWh?=
 =?us-ascii?Q?AnQq2a+5Jnw4GsbOIBapUjDgbTkhjXELTQGM/Rb2eMfnDUR64BqUsqIgGCf2?=
 =?us-ascii?Q?X+2QjAG9kHHKwD5GW3omft7jYiqeKmCNco/5J7htOlDgkFJAcbqjFmNv5Gm3?=
 =?us-ascii?Q?QXMgiDk0ysndYDJB/fupCqClRV+1S4/zg9iwRLTB/cfr3deN9ar9hG8k457A?=
 =?us-ascii?Q?DOopkHYx9RE0NVmzcNPI3vzh2NxQ0kunMr1ZHV1DlOmkLVcjSoqwSTAPKV1t?=
 =?us-ascii?Q?jqnAXu6Wgp683AGd/Ooq3qfwxOEmU7/zz0PQaX85QhAco4axA9E8bjiAk+Ls?=
 =?us-ascii?Q?WOD8emj6+VWrCp+LAEsUxUCJAuhu5ggXZGi9KUuyXE27dkJK2fps/aqyqW9J?=
 =?us-ascii?Q?Cb8BrmhA/+4zJqh2X5Opi3LFXUehq0AMxb6kqgKzXj4UMNA6xmeZt6xSl0VJ?=
 =?us-ascii?Q?EQp5DAgg8G7jnC4HdNKljCakj/1wmCZZH7hmgZxLqGXeFnJVfsMOmUEDwm7u?=
 =?us-ascii?Q?8p7Svw5r3VkPDyWCAB+4EY+C7BDwjz5lZXmZJ6W/7hKKpjh860xKZT0Auy3o?=
 =?us-ascii?Q?uui8d0BEyjmDf6A0f6Z8OKz8hip/Ewn40umBH0KySEm4IWgZzSmDIrZ15IU3?=
 =?us-ascii?Q?S5OMjl/KzpMDPARvN1M1A7Y+kAmhKuqSaJneb1tKtrpGmeiqySFwMcLc+mCl?=
 =?us-ascii?Q?uRNn89Xhbi/pVMeBoCGYclXIgjQkJB8BevjnYHSLtcF+vWhiYHx91L1SgznF?=
 =?us-ascii?Q?nFud3ZNyWmbC61Bq2bkjvHGtOZhlenZfIEwUMkrJe3JUc1vMrl0T78pF9+H1?=
 =?us-ascii?Q?oBaih8lDrW6hj/pUth57AGPpkntZtudR3VKdbyPOfQFI6SDrJLzt86KMmJav?=
 =?us-ascii?Q?k000RXjhSqQ5vNsNXDzKXWggcX0ZZa58GkSTHyJkR0+EXsJ53uLn/EAeGcdP?=
 =?us-ascii?Q?aV0lx7MRi+SAOvos1iAs8VJUDNPxyfV5D7c9qOuXyV7kce9og7BxUu5qMY5T?=
 =?us-ascii?Q?806qhxHE1FNlZ/0KReBKH5JQYLNx61cjaNkZXfXKTzqBSS3ZhHWybIl/nNGi?=
 =?us-ascii?Q?FV8N2Dg9J94eOslPmvDVXO3vyzuri2IjpcyCtdmMcXj91J5mp0o+Hr2MBs+F?=
 =?us-ascii?Q?9UxzbOFq39l9IhZ8ZyQxCDgGS03qPbhWJ0z7bjUJUdTe+ld5jzKLtaDKu/Y7?=
 =?us-ascii?Q?yMhN7cBnARkN3JaXhLuaMLynowoX81J7tBL1JBXjUsWeFP5KmnujNY5+lx3+?=
 =?us-ascii?Q?5gHVN/oCEy+gbtF0IAm1XyPu6ff1d7iA29h81Bwe?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F8DEE30D5895C044AEC61F33F262535C@namprd15.prod.outlook.com>
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR15MB4552.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a482d8e5-3328-4e2e-ca66-08da603f587d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 17:37:20.9878
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: anqaa9NbLem/Hx6PM+fd5KliRhAqtedJFGBdXG/Lr9FE2ZNk0/xdrF27JDTfpB1w
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB3626
X-Proofpoint-ORIG-GUID: bBMCcBTbcXG5Cnv_oI8zu-g2iOFZHnY4
X-Proofpoint-GUID: bBMCcBTbcXG5Cnv_oI8zu-g2iOFZHnY4
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-07_13,2022-06-28_01,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2022 at 04:52:32PM -0000, tip-bot2 for Jonathan McDowell wrote:
> The following commit has been merged into the x86/boot branch of tip:

Just to clarify there's not some confusion going on; this is already in
-next via tip/master via tip/x86/kdump.

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/kdump&id=b69a2afd5afce9bf6d56e349d6ab592c916e20f2

> Commit-ID:     2faaa8f3ef16d794ecb28f9a7d9dca25cff98bb3
> Gitweb:        https://git.kernel.org/tip/2faaa8f3ef16d794ecb28f9a7d9dca25cff98bb3
> Author:        Jonathan McDowell <noodles@fb.com>
> AuthorDate:    Thu, 30 Jun 2022 08:36:12 
> Committer:     Dave Hansen <dave.hansen@linux.intel.com>
> CommitterDate: Wed, 06 Jul 2022 15:45:55 -07:00
> 
> x86/kexec: Carry forward IMA measurement log on kexec
> 
> On kexec file load, the Integrity Measurement Architecture (IMA)
> subsystem may verify the IMA signature of the kernel and initramfs, and
> measure it. The command line parameters passed to the kernel in the
> kexec call may also be measured by IMA.
> 
> A remote attestation service can verify a TPM quote based on the TPM
> event log, the IMA measurement list and the TPM PCR data. This can
> be achieved only if the IMA measurement log is carried over from the
> current kernel to the next kernel across the kexec call.
> 
> PowerPC and ARM64 both achieve this using device tree with a
> "linux,ima-kexec-buffer" node. x86 platforms generally don't make use of
> device tree, so use the setup_data mechanism to pass the IMA buffer to
> the new kernel.
> 
> (Mimi, Baoquan, I haven't included your reviewed-bys because this has
>  changed the section annotations to __init and Boris reasonably enough
>  wants to make sure IMA folk are happy before taking this update.)
> 
> Signed-off-by: Jonathan McDowell <noodles@fb.com>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> # IMA function
> Reviewed-by: Baoquan He <bhe@redhat.com>
> Link: https://lore.kernel.org/r/YmKyvlF3my1yWTvK@noodles-fedora-PC23Y6EG
> Link: https://lkml.kernel.org/r/Yr1geLyslnjKck86@noodles-fedora.dhcp.thefacebook.com