Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220707013812.64057-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20220707013812.64057-1-yang.lee@linux.alibaba.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 7 Jul 2022 14:17:26 -0400
Message-ID: <CADnq5_Pe_bOh_=oFFu=zhyR=kXNrcVjwFLj0T5zrtwX_ntpTyw@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amd/display: clean up some inconsistent indenting
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     "Deucher, Alexander" <alexander.deucher@amd.com>,
        "Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
        xinhui pan <Xinhui.Pan@amd.com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Dave Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Christian Koenig <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Jul 6, 2022 at 9:38 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Eliminate the follow smatch warnings:
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:405 get_bios_object_from_path_v3() warn: inconsistent indenting
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:611 bios_parser_get_hpd_info() warn: inconsistent indenting
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:818 bios_parser_get_device_tag() warn: inconsistent indenting
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1599 bios_parser_is_device_id_supported() warn: inconsistent indenting
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  .../gpu/drm/amd/display/dc/bios/bios_parser2.c   | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> index c332650b7048..6f514d92b401 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> @@ -402,7 +402,7 @@ static struct atom_display_object_path_v3 *get_bios_object_from_path_v3(
>                 return NULL;
>         }
>
> -    return NULL;
> +       return NULL;
>  }
>
>  static enum bp_result bios_parser_get_i2c_info(struct dc_bios *dcb,
> @@ -605,8 +605,8 @@ static enum bp_result bios_parser_get_hpd_info(
>             default:
>                 object = get_bios_object(bp, id);
>
> -                       if (!object)
> -                               return BP_RESULT_BADINPUT;
> +               if (!object)
> +                       return BP_RESULT_BADINPUT;
>
>                 record = get_hpd_record(bp, object);
>
> @@ -810,10 +810,10 @@ static enum bp_result bios_parser_get_device_tag(
>                 /* getBiosObject will return MXM object */
>                 object = get_bios_object(bp, connector_object_id);
>
> -                       if (!object) {
> -                               BREAK_TO_DEBUGGER(); /* Invalid object id */
> -                               return BP_RESULT_BADINPUT;
> -                       }
> +               if (!object) {
> +                       BREAK_TO_DEBUGGER(); /* Invalid object id */
> +                       return BP_RESULT_BADINPUT;
> +               }
>
>                 info->acpi_device = 0; /* BIOS no longer provides this */
>                 info->dev_id = device_type_from_device_id(object->device_tag);
> @@ -1596,7 +1596,7 @@ static bool bios_parser_is_device_id_supported(
>                         break;
>         }
>
> -    return false;
> +       return false;
>  }
>
>  static uint32_t bios_parser_get_ss_entry_number(
> --
> 2.20.1.7.g153144c
>