Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <37298477-b25d-ce84-67eb-091f6e0e5f73@gmail.com>
Date:   Fri, 8 Jul 2022 04:13:19 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v1] PM / devfreq: tegra30: Add error message for
 devm_devfreq_add_device()
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
Cc:     linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220630075751.1360786-1-dmitry.osipenko@collabora.com>
From:   Chanwoo Choi <cwchoi00@gmail.com>
In-Reply-To: <20220630075751.1360786-1-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22. 6. 30. 16:57, Dmitry Osipenko wrote:
> It's difficult to notice that driver failed to probe by looking at KMSG
> when devm_devfreq_add_device() fails. Add explicit error message for this
> case.
> 
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
>  drivers/devfreq/tegra30-devfreq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 30382bdfc655..f0d414b881e3 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -926,8 +926,10 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>  
>  	devfreq = devm_devfreq_add_device(&pdev->dev, &tegra_devfreq_profile,
>  					  "tegra_actmon", NULL);
> -	if (IS_ERR(devfreq))
> +	if (IS_ERR(devfreq)) {
> +		dev_err(&pdev->dev, "Failed to add device: %pe\n", devfreq);
>  		return PTR_ERR(devfreq);
> +	}
>  
>  	return 0;
>  }

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi