Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 7 Jul 2022 19:56:19 +0100
From:   Aaron Tomlin <atomlin@atomlin.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     Aaron Tomlin <atomlin@redhat.com>, rostedt@goodmis.org,
        cl@linux.com, pmladek@suse.com, mbenes@suse.cz,
        christophe.leroy@csgroup.eu, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
        ghalat@redhat.com, oleksandr@natalenko.name, neelx@redhat.com,
        daniel.thompson@linaro.org, hch@infradead.org, tglx@linutronix.de,
        linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2] module: kallsyms: Ensure preemption in add_kallsyms()
 with PREEMPT_RT
Message-ID: <20220707185619.sryhytlfkolmklnn@ava.usersys.com>
References: <20220704161753.4033684-1-atomlin@redhat.com>
 <YsXNVSAtO+VDggcI@bombadil.infradead.org>
 <20220707165750.tk4fadpv3d4zr2mb@ava.usersys.com>
 <YscV7ujYs6Q60N+E@bombadil.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YscV7ujYs6Q60N+E@bombadil.infradead.org>
Precedence: bulk

On Thu 2022-07-07 10:20 -0700, Luis Chamberlain wrote:
> This is incredibly important information which should be added to the
> commit log, specialy as PREEMPT_RT=y becomes a first class citizen.

Understood.

> 
> > So, I would say this was a regression since earlier preemption was
> > not disabled and we would dereference RCU-protected pointers explicitly
> > i.e. without using the more appropriate rcu_dereference() family
> > of primitives. That being said, these pointers cannot change in this
> > context as explained previously.
> > 
> > Would the above be suitable - just to confirm before I send another
> > iteration?
> 
> Yes, I would send this to Linus for the rc series. Please adjust the
> commit log with all this information.

Will do.

> BTW I think there is just one more fix pending from you right?

Yes - I will send/or prepare it as a partial revert:
's/strscpy/strlcpy/' with a brief explanation.


Kind regards,

-- 
Aaron Tomlin