Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 7 Jul 2022 16:22:10 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "hca@linux.ibm.com" <hca@linux.ibm.com>,
        "gor@linux.ibm.com" <gor@linux.ibm.com>,
        "agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
        "borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
        "svens@linux.ibm.com" <svens@linux.ibm.com>,
        "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
        "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        "tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "farman@linux.ibm.com" <farman@linux.ibm.com>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "pasic@linux.ibm.com" <pasic@linux.ibm.com>,
        "vneethv@linux.ibm.com" <vneethv@linux.ibm.com>,
        "oberpar@linux.ibm.com" <oberpar@linux.ibm.com>,
        "freude@linux.ibm.com" <freude@linux.ibm.com>,
        "akrowiak@linux.ibm.com" <akrowiak@linux.ibm.com>,
        "jjherne@linux.ibm.com" <jjherne@linux.ibm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "hch@infradead.org" <hch@infradead.org>,
        "jchrist@linux.ibm.com" <jchrist@linux.ibm.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void
Message-ID: <20220707192210.GC1705032@nvidia.com>
References: <20220706062759.24946-1-nicolinc@nvidia.com>
 <20220706062759.24946-2-nicolinc@nvidia.com>
 <BN9PR11MB527643D01DFF0AFCED1614488C839@BN9PR11MB5276.namprd11.prod.outlook.com>
 <YscUCe+2sXdDiQWq@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YscUCe+2sXdDiQWq@Asurada-Nvidia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jF1/8A1FHJ7j2dWlgRykwoY1bo9vIwqw07ZoGM9pv7pjLVd0zEJpSZTdtR2a?=
 =?us-ascii?Q?YyiAsnSH5FyCTO5wXHbuTNFmq7EyjaTxGSjZNx6MhS1qHndPZ9aICNQ0XyBT?=
 =?us-ascii?Q?ZpCviYEQFYN4eh/4bOc65JJz/Z+/aKc8MsmKU0AG3b7Ggc+jxUBeu6wG9wgv?=
 =?us-ascii?Q?hssBWqqEIjPvjUMNEANZVeef2rrLsLfj1IrpxR86g3HlwPyHmqc233EToZCW?=
 =?us-ascii?Q?tfmyIdSVXIgRFDQReAidAYRo9OedJxRN6V9tJkj1p89Wxo7BfdI2mbVw8lOn?=
 =?us-ascii?Q?AVe4/UBGi0nNJvk2lBEFHPkZE24UkrcZvFz50RfesW9m4TNBZBo+IpA0FVHL?=
 =?us-ascii?Q?YY/zkcN4DB7e3r6doQ1lvf9AA6mJA0u+JSjHNhCe4P5Y9I6p9leilesjERJ9?=
 =?us-ascii?Q?zbTtJ7zX4lb/S6ibH+hp79hZjzJIdGNrqS6+CgnzkewaQle8O6qF3iIlzyvk?=
 =?us-ascii?Q?WQgD0vfrbZ4PxhmRltcXeqe34IPUY3h9GlLpukLKAW7LxotJbicwj7BoK38t?=
 =?us-ascii?Q?xyiSeU6aDg2K7VM6rt2KapxYwmpkCOo95XjidRCAq4L7bS/F9XptwrR9Ujzg?=
 =?us-ascii?Q?x3rBPcKJBOoxb4MJEbubVfxfRxJD4IWN498bRTt8ibrN6hL6QbmlT7QipLfm?=
 =?us-ascii?Q?sV0dtQWe9VXxF6SZDGie2wLhZKDe2PgblyMKAJ73HpEf/IyarXP2K5YpIccA?=
 =?us-ascii?Q?Zpaeo/ku0ExA7jJPKkDT/OcxZAY9ZiW1K/upf72Y0JM6IWDEA5DM9T4/FOHV?=
 =?us-ascii?Q?n5zxFLNQOA4RdWKv2FjjoAkOuuje7395Obx9gJDt1fTGpyad+FJ/qvnDSQn8?=
 =?us-ascii?Q?HKIDR6+yDCrnl2mNzs/IlXTrZ0y60UDrhARPFbfj3UOWwvRCoQEKl2VJZaFr?=
 =?us-ascii?Q?CDpsFX5gLHEcR8KTDNn8D+PhUX7WNkG25cUnB+VWMKAEBt40TXBBAzmdleUI?=
 =?us-ascii?Q?J078dXepbV3s6UXaARCGhVBFprYYgDVly3rXqYo1hHN7ZNYf0L1yYoH225ZG?=
 =?us-ascii?Q?YYVBScHghr/zC9ltHYh7NuYrfSs1PUZ9JJ4sV7Fn8zgZ8LRMNa6iCWZVXDwC?=
 =?us-ascii?Q?N6slXKtD7/yt6IPi+vUvG+Gv5FPOmaSkoYQjD187q6+NJG/2AsMrJTLGEi0h?=
 =?us-ascii?Q?MxsUOba7YS4McjBDEzo0ncXT10Zw9UppRogmRvEL0MYiGusXyonKQbpB9Egi?=
 =?us-ascii?Q?92Y3gAq6LZIHcVgKiCXmhflHzwZ8FRkZadGU7pfSIP8Ao6RWC0v8KXJ8oXYI?=
 =?us-ascii?Q?TFfdvUuJA0S2QcmZm36MBCZB1P9ItEyq8nSN6WG9TAViJewNDkDlm/O6hU0k?=
 =?us-ascii?Q?aonLjdN+lXTcd1FZC+J1AO4gaDTfbwpbW+RlJJsnrFrTbwzfk/Otrkq/bjJl?=
 =?us-ascii?Q?vIe7tT2CtvtZn7iHc+SQbvqkjgiMewLDNgmxv72NcWSd696NnNdMN+92R6eG?=
 =?us-ascii?Q?1P9Nv5gXhyDG/z3GQsXV/2x1pbVMiuOtEk+Z9eFjHmvvQ6dLgANtBikSCiuY?=
 =?us-ascii?Q?bkQNcpB1nLMaezV9I0+bNog/6+QaNZPwDhXvE66yIMqOP/yNUrop6UBY5z/B?=
 =?us-ascii?Q?fyiwKldxcM/gjSUh2ev/4fJnDIJcwg1b83k4XRfI?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d77acf0-6ecb-462c-fbc2-08da604dfe1d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 19:22:12.0659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jnYLcPKap2Yo+nbneH7AtiOGTd4OnrgZgfQb+neATLKXpG5zWO/VImmS1JAviMzS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5356
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2022 at 10:12:41AM -0700, Nicolin Chen wrote:
> On Thu, Jul 07, 2022 at 08:42:28AM +0000, Tian, Kevin wrote:
> > External email: Use caution opening links or attachments
> > 
> > 
> > > From: Nicolin Chen <nicolinc@nvidia.com>
> > > Sent: Wednesday, July 6, 2022 2:28 PM
> > >
> > > There's only one caller that checks its return value with a WARN_ON_ONCE,
> > > while all other callers do not check return value at all. So simplify the
> > > API to return void by embedding similar WARN_ON_ONCEs.
> > 
> > While this change keeps the similar effect as before it leads to different
> > policy for same type of errors between pin and unpin paths:
> 
> I think it's because of the policy that an undo function should not
> fail. Meanwhile, indulging faulty inputs isn't good either.
> 
> > e.g.
> > 
> > vfio_unpin_pages():
> >         if (WARN_ON_ONCE(!user_pfn || !npage || !vfio_assert_device_open(device)))
> >                 return;
> > 
> > vfio_pin_pages():
> >         if (!user_pfn || !phys_pfn || !npage ||
> >             !vfio_assert_device_open(device))
> >                 return -EINVAL;
> > 
> > It sounds a bit weird when reading related code...
> 
> Any better way to handle this?

They should all be WARN_ON's, that is the standard pattern to assert
that function arguments must be correctly formed.

I would also drop the tests that obviously will oops on their on
anyone, like NULL pointer checks. This is a semi-performance path.

Jason