Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753980AbXE3QeJ (ORCPT ); Wed, 30 May 2007 12:34:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751296AbXE3Qd5 (ORCPT ); Wed, 30 May 2007 12:33:57 -0400 Received: from tim.rpsys.net ([194.106.48.114]:34925 "EHLO tim.rpsys.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbXE3Qd5 (ORCPT ); Wed, 30 May 2007 12:33:57 -0400 Subject: Re: [PATCH] Support for controlling leds on xbox 360 pad. From: Richard Purdie To: Dmitry Torokhov Cc: Jan Kratochvil , linux-kernel@vger.kernel.org In-Reply-To: References: <1180474885.5822.94.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 30 May 2007 17:32:20 +0100 Message-Id: <1180542740.5835.135.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 24 Hi Dmitry, On Wed, 2007-05-30 at 10:56 -0400, Dmitry Torokhov wrote: > Do you think it makes sense to split the driver (and Kconfig options) > between input and leds directories as Jan had done? I know that I > prefer to keep anything input related in input directory because it > makes my life as maintainer easier and I bet you prefer the same but > it does not always work well for multifunction devices or devices > using several subsystems... In ideal world having the code in drivers/leds would be preferred but if you want to add the LED code directly to the input driver in this case I have no objection and it probably makes sense. The LED code is already spread about a bit anyway... Cheers, Richard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/